Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 03 Aug 2022 15:16:21 +0530
From:   Siddh Raman Pant <code@siddh.me>
To:     "Ingo Molnar" <mingo@kernel.org>
Cc:     "x86" <x86@kernel.org>,
        "Dave Hansen" <dave.hansen@linux.intel.com>,
        "Andy Lutomirski" <luto@kernel.org>,
        "Peter Zijlstra" <peterz@infradead.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "linux-kernel" <linux-kernel@vger.kernel.org>,
        "linux-kernel-mentees" 
        <linux-kernel-mentees@lists.linuxfoundation.org>
Message-ID: <182631957a7.c72ff42439506.3030495024426988155@siddh.me>
In-Reply-To: <YupC88xuQ4rcyLVR@gmail.com>
References: <20220731160913.632092-1-code@siddh.me>
 <YukFgFTaq4Aw+uht@gmail.com>
 <1825f63b142.8968bde3116633.1242410031840350968@siddh.me>
 <Yuo2UkkyaYtZ3rMZ@gmail.com>
 <18262ed2459.44b0d74d434377.3690496800292832933@siddh.me>
 <Yuo7A0KYoNnbgwWT@gmail.com>
 <18263030220.8a990e82436929.3216192040531777412@siddh.me> <YupC88xuQ4rcyLVR@gmail.com>
Subject: Re: [PATCH] x86/numa: Use cpumask_available instead of hardcoded
 NULL check
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Importance: Medium
User-Agent: Zoho Mail
Precedence: bulk

On Wed, 03 Aug 2022 15:12:11 +0530  Ingo Molnar <mingo@kernel.org> wrote:
> Oh. So I was daft, as suspected. ;-)
>=20
> And I can confirm that while gcc-11 doesn't trigger the warning, gcc-12=
=20
> does:
>=20
>   $ make ARCH=3Dx86_64 CC=3Dgcc-11 arch/x86/mm/numa.o
>     CC      arch/x86/mm/numa.o
>   $
>=20
>   $ rm -f arch/x86/mm/numa.o
>   $
>   $ make ARCH=3Dx86_64 CC=3Dgcc-12 arch/x86/mm/numa.o
>=20
>     CC      arch/x86/mm/numa.o
>   arch/x86/mm/numa.c: In function =E2=80=98cpumask_of_node=E2=80=99:
>   arch/x86/mm/numa.c:916:39: error: the comparison will always evaluate a=
s =E2=80=98false=E2=80=99 for the address of =E2=80=98node_to_cpumask_map=
=E2=80=99 will never be NULL [-Werror=3Daddress]
>     916 |         if (node_to_cpumask_map[node] =3D=3D NULL) {
>=20
>=20
> > [...]
>=20
> Yeah - and I agree with your fix - will apply it.
>=20
> Thanks for your patience :-)
>=20
>     Ingo
>=20

No worries, and thanks! :)
Siddh