Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Wed, 3 Aug 2022 11:18:27 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Libo Chen <libo.chen@oracle.com>
Cc:     K Prateek Nayak <kprateek.nayak@amd.com>, peterz@infradead.org,
        vincent.guittot@linaro.org, mgorman@suse.de,
        tim.c.chen@linux.intel.com, 21cnbao@gmail.com,
        dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
        tglx@linutronix.de
Subject: Re: [PATCH] sched/fair: no sync wakeup from interrupt context
Message-ID: <Yuo9Y4KvQQvvLC/r@gmail.com>
References: <20220711224704.1672831-1-libo.chen@oracle.com>
 <c50bdbfe-02ce-c1bc-c761-c95f8e216ca0@amd.com>
 <YufUj4klPKmKNj26@gmail.com>
 <82620137-5aa5-6cf1-f7aa-6a298e2f7856@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <82620137-5aa5-6cf1-f7aa-6a298e2f7856@oracle.com>
Precedence: bulk


* Libo Chen <libo.chen@oracle.com> wrote:

> 
> 
> On 8/1/22 06:26, Ingo Molnar wrote:
> > * K Prateek Nayak <kprateek.nayak@amd.com> wrote:
> > 
> > > Hello Libo and Peter,
> > > 
> > > tl;dr
> > > 
> > > - We observed a major regression with tbench when testing the latest tip
> > >    sched/core at:
> > >    commit 14b3f2d9ee8d "sched/fair: Disallow sync wakeup from interrupt context"
> > >    Reason for the regression are the fewer affine wakeups that leaves the
> > >    client farther away from the data it needs to consume next primed in the
> > >    waker's LLC.
> > >    Such regressions can be expected from tasks that use sockets to communicate
> > >    significant amount of data especially on system with multiple LLCs.
> > > 
> > > - Other benchmarks have a comparable behavior to the tip at previous commit
> > >    commit : 91caa5ae2424 "sched/core: Fix the bug that task won't enqueue
> > >    into core tree when update cookie"
> > > 
> > > I'll leave more details below.
> > Mel Gorman also warned about this negative side-effect in:
> > 
> >     Subject: Re: [PATCH] sched/fair: no sync wakeup from interrupt context
> >     Date: Fri, 15 Jul 2022 11:07:38 +0100
> >     Message-ID: <20220715100738.GD3493@suse.de>
> > 
> >     https://urldefense.com/v3/__https://lore.kernel.org/all/20220715100738.GD3493@suse.de/__;!!ACWV5N9M2RV99hQ!PQsIeuK0UwII-A0xS-B3plepNniNeyw14OJowT1cYL-tnuN99MkWfg9C8P60tVFFrnxj0NEanUmEkA$
> ?? Mel was talking about a completely different thing, I brought up a
> different patch that I wanted to revert and Mel thought it would hurt other
> workloads which don't benefit from pulling but
> as you can see, tbench somehow benefits from it, at least according to one
> metric from one workload.

Yeah - but nevertheless the discussion with Mel was open-ended AFAICS, and 
the 'major tbench regression' report by K Prateek Nayak above still stands 
and needs to be investigated/understood, right?

Thanks,

	Ingo