Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp276204imn; Wed, 3 Aug 2022 03:28:32 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tB+woTXYjFamWBlgZlFtQcA8smhztCjQ9Q4v6wb1K/NnLYSIHniTL57Xi6nBeDrQfua6J5 X-Received: by 2002:a17:907:3e86:b0:6f5:917:10cc with SMTP id hs6-20020a1709073e8600b006f5091710ccmr19725102ejc.53.1659522512275; Wed, 03 Aug 2022 03:28:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659522512; cv=none; d=google.com; s=arc-20160816; b=flSWOPZU36Dvz/r++yhiwkLgJurd++CPDFzLjYM5EgLHI+w8tzDBeh+F3EzXIdF+ZK mMyYBjUklrxWteirjXT2zXG93ehot/ieE09muOEXG1owzRC+6+eggLoVDkCCxnu9jUI1 eC/sMzrJgk4zv2UkvbOiZz9FZVreT7z8/4EB0o2bgDFhOuV851q9YsiIj+28EpucuEwy YFFjZPxvqmyhav5TZbGC3Pwpnkivytp9yBN+TLzxOGImKA68Ak7s/n/UXXKSSo7kZW5W /lwd5i8OyWU5D6SHYWPPeq6Xc6Faq5NIhficWwL2kzAhLAbsG9vtJLFU75pWb1Klib6x Ny8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=dZuXVKcaDKwEQkILsmWt2bqndYdaJ10vS5x9+2OthmY=; b=dYyJlQPaA+MgA3Td46GJYBHxlTIn1uBZPUzgAxsSTVcbqF7weVR1SFHpZBg9eoTdJg URzOn3fSI9QDbPO9QdEWyAmCLC2nL8LgNSW6iwplPSuTpdsqhBegHmVJ8XcUKQn2LPr8 SA14ZoIvCeq8Tx3YVM/3e8jA+S/6fGFvksD24I3XhLj/SaNMStpfPus8AdoeqUMMcud2 iPsX4uVDhsjcVwpyGLoOAjUyo1exFnvjChEOywkB+b+wBHFVvoUJ9uRqUAFWCu+TJo0z So/zcphqa9xs9RMtlzNQwOTYbSRvjZujKC5t7tCK5rD11jNhK4KsEtVi7kn1l0xivsF0 DK3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jixmJUcG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x3-20020a1709064bc300b0072b4ad153dasi12983069ejv.635.2022.08.03.03.28.07; Wed, 03 Aug 2022 03:28:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jixmJUcG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237315AbiHCKSI (ORCPT + 99 others); Wed, 3 Aug 2022 06:18:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233057AbiHCKSD (ORCPT ); Wed, 3 Aug 2022 06:18:03 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB8E0B3C; Wed, 3 Aug 2022 03:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659521882; x=1691057882; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=wFam+LDcRbKILr0ubXYReeOGRVLmWUy4n8feDpXT4KY=; b=jixmJUcG97PKX5ZUa28+bVmJitLlvDDyE5XCz7Ngn6Sxs2fCCk346OQh /e7FPrzxv/OdN4siefyhkCmDrmkJFuKi1quptgBEu6/s5XmygcajKBJyS ZrsivssBk6Q7Shs30NldTHjA62ZsniOd/HXGIDXlrTKGtCc5gAS4ZwvNo qo42XvQaBejZVxpSQUtCDI1QrL1sCc3Xo8xti8W/but3T4lGXOid1a2+Z es7fB9RoKojXChzirRk7Rdgt+2K7OkYwaS65MVYx5fSlXPS65iNPv2qhQ +W/GCziMYhi4xBvRcr6NoRpWxw/cDdJjsMT1swi02fnY9YKHgpQp6glME Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10427"; a="351350449" X-IronPort-AV: E=Sophos;i="5.93,213,1654585200"; d="scan'208";a="351350449" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2022 03:18:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,213,1654585200"; d="scan'208";a="631095811" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga008.jf.intel.com with ESMTP; 03 Aug 2022 03:17:51 -0700 Date: Wed, 3 Aug 2022 18:13:04 +0800 From: Chao Peng To: Sean Christopherson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song Subject: Re: [PATCH v7 08/14] KVM: Rename mmu_notifier_* Message-ID: <20220803101304.GE607465@chaop.bj.intel.com> Reply-To: Chao Peng References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220706082016.2603916-9-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 29, 2022 at 07:02:12PM +0000, Sean Christopherson wrote: > On Wed, Jul 06, 2022, Chao Peng wrote: > > The sync mechanism between mmu_notifier and page fault handler employs > > fields mmu_notifier_seq/count and mmu_notifier_range_start/end. For the > > to be added private memory, there is the same mechanism needed but not > > rely on mmu_notifier (It uses new introduced memfile_notifier). This > > patch renames the existing fields and related helper functions to a > > neutral name mmu_updating_* so private memory can reuse. > > mmu_updating_* is too broad of a term, e.g. page faults and many other operations > also update the mmu. Although the name most definitely came from the mmu_notifier, > it's not completely inaccurate for other sources, e.g. KVM's MMU is still being > notified of something, even if the source is not the actual mmu_notifier. > > If we really want a different name, I'd vote for nomenclature that captures the > invalidation aspect, which is really what the variables are all trackng, e.g. > > mmu_invalidate_seq > mmu_invalidate_in_progress > mmu_invalidate_range_start > mmu_invalidate_range_end Looks good to me. Thanks. Chao