Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220802212144.6743-1-andriy.shevchenko@linux.intel.com> <87h72tga8y.fsf@kurt>
In-Reply-To: <87h72tga8y.fsf@kurt>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 3 Aug 2022 13:24:24 +0200
Message-ID: <CAHp75VcuFMwTn+EBYGJNPZYzMdFcKTrY2W-u7K79OZRHXyoGRA@mail.gmail.com>
Subject: Re: [PATCH net-next v1 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get()
To:     Kurt Kanzenbach <kurt@linutronix.de>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 3, 2022 at 7:39 AM Kurt Kanzenbach <kurt@linutronix.de> wrote:
>
> On Wed Aug 03 2022, Andy Shevchenko wrote:
> > LED core provides a helper to parse default state from firmware node.
> > Use it instead of custom implementation.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/net/dsa/hirschmann/hellcreek_ptp.c | 45 ++++++++++++----------
> >  1 file changed, 24 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/net/dsa/hirschmann/hellcreek_ptp.c b/drivers/net/d=
sa/hirschmann/hellcreek_ptp.c
> > index b28baab6d56a..793b2c296314 100644
> > --- a/drivers/net/dsa/hirschmann/hellcreek_ptp.c
> > +++ b/drivers/net/dsa/hirschmann/hellcreek_ptp.c
> > @@ -297,7 +297,8 @@ static enum led_brightness hellcreek_led_is_gm_get(=
struct led_classdev *ldev)
> >  static int hellcreek_led_setup(struct hellcreek *hellcreek)
> >  {
> >       struct device_node *leds, *led =3D NULL;
> > -     const char *label, *state;
> > +     enum led_default_state state;
> > +     const char *label;
> >       int ret =3D -EINVAL;
> >
> >       of_node_get(hellcreek->dev->of_node);
> > @@ -318,16 +319,17 @@ static int hellcreek_led_setup(struct hellcreek *=
hellcreek)
> >       ret =3D of_property_read_string(led, "label", &label);
> >       hellcreek->led_sync_good.name =3D ret ? "sync_good" : label;
> >
> > -     ret =3D of_property_read_string(led, "default-state", &state);
> > -     if (!ret) {
> > -             if (!strcmp(state, "on"))
> > -                     hellcreek->led_sync_good.brightness =3D 1;
> > -             else if (!strcmp(state, "off"))
> > -                     hellcreek->led_sync_good.brightness =3D 0;
> > -             else if (!strcmp(state, "keep"))
> > -                     hellcreek->led_sync_good.brightness =3D
> > -                             hellcreek_get_brightness(hellcreek,
> > -                                                      STATUS_OUT_SYNC_=
GOOD);
> > +     state =3D led_init_default_state_get(of_fwnode_handle(led));
>
> Applied your patch to net-next/master and this yields:
>
> |drivers/net/dsa/hirschmann/hellcreek_ptp.c: In function =E2=80=98hellcre=
ek_led_setup=E2=80=99:
> |drivers/net/dsa/hirschmann/hellcreek_ptp.c:430:10: error: implicit decla=
ration of function =E2=80=98led_init_default_state_get=E2=80=99; did you me=
an =E2=80=98led_get_default_pattern=E2=80=99? [-Werror=3Dimplicit-function-=
declaration]
> |  430 |  state =3D led_init_default_state_get(of_fwnode_handle(led));
> |      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> |      |          led_get_default_pattern
>
> The header is missing:
>
> |diff --git a/drivers/net/dsa/hirschmann/hellcreek_ptp.c b/drivers/net/ds=
a/hirschmann/hellcreek_ptp.c
> |index df339f3e1803..430f39172d58 100644
> |--- a/drivers/net/dsa/hirschmann/hellcreek_ptp.c
> |+++ b/drivers/net/dsa/hirschmann/hellcreek_ptp.c
> |@@ -14,6 +14,8 @@
> | #include "hellcreek_ptp.h"
> | #include "hellcreek_hwtstamp.h"
> |
> |+#include "../../../leds/leds.h"
> |+
> | u16 hellcreek_ptp_read(struct hellcreek *hellcreek, unsigned int offset=
)
> | {
> |        return readw(hellcreek->ptp_base + offset);
>
> Maybe move led_init_default_state_get() to linux/leds.h?

Yep, thanks! Missed patch and all of them should be sent as a series...


--=20
With Best Regards,
Andy Shevchenko