Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220803054728.1541104-1-colin.foster@in-advantage.com> <20220803054728.1541104-8-colin.foster@in-advantage.com>
In-Reply-To: <20220803054728.1541104-8-colin.foster@in-advantage.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 3 Aug 2022 13:33:05 +0200
Message-ID: <CAHp75VfV037eyOs9C=pPtG5wg_DLAWkJBk6oyxQNth_YRBeeFQ@mail.gmail.com>
Subject: Re: [PATCH v15 mfd 7/9] resource: add define macro for register
 address resources
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Terry Bowman <terry.bowman@amd.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Wolfram Sang <wsa@kernel.org>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>, katie.morris@in-advantage.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Aug 3, 2022 at 7:47 AM Colin Foster
<colin.foster@in-advantage.com> wrote:
>
> DEFINE_RES_ macros have been created for the commonly used resource types,
> but not IORESOURCE_REG. Add the macro so it can be used in a similar manner
> to all other resource types.

FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>
> (No changes since v14)
>
> v14
>     * Add Reviewed tag
>
> ---
>  include/linux/ioport.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index ec5f71f7135b..b0d09b6f2ecf 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -171,6 +171,11 @@ enum {
>  #define DEFINE_RES_MEM(_start, _size)                                  \
>         DEFINE_RES_MEM_NAMED((_start), (_size), NULL)
>
> +#define DEFINE_RES_REG_NAMED(_start, _size, _name)                     \
> +       DEFINE_RES_NAMED((_start), (_size), (_name), IORESOURCE_REG)
> +#define DEFINE_RES_REG(_start, _size)                                  \
> +       DEFINE_RES_REG_NAMED((_start), (_size), NULL)
> +
>  #define DEFINE_RES_IRQ_NAMED(_irq, _name)                              \
>         DEFINE_RES_NAMED((_irq), 1, (_name), IORESOURCE_IRQ)
>  #define DEFINE_RES_IRQ(_irq)                                           \
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko