Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp323296imn; Wed, 3 Aug 2022 05:28:29 -0700 (PDT) X-Google-Smtp-Source: AA6agR6XhuJky8bmq8fZWqo3LVKAy7RlW401t7F9cx216R2SSMmt8I8wIc3rZRDsTw8F1xvA0hhJ X-Received: by 2002:a17:90b:4b0a:b0:1f2:a904:8af7 with SMTP id lx10-20020a17090b4b0a00b001f2a9048af7mr4805611pjb.76.1659529709210; Wed, 03 Aug 2022 05:28:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659529709; cv=none; d=google.com; s=arc-20160816; b=vc9OKaIWPorgOgN/B4dY+a9x2kfgaFrQgL1rfW2XGS70EIgKsUxwsJ+kBz6b9vfayK Uzx8ZjZdxgbi1aNIGhgQ51BSUX3G0WUGxdYxq7lqGgCklf2rbHGOe2x2cxUTcSMbCGsH Y6bZszJwsUgkzfVYkcF+jONnKfuUrSJ501UGPWJ0aMET7FwjCsiaYyDyqcqFIXKPUBb+ brRkctax+BRuxXssOSK382ovkPMqLNvDr2uRFirs+r6T3u5rFKkJD/b+HK5CapAgkgD0 7u8hLRFjnLjPPdMxUMFmwnddIoZfWMH7JHHhFzMfk1Cz1tPGbkHYB0kc4dHpOP44Gkpf UUmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=NrG8p1Jq8C1f9al42bjX5a/HxyR7iUR/orPoe5SkBBQ=; b=jDv9KPS+KwewT3e1my45gXoG5fVYB3LeR83i8404/uXbDf5T4CGCyZ7jJM21qUKVdN W1gHfATvukf2n0yfAEfuKWjJbkbucX1irzQbATXUhxb+WxRtauW9QON9lV8jGk6QTGhN djGcyyOuZNFJJC73BbCmpniz/P3auzxe3nlzXYybOnamEuPUZwiQXzmdzyDliKJGI4Hh mjL5nY5wVTGmmdbF7a7gYd2PKqZvyc2bHJSojn5igLlTRL7VSyK26i6j/1zGsnhFxpH1 o5MVDofRCQObod16/VufVavNQiPdbbZyV2LWyqiwVohOaroiCIGmzmK3VQYmk4KQLVto cehw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fTb3dMV3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c2-20020a631c42000000b0041bc1f0ef1asi13306751pgm.472.2022.08.03.05.28.14; Wed, 03 Aug 2022 05:28:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fTb3dMV3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238086AbiHCM0y (ORCPT + 99 others); Wed, 3 Aug 2022 08:26:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238010AbiHCM0n (ORCPT ); Wed, 3 Aug 2022 08:26:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 308DF57270; Wed, 3 Aug 2022 05:26:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8F05B82258; Wed, 3 Aug 2022 12:26:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53D99C433C1; Wed, 3 Aug 2022 12:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659529590; bh=gXkbbL4x75dYnAlYPQxV4R73v+dDewWOi3hfCByvglA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fTb3dMV3xzjVw9uQh/dzT3YBMj9dBGOASR3wI23mUayd0u/WyD++aZMSkce4NCBva XeeqN10A7Mc/YF/LUtcyK7Ciu8iewuG70MmexYsxioHJZ2dpKQTW4OQlpmI5IsO4t2 zt1A4Xwxg5h8p9aUmxzaLon8ZRzC4IScyMgl3kdL4D2WtFaa7un+r4x/aS8Mj4P0fg yDThmbcgZQWqy3ZJJ9WkyGU7sXYoOazPve5D4M+aQb1v2llEFqEYfGCGHvnvw5sV8H mowrktM87ntrpdtUVXhhGsa8UES1tVq61VDFSt3iFnzbiAJqdRAI41qZilsVZp87nu KqmRvg/DwE7nA== Message-ID: <0404b476-ce96-0c01-1380-4b6873e79a08@kernel.org> Date: Wed, 3 Aug 2022 15:26:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] usb: cdns3: change place of NULL check in cdns3_gadget_ep_enable() Content-Language: en-US To: Andrey Strachuk , Peter Chen Cc: Greg Kroah-Hartman , Pawel Laszczak , Aswath Govindraju , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org References: <20220728163014.247082-1-strochuk@ispras.ru> From: Roger Quadros In-Reply-To: <20220728163014.247082-1-strochuk@ispras.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/2022 19:30, Andrey Strachuk wrote: > If 'ep' is NULL, result of ep_to_cdns3_ep(ep) is invalid and > priv_ep->cdns3_dev causes panic. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Andrey Strachuk > Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") Acked-by: Roger Quadros cheers, -roger