Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 Aug 2022 15:11:08 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Phillip Potter <phil@philpotter.co.uk>
Cc:     gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        paskripkin@gmail.com, straube.linux@gmail.com, martin@kaiser.cx,
        abdun.nihaal@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: convert rtw_p2p_enable to correct
 error code semantics
Message-ID: <20220803121108.GC3438@kadam>
References: <20220802234408.930-1-phil@philpotter.co.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220802234408.930-1-phil@philpotter.co.uk>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Cai/mI3Gjsx9CQwuUIbKsKBjzB7Oj8SJ8a49ijxO2HsbRgspZdBxXUpK/xK0?=
 =?us-ascii?Q?PbvkCptpo/M049Qth9J9DtrSYTTsBqqhuzbX4UC0+6BYuWfTJL4nXK34T3rO?=
 =?us-ascii?Q?LCRlXyKAG//zhLJknbT/wwf88nq2tXXheePO2SPux2wKBt0HoemJMq461dmG?=
 =?us-ascii?Q?mByUIbSiv7eRy0aDM2eFwwcGGFplbN54pmjOdL+0kTLAXF831k2AlzaDmC7E?=
 =?us-ascii?Q?uuB/hVQ2kQOEZAJRtEO7sxmZVuE7OcR0aeG1+BJ57BWsKGR7cX+UZjfY2q+c?=
 =?us-ascii?Q?CVvLIEAZL5JlNOF45W1e9SQMJSsIzHeat32V4BxaDJPaL2+3hfss5A4hjPAD?=
 =?us-ascii?Q?iy7jeWvMSIhwVT/jyCthnccETDBVLuaa3vY1/HLE5NXUkXRbGcXhe5jRq/9x?=
 =?us-ascii?Q?Kwff50G+E6yvBc1Gc/Ok6Ho2gi42zJTVeENK3Uo1fn74TNQ7Fe/yanNdpEtU?=
 =?us-ascii?Q?XQUXymulHfDsGxS45zVHAq6FUDhECL7+4YsfnH70FWqY+r86Y8DwL+QYspJz?=
 =?us-ascii?Q?IXQu1Hbts5+w/fkzN+c+KeBsQLX8XkF+Xe/SfnUc59sGlyo1FL4gy2NdAbbm?=
 =?us-ascii?Q?DHONrjvUf3Zaiqvk2JUAVbycEhtl41ZKMmy8LSakr6G1nEgohoVApmSM57Rl?=
 =?us-ascii?Q?gTryIdLnPM/szbM7TEGX5xQihTT4X7fIS/0qPPXoZdYk+t6DSNzLocmHvSYm?=
 =?us-ascii?Q?JEvQb3qRjuFXj+PVKOJ9o2vHgdUZ3uDi9t8ZDyXEqMuDX1YDOoSz19jkOp4W?=
 =?us-ascii?Q?cWnMPW9Za645D4fS4jviuJtD6PDzATaoSeyNczM3fIzcM1ezF2wLWwTcO/9p?=
 =?us-ascii?Q?rQgfXLnjrljBjQdgh5XD67H8dm0M5Fxm00jz9ft6J1CUSvRFfV8Z19M5+PYU?=
 =?us-ascii?Q?bFNkYoyWGVKChMCCehTBk1UEsq6vAfp102JlxtVGY6xezer+Chif4RviWzBC?=
 =?us-ascii?Q?fhQHJxwbzVLR9F824sCeDei/bHjRu34JpZ2Dpn3WSTqX6g3rhzsLrSKo1xq8?=
 =?us-ascii?Q?+v/4QPTKX0KZd47ZhDXjrIEt+7nw8tosigZ6X/4Zh0w4nlYQR6Z/aKZ9vkmG?=
 =?us-ascii?Q?nVLTvs9K51bjBRoATX/ZjNRxrqdbJcFQvWWsktnwh1bX2e+sdrWf9x8QJDod?=
 =?us-ascii?Q?/PbytkZaQ7zpeh315W990fhPzdoj/qpg9uHpOEuKeYQOYj+hVp1f1GP4o6b6?=
 =?us-ascii?Q?1wBCkMiKIun3KSs5a3MeBGJZORMYdotLVv9De2tzGUeuSi2WiI/UXSRtuNkH?=
 =?us-ascii?Q?WTFFwlthCH5A5QCSLu+wcN7RY//GK7v7zSBLJJ6eZ6sJ/hpwDdD6PCDjbcLS?=
 =?us-ascii?Q?OjMMoh84tBKk2xrEpcFpLEYIMm1n4Mm4N8AskEZpucex1/k900HSVjVV0MUT?=
 =?us-ascii?Q?U0sptwe+Y1hqLI12CPFndGl458XrBKtJpDOCcp/d28hLTZlfjOl7rjr5iVGW?=
 =?us-ascii?Q?ib2BTGf+c4ASp1j9VRA+R9y0c0DDc4l/PlHg7gk417za1xK3atdGu51Zt5Ew?=
 =?us-ascii?Q?BIQAMwbYp7DTJ84mZCUKr6OAWFHScNEvfYgvlJAaNWzcDTMYKGORvZmLPhoN?=
 =?us-ascii?Q?9rvkwVH/JvvWszBoWxDWe9TUoSIRU+hvYGMsMqhm?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bdcfdf9-ed20-4e14-0179-08da75495389
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 12:11:43.0114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UtFmJA9CZ8tbtUr6+5RzLKAqGBC6R6iJDT31NEluDg1qfmmwTB1K9mQ2+7TmN/6qVwggKy9hFDCoEgEG3iZ9tMmHuXfr7sSPsTur4Wsb4jM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5050
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-03_03,2022-08-02_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 phishscore=0 spamscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2208030052
X-Proofpoint-GUID: aSnXof17eGTOztINtYUL6_TDDKnS1XWd
X-Proofpoint-ORIG-GUID: aSnXof17eGTOztINtYUL6_TDDKnS1XWd
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 03, 2022 at 12:44:08AM +0100, Phillip Potter wrote:
> Convert the rtw_p2p_enable function to use correct error code semantics
> rather than _SUCCESS/_FAIL, and also make sure we allow these to be
> passed through properly in the one caller where we actually check the
> code, rtw_wext_p2p_enable.
> 
> This change moves these functions to a clearer 'return 0;' style at the
> end of the function, and in the case of errors now returns ret instead
> of jumping to the end of the function, so that these can still be passed
> through but without using a goto to jump to a single return statement at
> the end which is less clear.
> 
> This change moves the driver slowly closer to using standard error code
> semantics everywhere.
> 
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>

Looks good.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter