Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d7fb3369-ef7f-8d8f-48bc-fe7cd61047b5@gmx.de>
Date:   Wed, 3 Aug 2022 15:16:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] video: fbdev: arkfb: Fix a divide-by-zero bug in
 ark_set_pixclock()
Content-Language: en-US
To:     Zheyu Ma <zheyuma97@gmail.com>,
        Ondrej Zajicek <santiago@crfreenet.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Antonino Daplas <adaplas@gmail.com>
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220803092313.2492371-1-zheyuma97@gmail.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220803092313.2492371-1-zheyuma97@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 8/3/22 11:23, Zheyu Ma wrote:
> Since the user can control the arguments of the ioctl() from the user
> space, under special arguments that may result in a divide-by-zero bug
> in:
>   drivers/video/fbdev/arkfb.c:784: ark_set_pixclock(info, (hdiv * info->=
var.pixclock) / hmul);
> with hdiv=3D1, pixclock=3D1 and hmul=3D2 you end up with (1*1)/2 =3D (in=
t) 0.
> and then in:
>   drivers/video/fbdev/arkfb.c:504: rv =3D dac_set_freq(par->dac, 0, 1000=
000000 / pixclock);
> we'll get a division-by-zero.
>
> The following log can reveal it:
>
> divide error: 0000 [#1] PREEMPT SMP KASAN PTI
> RIP: 0010:ark_set_pixclock drivers/video/fbdev/arkfb.c:504 [inline]
> RIP: 0010:arkfb_set_par+0x10fc/0x24c0 drivers/video/fbdev/arkfb.c:784
> Call Trace:
>  fb_set_var+0x604/0xeb0 drivers/video/fbdev/core/fbmem.c:1034
>  do_fb_ioctl+0x234/0x670 drivers/video/fbdev/core/fbmem.c:1110
>  fb_ioctl+0xdd/0x130 drivers/video/fbdev/core/fbmem.c:1189
>
> Fix this by checking the argument of ark_set_pixclock() first.
>
> Fixes: 681e14730c73 ("arkfb: new framebuffer driver for ARK Logic cards"=
)
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>

applied to fbdev git tree.

Thanks!
Helge

> ---
>  drivers/video/fbdev/arkfb.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
> index eb3e47c58c5f..ed76ddc7df3d 100644
> --- a/drivers/video/fbdev/arkfb.c
> +++ b/drivers/video/fbdev/arkfb.c
> @@ -781,7 +781,12 @@ static int arkfb_set_par(struct fb_info *info)
>  		return -EINVAL;
>  	}
>
> -	ark_set_pixclock(info, (hdiv * info->var.pixclock) / hmul);
> +	value =3D (hdiv * info->var.pixclock) / hmul;
> +	if (!value) {
> +		fb_dbg(info, "invalid pixclock\n");
> +		value =3D 1;
> +	}
> +	ark_set_pixclock(info, value);
>  	svga_set_timings(par->state.vgabase, &ark_timing_regs, &(info->var), h=
mul, hdiv,
>  			 (info->var.vmode & FB_VMODE_DOUBLE)     ? 2 : 1,
>  			 (info->var.vmode & FB_VMODE_INTERLACED) ? 2 : 1,