Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220802071240.84626-1-cloudliang@tencent.com> <20220802150830.rgzeg47enbpsucbr@kamzik>
In-Reply-To: <20220802150830.rgzeg47enbpsucbr@kamzik>
From:   Jinrong Liang <ljr.kernel@gmail.com>
Date:   Wed, 3 Aug 2022 21:58:51 +0800
Message-ID: <CAFg_LQWB5hV9CLnavsCmsLbQCMdj1wqe-gVP7vp_mRGt+Eh+nQ@mail.gmail.com>
Subject: Re: [PATCH] selftests: kvm: Fix a compile error in selftests/kvm/rseq_test.c
To:     Andrew Jones <andrew.jones@linux.dev>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Sean Christopherson <seanjc@google.com>,
        Jim Mattson <jmattson@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jinrong Liang <cloudliang@tencent.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

My ldd version is (GNU libc) 2.28, and I get a compilation error in this ca=
se.
But I use another ldd (Ubuntu GLIBC 2.31-0ubuntu9.2) 2.31 is compiling fine=
.
This shows that compilation errors may occur in different GNU libc environm=
ents.
Would it be more appropriate to use syscall for better compatibility?

Thanks,
Jinrong Liang

Andrew Jones <andrew.jones@linux.dev> =E4=BA=8E2022=E5=B9=B48=E6=9C=882=E6=
=97=A5=E5=91=A8=E4=BA=8C 23:08=E5=86=99=E9=81=93=EF=BC=9A

>
> On Tue, Aug 02, 2022 at 03:12:40PM +0800, Jinrong Liang wrote:
> > From: Jinrong Liang <cloudliang@tencent.com>
> >
> > The following warning appears when executing:
> >       make -C tools/testing/selftests/kvm
> >
> > rseq_test.c: In function =E2=80=98main=E2=80=99:
> > rseq_test.c:237:33: warning: implicit declaration of function =E2=80=98=
gettid=E2=80=99; did you mean =E2=80=98getgid=E2=80=99? [-Wimplicit-functio=
n-declaration]
> >           (void *)(unsigned long)gettid());
> >                                  ^~~~~~
> >                                  getgid
> > /usr/bin/ld: /tmp/ccr5mMko.o: in function `main':
> > ../kvm/tools/testing/selftests/kvm/rseq_test.c:237: undefined reference=
 to `gettid'
> > collect2: error: ld returned 1 exit status
> > make: *** [../lib.mk:173: ../kvm/tools/testing/selftests/kvm/rseq_test]=
 Error 1
>
> The man page says we need
>
>  #define _GNU_SOURCE
>  #include <unistd.h>
>
> which rseq_test.c doesn't have. We have _GNU_SOURCE, but not unistd.h.
> IOW, I think this patch can be
>
> diff --git a/tools/testing/selftests/kvm/rseq_test.c b/tools/testing/self=
tests/kvm/rseq_test.c
> index a54d4d05a058..8d3d5eab5e19 100644
> --- a/tools/testing/selftests/kvm/rseq_test.c
> +++ b/tools/testing/selftests/kvm/rseq_test.c
> @@ -9,6 +9,7 @@
>  #include <string.h>
>  #include <signal.h>
>  #include <syscall.h>
> +#include <unistd.h>
>  #include <sys/ioctl.h>
>  #include <sys/sysinfo.h>
>  #include <asm/barrier.h>
>
> Thanks,
> drew
>
> >
> > Use the more compatible syscall(SYS_gettid) instead of gettid() to fix =
it.
> > More subsequent reuse may cause it to be wrapped in a lib file.
> >
> > Signed-off-by: Jinrong Liang <cloudliang@tencent.com>
> > ---
> >  tools/testing/selftests/kvm/rseq_test.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/kvm/rseq_test.c b/tools/testing/se=
lftests/kvm/rseq_test.c
> > index a54d4d05a058..299d316cc759 100644
> > --- a/tools/testing/selftests/kvm/rseq_test.c
> > +++ b/tools/testing/selftests/kvm/rseq_test.c
> > @@ -229,7 +229,7 @@ int main(int argc, char *argv[])
> >       ucall_init(vm, NULL);
> >
> >       pthread_create(&migration_thread, NULL, migration_worker,
> > -                    (void *)(unsigned long)gettid());
> > +                    (void *)(unsigned long)syscall(SYS_gettid));
> >
> >       for (i =3D 0; !done; i++) {
> >               vcpu_run(vcpu);
> > --
> > 2.37.1
> >