Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b9a5712-fbb1-afdf-6c5b-fa261832665f@intel.com>
Date:   Wed, 3 Aug 2022 22:11:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [LKP] Re: [xfs] 016a23388c: stress-ng.xattr.ops_per_sec 58.4%
 improvement
Content-Language: en-US
To:     Dave Chinner <david@fromorbit.com>
CC:     kernel test robot <oliver.sang@intel.com>,
        Dave Chinner <dchinner@redhat.com>,
        "Darrick J. Wong" <djwong@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        <linux-xfs@vger.kernel.org>, <lkp@lists.01.org>, <lkp@intel.com>
References: <Yti6PccitrglBtIj@xsang-OptiPlex-9020>
 <20220721220142.GW3861211@dread.disaster.area>
 <9d4e37e2-417e-7a2f-a187-5c7b680c6777@intel.com>
 <20220803010246.GB3600936@dread.disaster.area>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20220803010246.GB3600936@dread.disaster.area>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlVGTTB4Y1BSUTI4WENmZjNWWXpyVGZ5dlYwSmtWVytlQXRwQkxqY0V3ZVVB?=
 =?utf-8?B?bzd1MUlaNjQwTm9nRGNlOUJXZUw0UUFnVkQxQkdHSS9yZUZtRVpEMEFNUTZL?=
 =?utf-8?B?a3lGOHMxY3FkMU5mL3JHUlZyMU1UWXFVL1RLdVY0SzVqRldaYzlEUXVQRlV6?=
 =?utf-8?B?MElkbmMvUFZKMEN3Q0J1SG5BaVFIK2RsWFIrOXI0dGtnUHhEWW1SS2ZuaEYr?=
 =?utf-8?B?Umk2L0dMeW9RUzVtMHJQOGZTdFhhOUhKbGdodjVwbTNOSlRWc0R2eEhETHI1?=
 =?utf-8?B?TElPMnhGYytXS3ZtNWlqaVExUjFDMS9sSjB2T0NqM3dtR3oyUHd6aEVYZG1m?=
 =?utf-8?B?dXQzcVhHNE5td2g0b1JDNUtKZ1JSdnFZK1pudEUvcGFMM1dWQ3RPeEJhTlJL?=
 =?utf-8?B?dWhkWFQvWHlXTEp0SW5PT29BRHg2N2g5a0NqdGx1dXNRQXlOdEtXVndzMC9D?=
 =?utf-8?B?cGRWR1FzUVNITGxZN0RCWGtNMzlZQXFNaHZpMG1PeGRMQlhHTE1jUzZkR256?=
 =?utf-8?B?d29NWTgrSGRYVHlFNnBKcFNPNEtVa3o0YTlJdGgxanpqS2dpN2I5ZDJ1dlU0?=
 =?utf-8?B?dldPTk1OKzNMNW5neGd5ZGozOWRxblZzRWlhdTNkQWtRUWVVbVprME9wUGUx?=
 =?utf-8?B?ZFVlbE4rdUNtenpCOXlGdkpWbUFiRm1CTXFIQmNFVTBXQm9FN1ZtQnM2VDhN?=
 =?utf-8?B?Tmd3OUdEM3BCYUZ3NkdLUXFnN2RwSE9Oem9MR1BESXpsdWF5OVRIUnNaOU9T?=
 =?utf-8?B?R2hXVXQvM3o3NWlPbHRONEF2cHJqcStEcVAwMis5SkVhY1Yzem5hOXpIb2xO?=
 =?utf-8?B?L1hwQWphZjJOQUlMMndDeldUMFRsTkJzYTY0M0VMOHZKM1hXcmEwL2VPT2FO?=
 =?utf-8?B?UEJrZVpMakRla3NPWXJLUThEdGoxamlUWG1jN0R2bURpTHBoOFJaaWpMb1l5?=
 =?utf-8?B?QnFhN3NBcC9FdXRMUUFtLzRLeVNjWFVvenBpTHYvMWllKzZMcHFsTkpFVkZl?=
 =?utf-8?B?bXcwUHFUTThyUUFrN05CZXhlNDEvNVlkOVNKdWFqS3IyR000d2pGa2tQeUhq?=
 =?utf-8?B?cW0zcHpBeWlVeklLZVhNdU5KUnViaUc2SEFreUNtdW81TE5nTU9qZFJudExy?=
 =?utf-8?B?QmsvMERhNTJWWHF2RFkzVmRQSW9pREg5ZHdhMHBiYTYxWm1vV3Vodjg1QWRX?=
 =?utf-8?B?S2xqWE8vYWpQZUNGcjNZNmhla0RBb2g0S1dnaXpXZldLSlhISFVKQk9rSW1E?=
 =?utf-8?B?VHZlQ3A1RFJZN1F0MEE5RlRnSUpEMzNyRzVxUVNUTW9oUE9Hczc1N3RuU3NU?=
 =?utf-8?B?TlJOemZQck9FelZyR25VdmhBY3BBbFlJdFpzMlMxZWk1RHFpeDAzSEpCalNn?=
 =?utf-8?B?VUZQVFlzRmxFMjlXZHV3ZGxRVWpsbXRmQXNsZmo2QXFIc05NK0o1VnFYMXZ0?=
 =?utf-8?B?VEJCYm1sTFJyQ1piK0NycTh6S1ZpVFhDNEQra21PempSWTNhTmFmVy80dlVJ?=
 =?utf-8?B?VENEMmlnWGdyeUREa09OdkdqMlFyajN6MDErZ05VdVB2ZC8xbFhIaXhZUFZY?=
 =?utf-8?B?RFFreDBudVRTMmhGYWNWNUdpbXk5bjNDVE9oZXdhVWZQa2ZaTjdEdlZlNUN2?=
 =?utf-8?B?bS9ISkZielU4RGg5ZmUrd3k0TG80ck1xRTZsQmoyaytPUWhyemxmNXV2U3Z6?=
 =?utf-8?B?SmRoSHVZWGRXTnZFYXRPRDZFayswNytYNDVEaXVSb1JkbjJvRkVaR3NETjZp?=
 =?utf-8?B?ZjczNTRJa0FQczA5UkNQTW5WUzA5cldkYkdHdHB6YnNlZW9qdjU1U1M1RGFK?=
 =?utf-8?B?NDZTZ1hONVdzWEJEZ1RabGJVOUMvdGhyajJLK2s5ak1mZ3doNllVU24xajRr?=
 =?utf-8?B?SzF1eWFTRVVUNGM4M0IvR0ZIUlhiR1p6ZmdHQkpmdHBLRkJXeTVWWWFHMGht?=
 =?utf-8?B?WmQrYSttb3ZHOVJtam40TEYxeGlKRmJMYkg3TEErTWNMVUJFMjJnVmFmaGtm?=
 =?utf-8?B?ZUR2OUtrcnVYdUFtZk8zR29yTk5VTURmdU5GdG4yQ2ZHRGZvRGw3UE1jYU54?=
 =?utf-8?B?aGtZS0xUZGdINno4VUJKTWJiTEM4UzNCazNpRTRQSjlUUEJFcTBDVFN2NWY4?=
 =?utf-8?B?Uk9kNkJFTDlMQTVGSmZmZ29xczIrTlgvVzE3eEN1Z0ZFQldoNDcwOGlUMFlB?=
 =?utf-8?B?dXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: be84c172-a83c-425d-3750-08da755a0469
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 14:11:10.9575
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UegXPt6e1JYo/M9GaCeXERw+lB0TGg7UjgrimewrRZQ/W7D83pQRd2DBpuB0yrFZLfrpxK+624NAhUapf/4PZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6335
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dave,

On 8/3/2022 9:02 AM, Dave Chinner wrote:
> That a single cacheline miss avoids all the spinlock contention is
> just pure luck - it'll come back if other work is being done on the
> machine that consumes enough memory bandwidth to push this back over
> the edge.

Agree. We did see some strange performance boost which can't be connected
to the code change. And worried later unrelated change reduce the
mysterious performance gain (and report it as regression).

Regards
Yin, Fengwei