Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp375422imn; Wed, 3 Aug 2022 07:36:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uqatUAOZwIBs85AmLcSQz4tqonXMPI7T3fawh86IEPnPBQMWd/clhd6gPdfvmTWKtwHKNr X-Received: by 2002:a17:906:7955:b0:72f:5c1f:1816 with SMTP id l21-20020a170906795500b0072f5c1f1816mr21059542ejo.396.1659537400757; Wed, 03 Aug 2022 07:36:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659537400; cv=none; d=google.com; s=arc-20160816; b=y1sAtW1eSoQ2bG4PRQ+aqYu0aksSSTe3qAi+u5vZTGjxPWe7Qz1BmcVHhclrLC3r8+ YsAagsPxakQifimL4cXytYWZL6lIJHX2oVvGUKRH+OPJloh6ghs9x2YGGO6mS5rZzTGJ BVuQbzf4JIa1VqT5s24pGkOKS5w+Ii5g0eOzq1E4xuS6tXzoSwvx466QQF5bOf5vYIc6 t3CwoE4t72+yxPUNUEce/fcQFkQZa9pv1uQBjlMQhp1ARxn7p2rlAuV5t/ffH+7WO4cO AXQf0wNhP6Ecui6CYuajqPtZ8T06jHmYvMnABCNB9ViE8yvS8f/fMvw1qla+qjKUOBWE fgfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=FkSMxi+mMmAs4jWG4U0RwbzZFwLC2BrYcNnQ0tWt5eE=; b=cVPSFGrfusEUsLbrRGVscjanlpy/qakN7JbnjP3fwgDPVhzMZXquhEcW7R2mJmhe2Q nCyw4D08L8/VqIRCHBjs1b0l+5pGNF2x3AHh+aoyKfnf3e+W73g6RZBg7o1IzFtWKDls z2ALdPQ25lE0O90SiI6qU5MMtzREzf0pKXhJAFwJoF8o3gBw56o0OLDCDdnK2P/31ItC qa7NEu4DgDAhHqygFwJ8yl8wSwVcCP6IriPA/ULyyw8UirbCKzj7DFfaDxjt+36/WBIX xbPZG/ug+C5K7TvGhvQ+VTotB/owkSJAyf9uzD2GXY+hTWRWAkxHqYcYyJamGGhXzaSz CxsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=wz5QLRyg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn2-20020a17090794c200b00711fd60fa17si16626301ejc.34.2022.08.03.07.36.15; Wed, 03 Aug 2022 07:36:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=wz5QLRyg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238737AbiHCOWQ (ORCPT + 99 others); Wed, 3 Aug 2022 10:22:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238518AbiHCOWI (ORCPT ); Wed, 3 Aug 2022 10:22:08 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71C1D1583D; Wed, 3 Aug 2022 07:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1659536524; x=1691072524; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=FkSMxi+mMmAs4jWG4U0RwbzZFwLC2BrYcNnQ0tWt5eE=; b=wz5QLRyg7uPn1FqBN3ZxacfnuNSdjPZQ4ESWEJsE8yGkWTRdZru+XtWU tVJyTgwyOZP0VdHiK6qz6S737FdcToi28veHRnG13tXCKfcDaXu8Jxlwy IVziRzB14y3gsXX26LBWBfVpFbaddzVHpyczd0fmQtph7yghUvZd2VvlB 0=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-01.qualcomm.com with ESMTP; 03 Aug 2022 07:22:04 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2022 07:22:03 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 3 Aug 2022 07:22:03 -0700 Received: from hu-srivasam-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 3 Aug 2022 07:21:57 -0700 From: Srinivasa Rao Mandadapu To: , , , , , , , , , , , , , , , , CC: Srinivasa Rao Mandadapu Subject: [PATCH 4/8] remoteproc: qcom: Update hard coded values with macros Date: Wed, 3 Aug 2022 19:51:16 +0530 Message-ID: <1659536480-5176-5-git-send-email-quic_srivasam@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1659536480-5176-1-git-send-email-quic_srivasam@quicinc.com> References: <1659536480-5176-1-git-send-email-quic_srivasam@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Update hard coded values with appropriate macro names. Signed-off-by: Srinivasa Rao Mandadapu --- drivers/remoteproc/qcom_q6v5_adsp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c index bb4494c..a9fcb5c 100644 --- a/drivers/remoteproc/qcom_q6v5_adsp.c +++ b/drivers/remoteproc/qcom_q6v5_adsp.c @@ -54,6 +54,9 @@ #define QCOM_Q6V5_RPROC_PROXY_PD_MAX 3 +#define LPASS_BOOT_CORE_START BIT(0) +#define LPASS_BOOT_CMD_START BIT(0) + struct adsp_pil_data { int crash_reason_smem; const char *firmware_name; @@ -364,10 +367,10 @@ static int adsp_start(struct rproc *rproc) writel(adsp->mem_phys >> 4, adsp->qdsp6ss_base + RST_EVB_REG); /* De-assert QDSP6 stop core. QDSP6 will execute after out of reset */ - writel(0x1, adsp->qdsp6ss_base + CORE_START_REG); + writel(LPASS_BOOT_CORE_START, adsp->qdsp6ss_base + CORE_START_REG); /* Trigger boot FSM to start QDSP6 */ - writel(0x1, adsp->qdsp6ss_base + BOOT_CMD_REG); + writel(LPASS_BOOT_CMD_START, adsp->qdsp6ss_base + BOOT_CMD_REG); /* Wait for core to come out of reset */ ret = readl_poll_timeout(adsp->qdsp6ss_base + BOOT_STATUS_REG, -- 2.7.4