Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966306AbXFGD1p (ORCPT ); Wed, 6 Jun 2007 23:27:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965527AbXFGD1h (ORCPT ); Wed, 6 Jun 2007 23:27:37 -0400 Received: from gate.crashing.org ([63.228.1.57]:42472 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965390AbXFGD1g (ORCPT ); Wed, 6 Jun 2007 23:27:36 -0400 Subject: Re: [BUG] ptraced process waiting on syscall may return kernel internal errnos From: Benjamin Herrenschmidt To: Linus Torvalds Cc: Roland McGrath , Andrew Morton , Linux Kernel , Satoru Takeuchi , Oleg Nesterov In-Reply-To: References: <20070606105900.DE5E94D0592@magilla.localdomain> Content-Type: text/plain Date: Thu, 07 Jun 2007 13:27:01 +1000 Message-Id: <1181186821.14818.13.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 22 On Wed, 2007-06-06 at 08:35 -0700, Linus Torvalds wrote: > So now we should do "recalc_sigpending()" only when signals may be > *added* > (where messing with the "blocked" mask obviously is a form of adding > signals, and possibly the most common reason for having to recalculate > the > sigpending mask). > > Comments? This patch is _entirely_ and utterly untested, so I'm only > saying that this "feels" safer and more correct to me. Oh and we still need to at least do the if (tsk == current) thingy for the DRM notifier hack... Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/