Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 Aug 2022 08:42:02 -0700
From:   Stephen Hemminger <stephen@networkplumber.org>
To:     Antonio Quartulli <antonio@openvpn.net>
Cc:     Andrew Lunn <andrew@lunn.ch>, netdev@vger.kernel.org,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload
 (ovpn-dco)
Message-ID: <20220803084202.4e249bdb@hermes.local>
In-Reply-To: <52b9d7c9-9f7c-788e-2327-33af63b9c748@openvpn.net>
References: <20220719014704.21346-1-antonio@openvpn.net>
        <20220719014704.21346-2-antonio@openvpn.net>
        <YtbNBUZ0Kz7pgmWK@lunn.ch>
        <c490b87c-085b-baca-b7e4-c67a3ee2c25e@openvpn.net>
        <YuKKJxSFOgOL836y@lunn.ch>
        <52b9d7c9-9f7c-788e-2327-33af63b9c748@openvpn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 28 Jul 2022 15:16:10 +0200
Antonio Quartulli <antonio@openvpn.net> wrote:

> Hi Andrew,
> 
> On 28/07/2022 15:07, Andrew Lunn wrote:
> > Also, using a mainline driver out of tree is not easy. The code will
> > make use of the latest APIs, and internal APIs are not stable, making
> > it hard to use in older kernels. So you end up with out of tree
> > wrapper code for whatever version of out of tree Linux you decide to
> > support. Take a look at
> > 
> > https://github.com/open-mesh-mirror/batman-adv  
> 
> Yeah, this is exactly what we are already doing.
> We're just trying to keep is as simple as possible for now:
> 
> https://github.com/OpenVPN/ovpn-dco/blob/master/linux-compat.h
> 
> Thanks for the pointer anyway (I am already deeply inspired by 
> batman-adv, as you may imagine ;-)),
> 

Kernel submissions for upstream must be standalone, and any infrastructure
that is only used by an out of tree kernel driver will not be accepted.

The version you propose upstream must have no linux-compat wrappers.
Sorry kernel developers don't care or want to be concerned about some
out of tree project.