Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a7107bad-cb41-f612-2ff1-a67ab5830865@kernel.org>
Date:   Wed, 3 Aug 2022 09:36:49 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH v3 net] geneve: fix TOS inheriting for ipv4
Content-Language: en-US
To:     Matthias May <matthias.may@westermo.com>, netdev@vger.kernel.org
Cc:     davem@davemloft.net, yoshfuji@linux-ipv6.org, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, nicolas.dichtel@6wind.com,
        eyal.birger@gmail.com, linux-kernel@vger.kernel.org,
        jesse@nicira.com, pshelar@nicira.com, tgraf@suug.ch
References: <20220802122025.1364123-1-matthias.may@westermo.com>
From:   David Ahern <dsahern@kernel.org>
In-Reply-To: <20220802122025.1364123-1-matthias.may@westermo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/2/22 6:20 AM, Matthias May wrote:
> @@ -822,6 +823,7 @@ static struct rtable *geneve_get_v4_rt(struct sk_buff *skb,
>  		use_cache = false;
>  	}
>  	fl4->flowi4_tos = RT_TOS(tos);

Could make this optional with
	if (full_tos)
> +		*full_tos = tos;
>  
>  	dst_cache = (struct dst_cache *)&info->dst_cache;
>  	if (use_cache) {

...

> @@ -1137,6 +1140,7 @@ static int geneve_fill_metadata_dst(struct net_device *dev, struct sk_buff *skb)
>  {
>  	struct ip_tunnel_info *info = skb_tunnel_info(skb);
>  	struct geneve_dev *geneve = netdev_priv(dev);
> +	__u8 full_tos;
>  	__be16 sport;
>  
>  	if (ip_tunnel_info_af(info) == AF_INET) {
> @@ -1148,7 +1152,8 @@ static int geneve_fill_metadata_dst(struct net_device *dev, struct sk_buff *skb)
>  					  1, USHRT_MAX, true);
>  
>  		rt = geneve_get_v4_rt(skb, dev, gs4, &fl4, info,
> -				      geneve->cfg.info.key.tp_dst, sport);
> +				      geneve->cfg.info.key.tp_dst, sport,
> +				      &full_tos);
>  		if (IS_ERR(rt))
>  			return PTR_ERR(rt);
>  

since this one is not used