Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp406694imn; Wed, 3 Aug 2022 08:54:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR6Ys3BP7EE2Xhok6al7YSa0+MvtlnRSpkM+KThoH5k12MDPn452oJgJLjUZ2eeuaRBNN5wy X-Received: by 2002:a17:902:aa48:b0:16f:1364:788b with SMTP id c8-20020a170902aa4800b0016f1364788bmr4329618plr.109.1659542067168; Wed, 03 Aug 2022 08:54:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659542067; cv=none; d=google.com; s=arc-20160816; b=PiXMNf1buSl/fkPenXK7JXZS7VAmNFcdmj9EL9xg5Y4eGKqOjIxot1uQRvjLXTOG56 Bp8UJCskllGZz/YvX2j9aJRGv3oPNSCsgNHV/7NsfWDOfyZn8ipqUJOJ7KaiErA0TsQE aaKU67c4p5M08fKY/IAYzW9CuQLImYbU4uTnB77/Y2LuDzSfIy0BeAceYFU7UuF4GeIy 0sfzUVCSy0O+015up4FPxtkEcEc7Qjtot6KssVh7YgnGOkcJ5oAiG52gzTgoIBUKTDks wEcYxig8pPeH4riQyQJ3yH/yC/M/Bq8SkfJHyKNnhmBIwowIJwnApymC4tQ8NckPqnTR luFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ThplJ8IHF9IznuW9y6nPyTNnXMAPmQCa7vY+5A4uob8=; b=tyuPfdN+/cPbVLWZGuAG8UK9AcxHc8S5htgwf1Z32l86SzmkGO7XlV6YcjPJSpMZ0h uWnzX2FOWYTH2C9Q4T0fWHy38nCWd/10ZrSPVmz8u1CP55f7FiR6ExSxlXiH0ap64PLy Gqr4bhzhUtU0OUpdIRn4Bng/CS80TKz5snMEEGdm59Tfk5ddQk39CH9eaEH8LKgxeOQK rlDmcvsfY6ZIDbQIXUCPEGaRDLaUSkTSx4qpzqwUT8WmuQDNxYhnCV2jVIazjI1xBvXT p4SRXKezuJt25YvA7SM1oaJ/LxCmQ4ahYhU85BlX5zYdeB5+lwVRK7vieOSNcUy5EPBJ ycVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T3B2jTsx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w21-20020a631615000000b0041b698ead1asi4223584pgl.794.2022.08.03.08.54.11; Wed, 03 Aug 2022 08:54:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T3B2jTsx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237860AbiHCPvC (ORCPT + 99 others); Wed, 3 Aug 2022 11:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238343AbiHCPuq (ORCPT ); Wed, 3 Aug 2022 11:50:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 16AFF9FEB for ; Wed, 3 Aug 2022 08:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659541839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ThplJ8IHF9IznuW9y6nPyTNnXMAPmQCa7vY+5A4uob8=; b=T3B2jTsxozhHUY8dBhdxWECGiwH4POhaVo2pqJDT/FiPinVDXnD7LfZ+Zy4PJgwkQmvXUK Dob5pTPpu5YNhVf+a/zhDP+MyFl4RQ74SXhMduArGNIKHbEBJ8PJGhNZqi4PIa5HypgsIZ sVI7V+PoAwzHCnAXRTrdytSzEgdoGUY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-277-mqHa6Xm0NL-Omt0tAJuTpQ-1; Wed, 03 Aug 2022 11:50:35 -0400 X-MC-Unique: mqHa6Xm0NL-Omt0tAJuTpQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 39B4D18A6522; Wed, 3 Aug 2022 15:50:34 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.242]) by smtp.corp.redhat.com (Postfix) with ESMTP id 96D261121319; Wed, 3 Aug 2022 15:50:30 +0000 (UTC) From: Maxim Levitsky To: kvm@vger.kernel.org Cc: Borislav Petkov , Dave Hansen , linux-kernel@vger.kernel.org, Wanpeng Li , Maxim Levitsky , Ingo Molnar , Sean Christopherson , x86@kernel.org, Jim Mattson , Kees Cook , Thomas Gleixner , "H. Peter Anvin" , Joerg Roedel , Vitaly Kuznetsov , Paolo Bonzini Subject: [PATCH v3 04/13] KVM: x86: emulator: update the emulation mode after rsm Date: Wed, 3 Aug 2022 18:50:02 +0300 Message-Id: <20220803155011.43721-5-mlevitsk@redhat.com> In-Reply-To: <20220803155011.43721-1-mlevitsk@redhat.com> References: <20220803155011.43721-1-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This ensures that RIP will be correctly written back, because the RSM instruction can switch the CPU mode from 32 bit (or less) to 64 bit. This fixes a guest crash in case the #SMI is received while the guest runs a code from an address > 32 bit. Signed-off-by: Maxim Levitsky --- arch/x86/kvm/emulate.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index bc70caf403c2b4..5e91b26cc1d8aa 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -2666,6 +2666,11 @@ static int em_rsm(struct x86_emulate_ctxt *ctxt) if (ret != X86EMUL_CONTINUE) goto emulate_shutdown; + + ret = emulator_recalc_and_set_mode(ctxt); + if (ret != X86EMUL_CONTINUE) + goto emulate_shutdown; + /* * Note, the ctxt->ops callbacks are responsible for handling side * effects when writing MSRs and CRs, e.g. MMU context resets, CPUID -- 2.26.3