Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 Aug 2022 18:57:42 +0300
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Benson Leung <bleung@google.com>
Cc:     Rajat Khandelwal <rajat.khandelwal@intel.com>,
        andreas.noever@gmail.com, michael.jamet@intel.com,
        YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, pmalani@google.com
Subject: Re: [PATCH] Supporting wake on DP hot events behind TBT/USB4 routers
Message-ID: <Yuqa9vjEBjWAMyf9@lahna>
References: <20220803010139.GA32634@rajth-NUC10i7FNH>
 <YuoJceCfuJ4RKon5@lahna>
 <CANLzEkucqXP6fU1OZ0+B4p10SXiR7-BJa+dn5xjp20UhE8UsEg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANLzEkucqXP6fU1OZ0+B4p10SXiR7-BJa+dn5xjp20UhE8UsEg@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

Hi Benson,

On Wed, Aug 03, 2022 at 08:15:49AM -0700, Benson Leung wrote:
> Hi Mika,
> 
> On Tue, Aug 2, 2022 at 10:37 PM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > Hi,
> >
> > On Wed, Aug 03, 2022 at 06:31:39AM +0530, Rajat Khandelwal wrote:
> > > Current implementation doesn't allow user to go into system suspend
> > > and simultaneously project the screen on an external display connected
> > > to a TBT/USB4 device. This patch enables this feature.
> > >
> > > Let me know what you think about this.
> >
> > Please prefix patches to follow the sybsystem style. For Thunderbolt it
> > should be "thunderbolt: ....".
> >
> > This will cause any monitor plug to wake up the system and I'm not sure
> > we want that, at least to be default behaviour. If you have a regular
> > Type-C (non-USB4/TBT) dock and you plug in a monitor to that, does it
> > wake up?
> 
> Speaking for Google and our ChromeOS USB-C policy, yes, if the host is
> in S0iX or S3, an already attached USB-C docking station in DP Alt
> Mode will respond to a display attach via HPD via an Alert message in
> USB PD. We called this feature wake-on-dock.
> 
> We implemented wake-on-dock for DP Alt Mode in the EC, since our EC
> handles USB PD anyway, and is handling the PD Alert message which
> contains the HPD status.
> 
> However, when the dock supports USB4 or Thunderbolt, those modes don't
> involve USB PD for device attach, so our EC doesn't have the role of
> waking the system, so something else on the system must, which is this
> feature being discussed.

Okay understood. Thanks for explaining!