Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 Aug 2022 18:38:16 +0200
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Danilo Krummrich <dakr@redhat.com>
Cc:     daniel@ffwll.ch, laurent.pinchart@ideasonboard.com,
        airlied@linux.ie, tzimmermann@suse.de, mripard@kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH drm-misc-next v7 0/5] drm: rename CMA helpers to DMA
 helpers
Message-ID: <YuqkeDmV0nFVhYuG@ravnborg.org>
References: <20220802000405.949236-1-dakr@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220802000405.949236-1-dakr@redhat.com>
Precedence: bulk

Hi Danilo,

On Tue, Aug 02, 2022 at 02:04:00AM +0200, Danilo Krummrich wrote:
> This patch series renames all CMA helpers to DMA helpers - considering the
> hierarchy of APIs (mm/cma -> dma -> gem/fb dma helpers) calling them DMA
> helpers seems to be more applicable.
> 
> Additionally, commit e57924d4ae80 ("drm/doc: Task to rename CMA helpers")
> requests to rename the CMA helpers and implies that people seem to be confused
> about the naming.
> 
> The patches are compile-time tested building a x86_64 kernel with
> `make allyesconfig && make drivers/gpu/drm`.
> 
> Changes in v2:
>   - Fixed up comments for consistent memory/address classification
>     (DMA-contiguous)
>   - Added a patch to rename struct drm_gem_dma_object.{paddr => dma_addr}
> 
> Changes in v3:
>   - Use a ccoccinelle script for
>     "drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr}" for fixing
>     up missing drivers and compile-test on x86_64, arm and arm64.
> 
> Changes in v4:
>   - Rebased all patches on drm-misc/drm-misc-next.
> 
> Changes in v5:
>   - Rebase of v4, meanwhile some merge conflicts came up on
>     drm-misc/drm-misc-next.
> 
> Changes in v6:
>   - Added a patch to remove unused include occurances of drm_fb_cma_helper.h
>     in various drivers.
> 
> Changes in v7:
>   - Fix `select DRM_KMS_{CMA => DMA}_HELPER` and
>         `select DRM_GEM_{CMA => DMA}_HELPER` in
>     drivers/gpu/drm/logicvc/Kconfig and drivers/gpu/drm/mxsfb/Kconfig which
>     slipped through in a rebase.
>   - Another rebase.
> 
> Danilo Krummrich (5):
>   drm/fb: remove unused includes of drm_fb_cma_helper.h
>   drm/fb: rename FB CMA helpers to FB DMA helpers
>   drm/gem: rename GEM CMA helpers to GEM DMA helpers
>   drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr}
>   drm/todo: remove task to rename CMA helpers

Thanks for looking into this task!
The patches are now applied to drm-misc (drm-misc-next).

	Sam