Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbXFGFwg (ORCPT ); Thu, 7 Jun 2007 01:52:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751022AbXFGFw1 (ORCPT ); Thu, 7 Jun 2007 01:52:27 -0400 Received: from wr-out-0506.google.com ([64.233.184.234]:28013 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbXFGFw0 (ORCPT ); Thu, 7 Jun 2007 01:52:26 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Hn8/YC8g7BF9AvmhMdtcEBLTBPlKiKZ/1+5vcE+dObwvIFYGC5oOC3tq06k771t0ctvKiBWo4ONs62rSbT0vGCj34cpwPaU/c+jHXexVhUsOxjIr83Zb8mEiFcvpoyAbowRGlPU6QsBr2o7GGKDqICSKD1DOiDMDPOoybA+KJdk= Message-ID: Date: Thu, 7 Jun 2007 11:22:25 +0530 From: "Satyam Sharma" To: "Greg KH" Subject: Re: [linux-usb-devel] [PATCH] bug removing ehci-hcd Cc: Stuart_Hayes@dell.com, akpm@linux-foundation.org, malattia@linux.it, gregkh@suse.de, linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net, linux-usb-devel@lists.sourceforge.net In-Reply-To: <20070607041924.GA8545@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070529093324.92e571a0.akpm@linux-foundation.org> <20070607041924.GA8545@kroah.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1600 Lines: 44 Hi, I remember this one ... On 6/7/07, Greg KH wrote: > On Thu, May 31, 2007 at 10:26:10AM -0500, Stuart_Hayes@Dell.com wrote: > > > > I wasn't actually able to reproduce the bug myself, but I guess it is > > pretty obvious that I shouldn't have called cpufreq_unregister_notifier > > with a spinlock held. I haven't been doing this long enough to know > > exactly which kernel this patch should be against, so let me know if > > this ins't good. Thanks! > > > > > > This patch (for the 2.6.21.3 kernel plus previously sent cpufreq > > notifier patch) fixes a bug caused by calling > > cpufreq_unregister_notifier (which can sleep) while holding a spinlock. > > > > Signed-off-by: Stuart Hayes > > Hm, this doesn't apply to the 2.6.21.3 kernel. The cpufreq patches only live in -mm as of now ... > Can you send both patches merged together? > > And is the fix already in Linus's tree? Andrew seems to have already fixed this in the latest -mm (in this very thread, funnily enough, looks like you missed it as the subject change broke the threading :-) [ There is a subtle difference, however, in that Andrew's fix pushes the notifier unregistration /after/ the spin_unlock_irq(&ehci->lock) critical section whereas Stuart seems to be prefer doing it /before/ the corresponding spin_lock_irq() ... ] Satyam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/