Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 Aug 2022 18:40:03 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Sudip Mukherjee <sudip.mukherjee@sifive.com>
Cc:     Serge Semin <fancer.lancer@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Greentime Hu <greentime.hu@sifive.com>,
        Jude Onyenegecha <jude.onyenegecha@sifive.com>,
        William Salmon <william.salmon@sifive.com>,
        Adnan Chowdhury <adnan.chowdhury@sifive.com>,
        Ben Dooks <ben.dooks@sifive.com>, linux-spi@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jeegar Lakhani <jeegar.lakhani@sifive.com>
Subject: Re: [PATCH 01/11] spi: dw: define capability for enhanced spi
Message-ID: <Yuqy8wJyHASPdIBG@sirena.org.uk>
References: <20220802175755.6530-1-sudip.mukherjee@sifive.com>
 <20220802175755.6530-2-sudip.mukherjee@sifive.com>
 <YulxX3Zo168cWhwP@sirena.org.uk>
 <CAHyZL-dA+mFW6Jcvpds69f-9iJf6nk7PCpO6S2Au+ugSZMgisw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jZMkXTlYS07CDysu"
Content-Disposition: inline
In-Reply-To: <CAHyZL-dA+mFW6Jcvpds69f-9iJf6nk7PCpO6S2Au+ugSZMgisw@mail.gmail.com>
Precedence: bulk


--jZMkXTlYS07CDysu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 03, 2022 at 06:34:53PM +0100, Sudip Mukherjee wrote:
> On Tue, Aug 2, 2022 at 7:48 PM Mark Brown <broonie@kernel.org> wrote:
> > On Tue, Aug 02, 2022 at 06:57:45PM +0100, Sudip Mukherjee wrote:

> > > +#define DW_SPI_CAP_EXT_SPI           BIT(2)

> > This isn't at all descriptive, it'd be better to have a capability bit
> > for the various multi-line data modes (or possibly individual bits for
> > them, though board setup will stop us using things that aren't supported
> > in a given design anyway so it's a bit redundant) - that'd be a lot
> > clearer and avoid confusion further down the line when some other
> > feature gets added.

> Do you mean to add separate capability bit like:
> DW_SPI_CAP_DUAL_SPI
> DW_SPI_CAP_QUAD_SPI and
> DW_SPI_CAP_OCTAL_SPI ?

Either that or some rolled together capability with an at least somewhat
descriptive name.

--jZMkXTlYS07CDysu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLqsvIACgkQJNaLcl1U
h9DprQf/XGCUL1mxeHLklmE3hgniURrGWqNZYSIf6026+k1AkgHvDbsJr3quML+K
s+H33prL2d4toIr5ZhZJeA0jll+G2v4WAp7hCCsRGBMhb2tY19Edgm7zZphukyPG
P53vdY41sOL1WFjhQCXmV+vSCs2Qg6bUQJlHo9+VKySbw0xIcllzJg9ntdWiI+qA
WYUMInBgHwzRO0JP48FKyL9/5fMTdDLFPTKgqcjrRySUb3tqjQgFWan+BvxppV6N
9smJiCSytcYfGQe7W5Ez0VjLmchdWA+p46NzDbzqluw+TnQDkFWYG3cTtkPOEJ6d
tdHO5maeeA3V83N5WlLrwiurXMudow==
=8Pn4
-----END PGP SIGNATURE-----

--jZMkXTlYS07CDysu--