Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9f47ed0f-99cc-a237-f09b-45291feffcd3@amd.com>
Date:   Wed, 3 Aug 2022 13:21:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v1.1 1/2] x86/sev: Use per-CPU PSC structure in prep for
 unaccepted memory support
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Michael Roth <michael.roth@amd.com>,
        Joerg Roedel <jroedel@suse.de>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
References: <1b50311c-448b-96aa-1d96-f4bfed409c1f@amd.com>
 <cover.1659550264.git.thomas.lendacky@amd.com>
 <2a2adc3570ae9c24d03fff877c4fe79ed43605e0.1659550264.git.thomas.lendacky@amd.com>
 <d5902382-70f4-be07-99f6-80d17cdfdcaa@intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <d5902382-70f4-be07-99f6-80d17cdfdcaa@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nk9NZ2RBRjZmdExwU004ZlM1TENQcDN4NzZsWTFCSWFNbUUwbDF0UUk0a2Ux?=
 =?utf-8?B?VVpBR3Rhb2Nrb3BzQVY5UkpTWmtpZGwyaWNZRkx2TEhUc3J0RjFNakZwYkdV?=
 =?utf-8?B?YllnSGtjYlc4TXdKcUo4djE2eDE0T1VpM01TWUVIYTVEd1l3N2VRRzBud3dI?=
 =?utf-8?B?MlZMZEFLbWtELy96ZzBweGpZWnlqTmhMbWZoZDFyclpGZjd5L0ZKMk1VVGJK?=
 =?utf-8?B?NGRJOWNNRDFXK2tCUC83aWJGSEZ0SVgzanRtbkZJTVZXVzJQMHlCZTc4OUlw?=
 =?utf-8?B?Qngyb2l3cWpLazdROUdzMU1TQ0hrREt3S1BPOGRzVUdRN01zZVdjczJLNm1B?=
 =?utf-8?B?UWlOYlZzUzdELzFOTkd0MHgrTytQRzQ2UUpsNlJZR3FTK3NaUlRIRnl5L3B2?=
 =?utf-8?B?eGdhMGtPZkFFVjE5K3o0bE0yT3lKU3VUZlFRVGd3WXlZdU9mOXFOVE1LSnZo?=
 =?utf-8?B?V1NLU013UmM1ak5wRHdCY0pETFZkS3NEREdqZ3lmTmF4UjJtOWZLNTZkUTFM?=
 =?utf-8?B?aFo5VFBNUi9OaEM0amk0MERtNXJHbE93WS93bmY4TkExVmpiZVl6K2p2b2RV?=
 =?utf-8?B?aSsrd2lmQWlWMW1wUWJveXEvQVV0eDZ4WFJxTnA1dUdoK2ZPTkFoYnQ1OU1s?=
 =?utf-8?B?NUFUU2RBTTNkc2hOeGdmbWtjU1JSRHJSanRlNHV2cHcrOTVxc29OTTNyTWRF?=
 =?utf-8?B?eWNGQkhpREtmaGJ4ZFd5SE5pRXJVenBWYThxdGMrN3pZbTE4SnFHNFI0ODR6?=
 =?utf-8?B?dGIyNmlKeU0yNzRIS2Z3d20vNitKTW5zbVBhUW03RFZsV0NpM3hmTCt4Tmln?=
 =?utf-8?B?VWFFZ29EeG9WU1ZObXM5Wk93OWd4TG80SnhaRVBtYm5QVDR3S3ZmYWdTZUJh?=
 =?utf-8?B?bld4eXFoRmJzZ0hicTdab044UEduSDN1SGo3U2J3bE1hZmFWS09rSE5hUWZv?=
 =?utf-8?B?UnIxN05HMlBxTmI1WFIvRmdZR1BEblFNUEZ4dU5lRDZaQlN2SHM3WVNFVjMy?=
 =?utf-8?B?VTA2SUN5RS93YXFnZ0VxNTNrUjhUa2lBNVFPNDRrWnFQaDVtaHl2Nkoyc2NO?=
 =?utf-8?B?cEk0bnVnRVFXK2RSWUJXL1NOakNON0F6QUgzR240SWQwbjFNR0E0c0J0M3U3?=
 =?utf-8?B?YzZCRFJqQ25CYlVyK3VMTGZOR0N2YmVML201UFZzZUllWkMwbjFFTzVjZ2VQ?=
 =?utf-8?B?cDJ6eHEyU1hITW1rSWEyb3hGeXpUcGJVdXFUWjR4SlVtWVJZRU5SQkRadS9J?=
 =?utf-8?B?MFZwRW1qU1pIZzhWQWxwM0VDOWlLdkp2Y3BBbUI3eXR4c0hLdmFQNFpHeDZM?=
 =?utf-8?B?ZVJVTEJjQk9VSVpMdGFRU05XWnlJMUZqZWpaTy9YbnN3NGZwenFJN01lUVVN?=
 =?utf-8?B?ZThQaXdiV3huQWtuMFZ5U1hkc3NqNEMvZTdhVWhzMUsweWdJTDI3a3hheGtV?=
 =?utf-8?B?VGErM2gxZWk2Z1BOemJ4cFE0UzBDdU1EK1BlQUZxcjJ0anRLQWk1QVhoN2E0?=
 =?utf-8?B?MzV3aHRyeXBJa2pDR2RXRTQzOUl0bmxLRTQrTU1NMlNtbmQvbFRBTkZRQ3Vq?=
 =?utf-8?B?U0RUbXVrL0lqeWFCdHRzNGxNYlgvUG9iRnFlWll3Ui9leldFeVhXNlpFZ0hz?=
 =?utf-8?B?WVU0d2FGNW9ob1ZJWjZSQ0dYdC9VT2crc2VrZzczR2VlYjJnVXd1VkhzSDlU?=
 =?utf-8?B?NVcxSStVVkRzVWEyRlpGcG95elh4NlZWS0h4MXlkLzJEdzZVMHFRV2RMN0dB?=
 =?utf-8?B?RjFmOHd6VXVGaEJUTFk1a2wxMkRFRnJNOWZxU25FcitTV1JMTGcza0FpeDZ4?=
 =?utf-8?B?aHp6OGVDYXhqdzFyMTVLRVZpRDJjcUJVU2IzVWpwYStGdTY4SjFRaktiNnB6?=
 =?utf-8?B?eUJCdmV0RGZsdUtoYjRHRVQyREN3STAxN1Y0Wkk3Z1Bpd0hyYjFReDBBbnJk?=
 =?utf-8?B?VmpSdkpOUXd1blpDWUM1b0dheUtEUUFjZS8vSkVBakpJbC9hM2dwRVRvTEpn?=
 =?utf-8?B?TDd6aUN3dEVPNU04SFNqUGhxSjZrenBZUnIxV2JkdjY4MVo4TER2dkt3T2Rz?=
 =?utf-8?B?OU1Kbk5jN282ZVhENkJzTUN3WEJ1OTduK1ZtMll0M1FCSm0rVm82RXBJdFVx?=
 =?utf-8?Q?IxI9dhvZZ1q07CH3tC8i7NI85?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6568ef42-e1d4-400d-dcf6-08da757d0228
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 18:21:39.5034
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AEMJ2TCz51K9fJqXeZh4kDEvSSP/yf2lgN23Sh5Lkw2F1/9HfWUninpZtEhP3sZUg31xYhoAnqqsycmKl4J1Qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3430
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/3/22 13:17, Dave Hansen wrote:
> On 8/3/22 11:11, Tom Lendacky wrote:
>> +	/*
>> +	 * Use the MSR protocol when either:
>> +	 *   - executing in an NMI to avoid any possibility of a deadlock
>> +	 *   - per-CPU GHCBs are not yet registered, since __vmgexit_psc()
>> +	 *     uses the per-CPU GHCB.
>> +	 */
>> +	if (in_nmi() || !ghcb_percpu_ready)
>> +		return early_set_pages_state(__pa(vaddr), npages, op);
>> +
>> +	spin_lock_irqsave(&psc_desc_lock, flags);
> 
> Would it be simpler to just do a spin_trylock_irqsave()?  You fall back
> to early_set_pages_state() whenever you can't acquire the lock.

I was looking at that and can definitely go that route if this approach is 
preferred.

Thanks,
Tom

> 
> That avoids even having to know what the situations are where you
> _might_ recurse.  If it recurses, the trylock will just naturally fail.
>   You simply can't have bugs where the "(in_nmi() || !ghcb_percpu_ready)"
> conditional was wrong.