Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a9d666ae-0aa4-d79e-aac2-02573577b530@oracle.com>
Date:   Wed, 3 Aug 2022 12:37:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] sched/fair: no sync wakeup from interrupt context
Content-Language: en-US
To:     Ingo Molnar <mingo@kernel.org>
Cc:     K Prateek Nayak <kprateek.nayak@amd.com>, peterz@infradead.org,
        vincent.guittot@linaro.org, mgorman@suse.de,
        tim.c.chen@linux.intel.com, 21cnbao@gmail.com,
        dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
        tglx@linutronix.de
References: <20220711224704.1672831-1-libo.chen@oracle.com>
 <c50bdbfe-02ce-c1bc-c761-c95f8e216ca0@amd.com> <YufUj4klPKmKNj26@gmail.com>
 <82620137-5aa5-6cf1-f7aa-6a298e2f7856@oracle.com>
 <Yuo9Y4KvQQvvLC/r@gmail.com>
From:   Libo Chen <libo.chen@oracle.com>
In-Reply-To: <Yuo9Y4KvQQvvLC/r@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1BXRytDdExtVmY1clhpUExKSmgwYnJUR1NKUXR6RHJndm9pcm9ubjlmanJq?=
 =?utf-8?B?ald2K0JkRmJUTlJ2VjQ3QlVMOEJmZzBQVUxnbTB0TzQ5S09TYk9jUU41aXFK?=
 =?utf-8?B?OEtxYnhldlRFdllZRWNFbDNCTXNKVklTdzdNaWFvaFI4RCtVV0RYRFFyZEU2?=
 =?utf-8?B?UVFaN0lUZTFCZVpiY3pTa0ZDV0RiMTMvdStFUHlIMzRQR1RDR3dmemhPc1NU?=
 =?utf-8?B?aDNXNlArYWtzM1BZVVBVN25yNGFmbW4xRWY2YnprUXNad3JrN0pobXpBRHkw?=
 =?utf-8?B?M01obXVsM2JiQitsUTlTY1h4R1pwVzY1bVYzeDhKWW80Tk4rNVkvNE4rYlBi?=
 =?utf-8?B?NFR1Ly9YbVRlMnByYzV3dmdzTmVUUlc2RUZnMENYQkhHa0UydExBbnplS0t5?=
 =?utf-8?B?ZTQvR2JjVlZ6THd6Zzl6ODV6dWM1aG5FT2h3UnEydXBTaVpWNzFveXBNSG9i?=
 =?utf-8?B?d1E2UG5tZVlSVXZSbzE3bHh2a1EzdzJVbmZxRGxBVHJhc1hYLzhRcXg0NSta?=
 =?utf-8?B?K1NjQUoxemtTRDRVc21XelJiTi9CbDRZNFE4bGZuZEFoVnlLbVcyZENKeVJt?=
 =?utf-8?B?WUFXUjVuakN6SDQ1ZnlCZEVpSDVRc0laeTJoL0JrcTlickxSbVN2V0tTYUw5?=
 =?utf-8?B?YkJmcE5hdGhvWnM3RTV3MnpWY1ZvUTN0ZGZhQUZJSzFsakpWQWlDZ1QzNE9l?=
 =?utf-8?B?Z1hUejF4NS9TNzlISkxEdndNRGhXSXpPUm9mUy9wTnBrb1Nub0dCaXdpeTB6?=
 =?utf-8?B?dlhGdzY0L2N4dGQyWkhLRG53MGQ2N3g1NzEzNjZEMnkvNzZQWWY3a3Q3ejNM?=
 =?utf-8?B?bGRNaytPYmJFMUhXaHlOajFxdERvOG5rVlRBRTk2V2gybXFWRWJFZHF6cmZ2?=
 =?utf-8?B?cFZIdEM5U1JVYThZS2xMUzhkbUc3M1FFeWNhK2k4d2tPM0NTYzE5WFFXcHlv?=
 =?utf-8?B?MXU3N2xRMWFFdnkzd3Y0dEpkNTBoemZXR2dZK2lsZTVBTy9WeTA2U2FWVmpM?=
 =?utf-8?B?bnE4OC9ocnBVZ2N2VDQrd0RwZ1pLT1lqRytGL0hOa25PTnJNRWxjQlkwRFMy?=
 =?utf-8?B?dkxvT0M3TU9TSURmWVBOSTNZZ2ZwNTdReXREU3o1bVAwOE9JS2YwWUdVa0dX?=
 =?utf-8?B?NU4zUG1RSDhaRnJYTk5XS0w3SkFVaWplMVVpNlBqOG1BYmxVbDB2REVDTy9h?=
 =?utf-8?B?aGVtVjhGQ0lBdG9vVlowaGJNR2ZFL3ZHaXJFNk0zeUNncjNCUUNPbVliclAr?=
 =?utf-8?B?U0lUMGpHendCYWd1M1VyOEl2aDdid1Frb29aUUVXWUdBV2o0NUJMbGd1aDRT?=
 =?utf-8?B?ZVZGUmpHZzRGcUhIb2t2UVdQb3loR2NMLzB2SXJoTFIxeElJVmlJOGg0WlNT?=
 =?utf-8?B?TWQ5R2hST1dyZGJ3ZEhZMnQ5ZnA5bEZpczN0VWJnbmpxOU0rNG9TS2lIaEpm?=
 =?utf-8?B?QU1jYTdNUnIxTFdPVm03Z2NTL204Yk90aVVLK3hESWNqVEZXdmF5Kzg2SzZj?=
 =?utf-8?B?Uko0YXBRMEdBNHBRdEZEb2JjSFBvaXRVWjYyc0RScVVZRXZHT1ZYbm1FdWZK?=
 =?utf-8?B?MVdkT05EaUJxTTg1VklXR0RXVHJ4eDRJTTlyd0tvK01QT2NYQUhILzA3VGRp?=
 =?utf-8?B?K2dyeWUvWjZ0clJyNzZvcGlSR0VReUZGZE5YYTJxR3EwVUZKN054cS9hWHVP?=
 =?utf-8?B?ZnRZNThtd3B5eGsvT1laQnNYK0VTQjRkY1dENUUyaTlJcTNGVm1lblMwNFVz?=
 =?utf-8?B?c1crSGtYdW96UlhXUVp6QlBWMXNERmljVzNwVkFHblNneTAvTzlESVF6SlFQ?=
 =?utf-8?B?dUNyYlVQeCtzVUMxc3dad1ZkQ3VWWGVUc2I1VGovb0JtNFNBaVpZcGtpRENp?=
 =?utf-8?B?S2FMRVN3d2RhdVBXZ0dEN0JPS0tBdkRSUzBTMWtUTk9PY21LV3NIa3AvSkRn?=
 =?utf-8?B?WTlnd0xIVDNNUGlmcU5wb05yYjdIVG9CNURZUTNKSWZ1V1MrL0JGTWFqK0FE?=
 =?utf-8?B?Mm5mMTZjaVBTWFl4Nm91amQwcjlNTCtTMXkrcnRLMDVKTytrNTdWUlNHTzlF?=
 =?utf-8?B?anhBemRXQ3JlOEJ6djlkZ3ZwVWJqbmdMdmZGUUpDWTBMVnVjajNZZlZpejdv?=
 =?utf-8?B?UFVtdmt2TGVia0dFTEdGelVaWW14RVRGUDYyaTY2ZEgxUHlqQ2VWL1lEU0F5?=
 =?utf-8?B?bWc9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eaa7d054-12d2-4c4c-4aae-08da7587adf5
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 19:38:02.8102
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9mzVG16lmMavYJbawniR8CxVwtlYhNS5397k7h1GLIU11m0Wa+hgXZND2wg21vhOlkNCWlTJGSTVP8Td3uZrCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5179
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-03_06,2022-08-02_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 suspectscore=0
 adultscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2208030082
X-Proofpoint-GUID: _d2-MiOHUQlO2C8q45y71qIXDwMUKFJj
X-Proofpoint-ORIG-GUID: _d2-MiOHUQlO2C8q45y71qIXDwMUKFJj
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/3/22 02:18, Ingo Molnar wrote:
> * Libo Chen <libo.chen@oracle.com> wrote:
>
>>
>> On 8/1/22 06:26, Ingo Molnar wrote:
>>> * K Prateek Nayak <kprateek.nayak@amd.com> wrote:
>>>
>>>> Hello Libo and Peter,
>>>>
>>>> tl;dr
>>>>
>>>> - We observed a major regression with tbench when testing the latest tip
>>>>     sched/core at:
>>>>     commit 14b3f2d9ee8d "sched/fair: Disallow sync wakeup from interrupt context"
>>>>     Reason for the regression are the fewer affine wakeups that leaves the
>>>>     client farther away from the data it needs to consume next primed in the
>>>>     waker's LLC.
>>>>     Such regressions can be expected from tasks that use sockets to communicate
>>>>     significant amount of data especially on system with multiple LLCs.
>>>>
>>>> - Other benchmarks have a comparable behavior to the tip at previous commit
>>>>     commit : 91caa5ae2424 "sched/core: Fix the bug that task won't enqueue
>>>>     into core tree when update cookie"
>>>>
>>>> I'll leave more details below.
>>> Mel Gorman also warned about this negative side-effect in:
>>>
>>>      Subject: Re: [PATCH] sched/fair: no sync wakeup from interrupt context
>>>      Date: Fri, 15 Jul 2022 11:07:38 +0100
>>>      Message-ID: <20220715100738.GD3493@suse.de>
>>>
>>>      https://urldefense.com/v3/__https://lore.kernel.org/all/20220715100738.GD3493@suse.de/__;!!ACWV5N9M2RV99hQ!PQsIeuK0UwII-A0xS-B3plepNniNeyw14OJowT1cYL-tnuN99MkWfg9C8P60tVFFrnxj0NEanUmEkA$
>> ?? Mel was talking about a completely different thing, I brought up a
>> different patch that I wanted to revert and Mel thought it would hurt other
>> workloads which don't benefit from pulling but
>> as you can see, tbench somehow benefits from it, at least according to one
>> metric from one workload.
> Yeah - but nevertheless the discussion with Mel was open-ended AFAICS, and
> the 'major tbench regression' report by K Prateek Nayak above still stands
> and needs to be investigated/understood, right?
Oh yes, I have no issue with holding the patch back until the regression 
is fully understood. I was just a little confused on your reference to 
Mel's comments. Anyway, I will post my investigation soon.


Libo
> Thanks,
>
> 	Ingo