Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Patel, Utkarsh H" <utkarsh.h.patel@intel.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "Mani, Rajmohan" <rajmohan.mani@intel.com>
Subject: RE: [PATCH] usb: typec: intel_pmc_mux: Add new ACPI ID for Meteor
 Lake IOM device
Thread-Topic: [PATCH] usb: typec: intel_pmc_mux: Add new ACPI ID for Meteor
 Lake IOM device
Thread-Index: AQHYouJz7thRnPvu+UeuQ1FvnIN3Dq2bVpcAgAKK6cA=
Date:   Wed, 3 Aug 2022 23:51:56 +0000
Message-ID: <MWHPR11MB00484EFF0A94ABEFC0885F3EA99C9@MWHPR11MB0048.namprd11.prod.outlook.com>
References: <20220729003033.771761-1-utkarsh.h.patel@intel.com>
 <YujndMdpS+4L0AiL@kuha.fi.intel.com>
In-Reply-To: <YujndMdpS+4L0AiL@kuha.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fIrTol1IwjyVUXAKYFly5xtKNTxtXzcYSEQNN80GOW2wHaxxD67j1cQ/SL1p?=
 =?us-ascii?Q?5f2vKReMgqCupaD9URHLlh/GV83lPmv7bBesPq7geXrH59oZoHE+zbq0hx/j?=
 =?us-ascii?Q?nT7JRukmadrXrSqL14Qck+Il7y62Pe7LsBBS5jWsdlR0r/4s9E1I0jbNKCMZ?=
 =?us-ascii?Q?NQ3xxDz0e8b9Z/TIWf6lEytpQx1RDmPObh0P3nLIFww2RpHE9yUNH30u8Uo5?=
 =?us-ascii?Q?uFYfHfbQq3ZuDWKoxr6UJmz2cAGPbbmzYDMDjFcgD8pxX5OICxpiliS+VNrU?=
 =?us-ascii?Q?3Oh/Beq9aqSEdWgdrsHOBUa73TvtfpX/vQCroiY2RF7bbWOTBlVcKMPUI4Wa?=
 =?us-ascii?Q?QkeqwRpbQxiLlyYYR/cBSgJKlrRKYao8vjTNC0VFLVndMJ5cY1Q1EcXup223?=
 =?us-ascii?Q?TKEvXxPUb6mgTzJ8ffXbKdM/TT3rUryn60bIsHY0QzJ96fo7DQ8AfmHRusbv?=
 =?us-ascii?Q?9WeuVNa2GcrDSMkQ8Y3DOXVp1Tct6WYWmQkohzFr3b2WTVtK33aI/e/uPFs1?=
 =?us-ascii?Q?lBCgGyegLIJrcqM/0MfoxjpzBvdWmypvUEzYU41z+KZ2MO8sbknU734r34Nx?=
 =?us-ascii?Q?FON8GrZCjaheLzDRKhPgPgzticFveBaFhQuKzUHFmOTUyNEPtfT37PZ8Otr/?=
 =?us-ascii?Q?qHCk/iGFS4wCZxu6wmM0lrGvpXDAGL9YJNvh4BaGcowWTVVwfxnFmwwaWWVc?=
 =?us-ascii?Q?uvSSpXSkDxGA5KvHvVcktq7qtNtQB90nGL6bgq2AyjmxeJvW0+wHBwMolStd?=
 =?us-ascii?Q?mv/rHcyR5aCR2+ItlzieUcC25h3edczOLDMnlcxmqmKBkcba1GRXfODXEQYm?=
 =?us-ascii?Q?h2rSd4MIdYbv0aEeOHeKIOl0FMPf2M6PZPTv4cyjopYnJkJU5bgm1yknJkoP?=
 =?us-ascii?Q?MoHYRwKfkjcNtS7OLhXptiRtEFhJt1AzWCI21bWu402TauyVKR2mu6lfkN5O?=
 =?us-ascii?Q?S4ASkLeFdko8o3bgHvYxeKTdx8nlq3S/B+ndqp/RSpkIXkfsE7dcuorvDEt3?=
 =?us-ascii?Q?zlCw7YyhDtYztDdPHc3nhkEdoODFzZjDBhX0slJNSFAJEyab6Cws9h1w7bhu?=
 =?us-ascii?Q?1bQlclL2tNMtrYnV3iZRrN7Vgmtlh/Udl44Ll5/Hi0l9R06gGXf1GE2/QZcF?=
 =?us-ascii?Q?LlfUr7hAuZ6PS4OAHHKfm39Bq/5ns3AtmCKvVTvLULKRRgQzoNb6qxPALrla?=
 =?us-ascii?Q?JNZqEmxzZSsNkzvj0rftvIYRTHmrelQIioAvBQR9oQHYQdUi/L3tbVbEnhtt?=
 =?us-ascii?Q?jsGmsDwoCHCeAQQFw7Aw3nkmX+n/dKmJwh9KSBHMmPdQklRsPJ7HUYDXrSqg?=
 =?us-ascii?Q?OgRArUyz8KT6d6dh/nQ2jXcH+5SmlAsnXhpr65m9OYo2SMA9j33jFrsQ7jl9?=
 =?us-ascii?Q?H0WNew7+wmLf4yryVrok7pwpQjOiKOfEElvLYQYbzYpZ42jbE37yL36EvwHf?=
 =?us-ascii?Q?SJvWZyKaWnfW7V+ivSqatCYdF4ElMi2fPSrc7VB0sOw5/WNb5cHdjFyws2JC?=
 =?us-ascii?Q?KvhIWLZobT1IrxDXL6U0PFutdE5M9jaazr7phWIW0o2DiMxoKaleV8xakJRV?=
 =?us-ascii?Q?FImy9o7N5U/97qyCSekKPXsSLFfpBC6J25PMhgD/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0048.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14083289-0b6b-4993-6f7a-08da75ab265c
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2022 23:51:56.9483
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c8VnsIKVvDw9ex9gYy4mibK/tk+PoarM/3WOhsCY9Mt8vkWrUABKmhifngyO6RrGx15GRrqphDzMy3ipekRAuq+1+mtrp8CAX2gDv9ndlMM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6217
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Heikki,

Thank you for the review and feedback.=20

> >  drivers/usb/typec/mux/intel_pmc_mux.c | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c
> > b/drivers/usb/typec/mux/intel_pmc_mux.c
> > index 47b733f78fb0..a8e273fe204a 100644
> > --- a/drivers/usb/typec/mux/intel_pmc_mux.c
> > +++ b/drivers/usb/typec/mux/intel_pmc_mux.c
> > @@ -571,9 +571,11 @@ static int pmc_usb_register_port(struct pmc_usb
> > *pmc, int index,
> >
> >  static int is_memory(struct acpi_resource *res, void *data)  {
> > -	struct resource r;
> > +	struct resource_win win =3D {};
> > +	struct resource *r =3D &win.res;
> >
> > -	return !acpi_dev_resource_memory(res, &r);
> > +	return !(acpi_dev_resource_memory(res, r) ||
> > +		 acpi_dev_resource_address_space(res, &win));
> >  }
>=20
> I realised that now that is_memory() function is basically just a copy of=
 the
> is_memory() function that's in drivers/acpi/resources.c, so I think we ne=
ed to
> handle this a bit differently. There are a few places in kernel that have=
 that
> same check.
>=20
> One way would be to just export the is_memory() function that's in
> drivers/acpi/resources.c, but since we have already a wrapper function
> acpi_dev_get_dma_resources() for DMA resouces, I think we could have a
> similar wrapper for common memory resources.
>=20
> I'll prepare a patch(s) where I'll propose a new wrapper function
> acpi_dev_get_memory_resources() that will take care of the is_memory()
> check, and then convert the users (including this driver). After that, th=
is patch
> only needs to add the ID.

I will wait for your changes then.=20

Sincerely,
Utkarsh Patel.=20