Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <814dee5d3aadd38c3370eaaf438ba7eee9bf9d2b.1659399696.git-series.apopple@nvidia.com>
 <CA+CK2bCxuSs8aDre7B7cr=B1FpD+d1kJL_1uCU1qtNKErpUSSQ@mail.gmail.com>
User-agent: mu4e 1.6.9; emacs 27.1
From:   Alistair Popple <apopple@nvidia.com>
To:     Pasha Tatashin <pasha.tatashin@soleen.com>
Cc:     linux-mm <linux-mm@kvack.org>, jgg@nvidia.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Minchan Kim <minchan@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        John Hubbard <jhubbard@nvidia.com>,
        David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v2] mm/gup.c: Simplify and fix
 check_and_migrate_movable_pages() return codes
Date:   Thu, 04 Aug 2022 10:01:35 +1000
In-reply-to: <CA+CK2bCxuSs8aDre7B7cr=B1FpD+d1kJL_1uCU1qtNKErpUSSQ@mail.gmail.com>
Message-ID: <87h72s7toh.fsf@nvdebian.thelocal>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O8dedp+Mm7NwuXYlqjH9+AXrOgpxoL8VkS4elw3KFDNAcpCeeDMkuyFjQk16?=
 =?us-ascii?Q?ff6Tjn2r/UZfExBNZh9Cj0dgcXwX6dF2ONHysuMtdSOC0uj6yyBieVm8pjvg?=
 =?us-ascii?Q?a3jNDp0PzMZM0G4QNiw1vfOgKwf98oPaLlt2YxEuO50mmpX8yvAthlTQfyTR?=
 =?us-ascii?Q?+4sskiy9MVo3HhBM2VrzjNCDlp6KDI9P8vC2TyuIjEIYGKsNi6Nt//AWrZu/?=
 =?us-ascii?Q?5gyPGikgLIwNUlnVZ2C1M2E15QZm5AqFNi5P8G6DBOJU1pp7SwpQhdpeDYZa?=
 =?us-ascii?Q?4C7AyU/PhLyeg3DcTeMxNbE9BjXMB5xxpG0ZLzhJnRPtZQONHKfN0u96xWE0?=
 =?us-ascii?Q?eoV4ZBDNhyGLD2xFsSXKFQ7NwFykt7dhiCE1aFLTsruSt/yLStej135AaD+b?=
 =?us-ascii?Q?IResDZLewg5d971IJPDmLC93RmNOQ3vLhNhUd3wF2XC6aM/3R+gVR/mRi8Nu?=
 =?us-ascii?Q?Z2ZJ+lX86slTrAqMvWgQQ2jWMRyxbJgIBwv5KLqmsOTRm9/ItEVr0i8KnJvI?=
 =?us-ascii?Q?08nKjPDM/egNYtt1f+UwenGkp+Ht/mRxkAxFNtXDEelbxhWb+9bJAB187/2G?=
 =?us-ascii?Q?K6ShDs0vCvHgYrPHY+Xy9+J555vRc/Yfk9ieZ3NUf7/LOH9WXJYq7gsORe8r?=
 =?us-ascii?Q?BTqkcyzcmou8zszgpeaWGVI/feUvd9INZuhD7lzzL1D8awMV3JYgkF71yByC?=
 =?us-ascii?Q?jnM2wtTiVrwaErbloogqYOKHdHgGplBRitiQ8+SGzRT7V1zqXDrT5RZakYR5?=
 =?us-ascii?Q?txPYqkbwSAkuczNsOWuKzMc2I2A8t6fI2fSKKK45Ce+KKEiJuLi/DBiau6iH?=
 =?us-ascii?Q?359WjUqCkv5HceK5aIHWtFtflRRJBavbnv9cGYFfz7oCrrPKTIGuKOzqSoO3?=
 =?us-ascii?Q?I7HtcPYzP5vNsRgcB8uKJCHnYc1fVlxJhxGgBFrUFRW5hfTZJ02J1x1t6z+7?=
 =?us-ascii?Q?71uSHITtpwh+hQD6GAun8hL8r3qJD7UyxUS+g+fsRjRMD8yNXDECf4SaUI2h?=
 =?us-ascii?Q?HxH3B+MasLimB/UwWQWBf2tns2X68j9ZQwz4018lPTt0jkVhq2aZgaqa5Ltv?=
 =?us-ascii?Q?VuApVhlN7rUekClH+lmovSDwgYFx10ukPxJUDSaCHNtXpzqFvcxBfJBC87e/?=
 =?us-ascii?Q?WoT9gxn+wHzx0taNfm0AsxOaD6B6gqpj9oNQDi7zNC4VrPTCaQmCXZdUJUgb?=
 =?us-ascii?Q?bb/debE8VACa9z3RjYlkOxUq2Z25x6ZjKvCU1aFPlio0rAD8ALEzv2GkimcR?=
 =?us-ascii?Q?DJBE3wLHChXL2uVizSGtonKNZXwUbHEGLn9wu3TA+9kYyMbWxCKlZK3qx0ss?=
 =?us-ascii?Q?lJ0l4lMOXosb/hy+S/k1PO8QWsabYDhgRmHPwdE+NXCCwuV6ReHpwm6HlSs3?=
 =?us-ascii?Q?WACdddRHW2tLFyrcjlCRCAywG3G8QJJPEzC95pqsJfmJ/lOTv60Ebgw1HSJD?=
 =?us-ascii?Q?cYiH2PkrlRRFGI0g7Q2DQOeIx130FRh01UrmOK+gDUW3xAWksYS8NE26bUmY?=
 =?us-ascii?Q?Grb8OSkgybTiwrU6Wwf7IVW8pi5t2xZfWeM/Q/r7f6nZaS94EqxfQwKCLAOu?=
 =?us-ascii?Q?5Q2zWbdTkWkYr0g0WOvf8aeegk+TSgoF1g4E69NW?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a175061b-2a66-4e28-a568-08da75ae1177
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2022 00:12:50.5721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HzK9cH2fHgosr2oQKDa02pMg8ct2O3T1EH/wskOd0b2YXmfUEnQQE2rmcufghTdkGU2tJDrIts82TofPxoL1/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5351
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Pasha Tatashin <pasha.tatashin@soleen.com> writes:

> On Mon, Aug 1, 2022 at 8:32 PM Alistair Popple <apopple@nvidia.com> wrote:
>>
>> When pinning pages with FOLL_LONGTERM check_and_migrate_movable_pages()
>> is called to migrate pages out of zones which should not contain any
>> longterm pinned pages.
>>
>> When migration succeeds all pages will have been unpinned so pinning
>> needs to be retried. This is indicated by returning zero. When all pages
>> are in the correct zone the number of pinned pages is returned.
>>
>> However migration can also fail, in which case pages are unpinned and
>> -ENOMEM is returned. However if the failure was due to not being unable
>> to isolate a page zero is returned. This leads to indefinite looping in
>> __gup_longterm_locked().
>
> Hi Alistair,
>
> During prohibiting pinning movable zone development, there was a
> discussion where we figured that isolation errors should be transient
> [1]. What isolation errors are you seeing that lead to infinite loop?
> Why do they happen?

Thanks for the pointer Pasha. There were reports of qemu running into
the same zero page problem you reported there, see
https://lore.kernel.org/linux-mm/165490039431.944052.12458624139225785964.stgit@omen/

This doesn't directly fix that problem as we need to allow pinning of
the zero page, but it does prevent the infinite loop. I was going to
re-spin this patch to retry instead of instant failure however reading
that thread it seems the infinite loop is desired behaviour. So will
re-spin this to leave that in-place.

 - Alistair

> Pasha
>
> [1] https://lore.kernel.org/linux-mm/20201218104655.GW32193@dhcp22.suse.cz