Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp47895imn; Wed, 3 Aug 2022 19:05:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR5Ko0Tep+EyM5ci+6va9eElNGKQaULPtosEVWd1I/iB7jLWxkJihwKFtBRWf+G9fgu/pycJ X-Received: by 2002:a17:902:da92:b0:16e:f2ee:b98a with SMTP id j18-20020a170902da9200b0016ef2eeb98amr15622611plx.154.1659578741304; Wed, 03 Aug 2022 19:05:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659578741; cv=none; d=google.com; s=arc-20160816; b=vayQ4f6hizGEDsOiojXuAN4oPxzoIaFwVgNwERxpr9Dit8wJzZbDwnd+2q0BoFkaNu QstNI+uZCx0Cwv4h/CVBN6bRUvNlgpuNlGKsB6bZrsPN7OVilkoflAYKYzTXHXZNTuiF 9UqyZ+ScDWnbQcD4Uvqn+Qt7NsjKliCpo8DebAsO7HNJ0vmB7zyzji2Aesajwd/hCx4d KBCYnezp6wqQ6ZR7bTy1Tw9InsRf0hcyDm/xZipgvV/jBmSvheJiVbnFtcOhxtAIh4Po ztA31Q5ima5T6D7NeSQMPgePuhBw7AmTl5dpxvrmqpeczkOwEklfAptQt3gTqpcNbPct NJXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8Z0t6/4ommGyzXVjO5X51Slqd6i85OpOqeLIU8vInk4=; b=XHaUpa0ondc3DjhaZTtV2R8LN7yckBTR85zj2jKioUw+W+MJ3wr42rsI+tc6Z7qcAk B+smec8LaMSYEJBMhVvKdIxizjiwRsTFlMluoPIfgXH5M5/WwEJjYr3qWgdHQJEpnZw5 K+7QOPLskKtLQHhN+xkARuHBZRqk7XTVP7WjVyRi5/iqY9rT1nQZfA6Tm4oXZlkjOZ+P LTWS2TuRZhXSKOsinXWrdO1H0+zrlVWykIs8BZjGY8nnclKyCBAqOMP0PY+EGK9d6yaz MZMZaghp2kLI9SeuQqEozbzAaWvvypV4Fx1N2/da8sWTXIDhSuLhv1N/R6gcnWm4BHaI tJ2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F4wcugpq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k14-20020a170902760e00b0016bea2a8b16si3354821pll.364.2022.08.03.19.04.39; Wed, 03 Aug 2022 19:05:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F4wcugpq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238848AbiHDA7i (ORCPT + 99 others); Wed, 3 Aug 2022 20:59:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238861AbiHDA7g (ORCPT ); Wed, 3 Aug 2022 20:59:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 440655F9AF; Wed, 3 Aug 2022 17:59:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B839861751; Thu, 4 Aug 2022 00:59:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98755C433C1; Thu, 4 Aug 2022 00:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659574773; bh=c0/kYEt5J2FdFJ1FwCq/4THeVhzcRRwZ4/5qZhcI7OE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F4wcugpqGGlPXXs70am0ZjVTUrZiqaKLeXs3OasZWwFdN1LltdJ4eybaDZ6H0ns5y v6uB4vaqKembrVC3p0SxJHJlHmqCBe/dU50f7AyBp/tWsTyk1HD4O6CQFuOE86dcid G0Nh7kIvy/CPexZ3/IOJF+CQE9+d5L7VFpu9zaqeuuLR8Y/8SKN7+3Fo9SVGrqnfgC tWWzGeEToXMW6Vex1z+NbfJubFno50C/TkJscFAhkDFvjh9xBPcOm8a1TjtrsB3vxT czEg5uT1k7lwXWapU3btmj1gxrU2X4GutaCBtKlp3z9oqXiIdMQfSijMSZ/jNcKmNg yzkbTbJIgOcIA== Date: Thu, 4 Aug 2022 03:59:30 +0300 From: Jarkko Sakkinen To: Matthew Garrett Cc: Evan Green , "Rafael J. Wysocki" , Pavel Machek , LKML , Daniil Lunev , zohar@linux.ibm.com, "James E.J. Bottomley" , linux-integrity@vger.kernel.org, Jonathan Corbet , "Rafael J. Wysocki" , Gwendal Grignou , Linux PM , David Howells , Hao Wu , James Morris , Jason Gunthorpe , Len Brown , Peter Huewe , "Serge E. Hallyn" , axelj , keyrings@vger.kernel.org, "open list:DOCUMENTATION" , linux-security-module@vger.kernel.org Subject: Re: [PATCH 00/10] Encrypted Hibernation Message-ID: References: <20220504232102.469959-1-evgreen@chromium.org> <20220506160807.GA1060@bug> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2022 at 11:36:43AM -0700, Matthew Garrett wrote: > On Mon, Aug 1, 2022 at 3:33 PM Evan Green wrote: > > > One more bump here, as we'd really love to get encrypted hibernation > > to a form upstream would accept if at all possible. We were > > considering landing this in our Chrome OS tree for now, then coming > > back in a couple months with a "we've been baking this ourselves and > > it's going so great, oooh yeah". I'm not sure if upstream would find > > that compelling or not. But in any case, some guidance towards making > > this more upstream friendly would be well appreciated. > > > > One thing I realized in attempting to pick this myself is that the > > trusted key blob format has moved to ASN.1. So I should really move > > the creation ticket to the new ASN.1 format (if I can figure out the > > right OID for that piece), which would allow me to drop a lot of the > > ugly stuff in tpm2_unpack_blob(). Maybe if I get no other comments > > I'll work on that and resend. > > I've been revamping my TPM-backed verified hibernation implementation > based on this work, so I'd definitely be enthusiastic about it being > mergeable. BTW, is it tested with QEMU + swtpm? BR, Jarkko