Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Baolu Lu <baolu.lu@linux.intel.com>
CC:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "Zhangfei Gao" <zhangfei.gao@linaro.org>,
        "Zhu, Tony" <tony.zhu@intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Jean-Philippe Brucker" <jean-philippe@linaro.org>
Subject: RE: [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu
 interface
Thread-Topic: [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu
 interface
Thread-Index: AQHYkC3GvF//WyZOvUaTLdl04LC2Cq2MG8sAgAEavgCAAhH3gIABB5EAgAB+1ACACj08AIAArKqAgAGa2ICAAGNpgIAAdMBw
Date:   Thu, 4 Aug 2022 02:03:46 +0000
Message-ID: <BN9PR11MB52768ECC49F90F37EE3462958C9F9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
 <20220705050710.2887204-5-baolu.lu@linux.intel.com>
 <20220723141118.GD79279@nvidia.com>
 <686b137f-232a-2a78-beb0-e4373bd20959@linux.intel.com>
 <20220725144005.GE3747@nvidia.com>
 <6da27a6b-b580-4ba4-24c8-ebdfb2d9345d@linux.intel.com>
 <20220726135722.GC4438@nvidia.com>
 <806b1437-441b-253b-7f52-ee7a7a9053e9@linux.intel.com>
 <Yukac8X81CP7gDsM@nvidia.com>
 <3eb62531-fa1c-4c78-c1d2-526a3758a033@linux.intel.com>
 <YurGexaP/Q+N02dT@nvidia.com>
In-Reply-To: <YurGexaP/Q+N02dT@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p4YI5dHLbAa/Ub8zoGlyD8FLtxm0K3gTXOIKs+W3zj3iWSk3S1H6g7gssQ3S?=
 =?us-ascii?Q?jfoNUNqiNqL9GF1oARDuFxfOmI1qU3CuUWnbCr2flyyuZD3VTjB0GcM2diVy?=
 =?us-ascii?Q?riobQPcJxL7kE4rkpLDjULZj/NWEuFF5yQR3huOGZMIojnEAA8scC3cMhcck?=
 =?us-ascii?Q?FI7H7+BKmv/U9lv8OCwtJ/dHa9pOw5O5cNSS/RGMxDC/3KxC7k2pU+sn2u6z?=
 =?us-ascii?Q?MX34BAHO1LzJ71lJLeQTAHplgnICW4eDfdJRCImex7RIkaN0Xc8VESIE7kq8?=
 =?us-ascii?Q?cVpXJXlhmLos2SdW8sPr+Jza/xPpDq1b6DD/Rh43r0MSd6Ssr+c/x7b7nVJX?=
 =?us-ascii?Q?fgzvA3HqrItI3beDuMbEpma5vFbmvI26IX7/cRNz8oSlG2d7XLKmUNNzKHYt?=
 =?us-ascii?Q?djayln3gCf/hgWTU/2CboIx8mDMwLDuloQex3kX3FlSj4m3pg9WKxRLOhmVb?=
 =?us-ascii?Q?JMgMQrnsQDWPckyHcNSIlCylfaCqn6eocKd1vnszA31vx19Q2aIZ+qaHB/KW?=
 =?us-ascii?Q?hbXfgWMFNzjK1K9ohkxxrQUZlItmIAUrbnoO2dvQQnH0n/de/doPcadz3qtp?=
 =?us-ascii?Q?GwqZfEs79Tv+EZLAr8ogvMOTs2ppSKsK0g91dbSuHHPoIaDomK6wl3B9e8no?=
 =?us-ascii?Q?yvLtLXT6+4p7txC2Cw7ETgMaXTBprJ62dx5mzZdsKRe6OyElIFdxMbYso6Xg?=
 =?us-ascii?Q?oO02PSntNyClbuaSC3m1S009uGy4lxM0TO6p9QanywP7dp5gUQNcGVNWSJ11?=
 =?us-ascii?Q?rrzA7w8j43cJaPoCFvMAp5Vgw163lOCQXh4KnbJrGc7uGN420w8SXXpVetv0?=
 =?us-ascii?Q?dgI8N/QyVpQsjv2Nvu8JXPZCcaob9PE7hfhF6nZ1gfFfaVh8Dzcb11V/6i0l?=
 =?us-ascii?Q?mvMK1sTRLUggKpBk4jUS6yTJFiepl5etid3H46TSTfVnoldTmyi35LK7uCdv?=
 =?us-ascii?Q?Yb0osudBlr/NciMgCNZGtAqKnHXTX8S2yiwafkqVcFw7zM82YGcDLFADXD0f?=
 =?us-ascii?Q?nWp381fu/wRotVKULzRFzuNNSD8opLLJPWTE/n7wWiRYPLWR6VG35k1TLdEl?=
 =?us-ascii?Q?XeN2KPke2y2uHeZad79DaEbWe00rROEJ1S2FXqhb++psYWA0NL5AuLKXzfJR?=
 =?us-ascii?Q?BJ5pLToKCZsDjhk1JpdSW60fIgsVhGXG72ZIie4fZTVNjNkMdggvjjJ00iNo?=
 =?us-ascii?Q?wBD1A/psDwkRc/sSEhy/QvpQZNo95O0ihHhE3933apC3Qf+qfQ04ODAgXq0X?=
 =?us-ascii?Q?GLznPGXe8NpRYwVVrhwaE4VLTkChGJUrpIcEhfIDgKc77LJRGhA3n9PwsSmV?=
 =?us-ascii?Q?KAtseugOWmbalxep+gxTx1YHfJ3BWrnn4I3i5qDhuq9OaSnct1jGYXDQpWq6?=
 =?us-ascii?Q?qe5gOXrvrXJ4nPPm7Ka0RJGawnhI9c8NhBSvNsujOsT6fbAXEFbgzdou3SWb?=
 =?us-ascii?Q?4m0Gh0lQi+Inzybhz/1SCSZQNKw3QBzFsYGjVUfqZ6sQCVR5IoPGJQDAPP89?=
 =?us-ascii?Q?L2fno4fo1UQ8WoC/kB9GqOWkn9ZYNeuNJYfLa0PrVmNb5kz+aOrC2NZ9fIv0?=
 =?us-ascii?Q?ZBV7W+1nSPRiNGGVp/nb1U3L15w7iy+mGNGmi7Rt?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49080e61-7004-4a78-747c-08da75bd90e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2022 02:03:46.6350
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JC+1SWrpwWjXyefdLOcZQsILtbJSLYcXVv43Z+ItILkRLQIGk9IxoUG3yUPXUIt7/jIi9WdwbQ33pKLxqi1hqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6356
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Thursday, August 4, 2022 3:03 AM
>=20
> On Wed, Aug 03, 2022 at 09:07:35PM +0800, Baolu Lu wrote:
> > +/**
> > + * iommu_device_claim_pasid_owner() - Set ownership of a pasid on
> device
> > + * @dev: the device.
> > + * @pasid: the pasid of the device.
> > + * @owner: caller specified pointer. Used for exclusive ownership.
> > + *
> > + * Return 0 if it is allowed, otherwise an error.
> > + */
> > +int iommu_device_claim_pasid_owner(struct device *dev, ioasid_t pasid,
> void
> > *owner)
>=20
> I don't see a use case for a special "pasid owner"
>=20
> PASID is no different from normal DMA. If the calling driver already
> has the proper ownership of the device/group then it is fine for that
> driver to use any kind of IOMMU attachment, RID, PASID, whatever. It
> doesn't matter *how* the attachment is made.
>=20

and pasid already has an alloc/free interface which already implies
an ownership model.