Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220804025457.213979-1-chenhuacai@loongson.cn>
In-Reply-To: <20220804025457.213979-1-chenhuacai@loongson.cn>
From:   Huacai Chen <chenhuacai@gmail.com>
Date:   Thu, 4 Aug 2022 11:19:41 +0800
Message-ID: <CAAhV-H7J=mofWtm99pSzvcByLxf3-in1BkopBFSYh1hF0_dQ6w@mail.gmail.com>
Subject: Re: [PATCH] irqchip/loongson-eiointc: Fix a build warning
To:     Huacai Chen <chenhuacai@loongson.cn>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>, loongarch@lists.linux.dev,
        LKML <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, Marc,

Other build warnings reported by lkp due to the missing CONFIG_ACPI in
randconfig. So they will be fixed by adjusting arch/loongarch/Kconfig
and going through loongarch tree. Thanks.

Huacai

On Thu, Aug 4, 2022 at 10:54 AM Huacai Chen <chenhuacai@loongson.cn> wrote:
>
> Make acpi_get_vec_parent() be a static function, to avoid:
> drivers/irqchip/irq-loongson-eiointc.c:289:20: warning: no previous prototype for 'acpi_get_vec_parent'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
>  drivers/irqchip/irq-loongson-eiointc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c
> index 317467857478..bffb7b3128e8 100644
> --- a/drivers/irqchip/irq-loongson-eiointc.c
> +++ b/drivers/irqchip/irq-loongson-eiointc.c
> @@ -290,7 +290,7 @@ static void acpi_set_vec_parent(int node, struct irq_domain *parent, struct acpi
>         }
>  }
>
> -struct irq_domain *acpi_get_vec_parent(int node, struct acpi_vector_group *vec_group)
> +static struct irq_domain *acpi_get_vec_parent(int node, struct acpi_vector_group *vec_group)
>  {
>         int i;
>
> --
> 2.31.1
>