Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f1e00958-d889-d6d0-db41-fb79cb614a7a@kernel.org>
Date:   Thu, 4 Aug 2022 08:47:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 3/3] Revert "Kbuild, lto, workaround: Don't warn for
 initcall_reference in modpost"
Content-Language: en-US
To:     Nick Desaulniers <ndesaulniers@google.com>,
        Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org,
        Michal Marek <michal.lkml@markovi.net>,
        linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
        "H. Peter Anvin" <hpa@linux.intel.com>
References: <20220730173636.1303357-1-masahiroy@kernel.org>
 <20220730173636.1303357-3-masahiroy@kernel.org>
 <CAKwvOdkq1or=UOWJLU2DaS=MFGO9OmH7HG6=FDKS6h_saoKLAw@mail.gmail.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <CAKwvOdkq1or=UOWJLU2DaS=MFGO9OmH7HG6=FDKS6h_saoKLAw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 02. 08. 22, 20:04, Nick Desaulniers wrote:
> On Sat, Jul 30, 2022 at 10:37 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>
>> This reverts commit 77ab21adae509c5540956729e2d03bc1a59bc82a.
>>
>> That commit was 8 years old, and it said "This is a workaround".
>> If this is needed for GCC LTO, it should be added in a proper way.
>>
>> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> 
> Please don't forget to cc the author & reviewers for a patch when
> submitting a revert.
> 
> + Jiri in case a patch needs to be carried in any downstream trees for
> re-application.

IMO we already got rid of -fno-toplevel-reorder (we have noreorder 
attribute now), so:

Acked-by: Jiri Slaby <jirislaby@kernel.org>

> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

Thanks for letting me know.

>>   scripts/mod/modpost.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
>> index c6a055c0291e..a8ee27496da7 100644
>> --- a/scripts/mod/modpost.c
>> +++ b/scripts/mod/modpost.c
>> @@ -1462,9 +1462,6 @@ static void default_mismatch_handler(const char *modname, struct elf_info *elf,
>>          from = find_elf_symbol2(elf, r->r_offset, fromsec);
>>          fromsym = sym_name(elf, from);
>>
>> -       if (strstarts(fromsym, "reference___initcall"))
>> -               return;
>> -
>>          tosec = sec_name(elf, get_secindex(elf, sym));
>>          to = find_elf_symbol(elf, r->r_addend, sym);
>>          tosym = sym_name(elf, to);
>> --
>> 2.34.1
>>
> 
> 


-- 
js
suse labs