Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <73f35f39-9637-056e-91b9-ee6b2c104977@samsung.com>
Date:   Thu, 4 Aug 2022 09:29:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
        Thunderbird/91.11.0
Subject: Re: [dm-devel] [PATCH v9 05/13] nvme: zns: Allow ZNS drives that
 have non-power_of_2 zone size
Content-Language: en-US
To:     Bart Van Assche <bvanassche@acm.org>, <Johannes.Thumshirn@wdc.com>,
        <snitzer@kernel.org>, <axboe@kernel.dk>,
        <damien.lemoal@opensource.wdc.com>, <agk@redhat.com>, <hch@lst.de>
CC:     <pankydev8@gmail.com>, <gost.dev@samsung.com>,
        <linux-kernel@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
        <linux-block@vger.kernel.org>, <dm-devel@redhat.com>,
        <jaegeuk@kernel.org>, <matias.bjorling@wdc.com>,
        Luis Chamberlain <mcgrof@kernel.org>
From:   Pankaj Raghav <p.raghav@samsung.com>
In-Reply-To: <2616b59b-8c6b-a482-a396-d9408fa461a3@acm.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
CMS-TYPE: 201P
References: <20220803094801.177490-1-p.raghav@samsung.com>
        <CGME20220803094808eucas1p1a6a800161d32fe4242d39e669e5f3527@eucas1p1.samsung.com>
        <20220803094801.177490-6-p.raghav@samsung.com>
        <2616b59b-8c6b-a482-a396-d9408fa461a3@acm.org>
Precedence: bulk

Hi Bart,

On 2022-08-03 19:22, Bart Van Assche wrote:
> On 8/3/22 02:47, Pankaj Raghav wrote:
>> -    sector &= ~(ns->zsze - 1);
>> +    /*
>> +     * Round down the sector value to the nearest zone start
>> +     */
>> +    div64_u64_rem(sector, ns->zsze, &remainder);
>> +    sector -= remainder;
> 
> Could bdev_offset_from_zone_start() be used here?
> 
We call this function during blk_revalidate_disk_zones() to evaluate the
chunk sectors. So we can't call bdev_offset_from_zone_start() from here
as the chunk_sectors will not be initialized yet :)