Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 4 Aug 2022 09:51:52 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Sebastian =?utf-8?B?V8O8cmw=?= <sebastian.wuerl@ororatech.com>
Cc:     Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Stefan =?utf-8?B?TcOkdGpl?= <stefan.maetje@esd.eu>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Christian Pellegrin <chripell@fsfe.org>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: mcp251x: Fix race condition on receive interrupt
Message-ID: <20220804075152.kqlp5weoz4grzbpp@pengutronix.de>
References: <20220803185910.5jpufgziqsslnqtf@pengutronix.de>
 <20220804064803.63157-1-sebastian.wuerl@ororatech.com>
 <20220804070603.s3llvccpldtkejln@pengutronix.de>
 <CA+KjhYWukGxZUMMch_vFe=TNYCD0-jmuwO2520oUVDPE2kE1Rw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wmflnmbvqbtvlyoh"
Content-Disposition: inline
In-Reply-To: <CA+KjhYWukGxZUMMch_vFe=TNYCD0-jmuwO2520oUVDPE2kE1Rw@mail.gmail.com>
Precedence: bulk


--wmflnmbvqbtvlyoh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 04.08.2022 09:45:07, Sebastian W=C3=BCrl wrote:
> On Thu, Aug 4, 2022 at 9:06 AM Marc Kleine-Budde <mkl@pengutronix.de> wro=
te:
> >
> > Another optimization idea: Do we need to re-read the eflag1? "eflag" is
> > for error handling only and you're optimizing the good path.
>=20
> I'd argue if a new message entered mailbox 1, this also potentially
> changed the error state, so we need to read it.

Makes sense!

> Thanks a lot for your feedback! Will post v3 soon.
>=20
> Also I'm sorry for spam in anyones inbox, I didn't get my mailing
> program to produce plain-text for the last mail.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--wmflnmbvqbtvlyoh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmLrepUACgkQrX5LkNig
011YJAf+L3PZEy9x/pSHGSUOvoAQF7K7jjRwi1zAeyss+ujiN0gls73XWN8NnoKo
AahPfXB8jdIeclp1wyRxeuuZwbwK2Vk1ZGYhnApeA3C2QLJX5GqsZLh06eovnafA
BF9cnmgKwiH9vZeYBMrJie9RD4wSN7yrGUQoU8G5x+/dBtRrD5TbHmpD8MK6Mx61
PkJ+Yvqs8rLc5WgcUBzrd3Lh3CQ1YcGZhYIuGOPDFD8ZTkSRPEuVREJx9c6VMRgV
B6bNTMD+saWayZdFyGEvtENrOXes16pwDZkL/VsMuY4tP+JqmHISWHvcg6mzhZHP
hkEqiB/Dy3cPaTpTlT0NzcA5RJmj4A==
=yFeG
-----END PGP SIGNATURE-----

--wmflnmbvqbtvlyoh--