Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp209172imn; Thu, 4 Aug 2022 02:52:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR4K3eY3vpfwjWVH+wwkgNfbCoDRN5G+aJAbZ0TpYC5GchsctnQ2IzdRACXGEHs6NAI74sjx X-Received: by 2002:aa7:dd4b:0:b0:43a:d508:7cb9 with SMTP id o11-20020aa7dd4b000000b0043ad5087cb9mr1241589edw.218.1659606734288; Thu, 04 Aug 2022 02:52:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659606734; cv=none; d=google.com; s=arc-20160816; b=AFDQvIgBMoplwTtLcB6eGLkAVSVkRreqfDazh8q/4ZCBvLmk3AvKHrfcrQhvliRvR6 bIjcfpZXpF7cZfyfcPQxOk5LHUayOUIkbXTStIKzgZeNx5POExO58URD5bK2dt5Muxi5 3VgfdzTNd3+3+SSpW9hIOrCbdSsLgQXBi9ZYJJToIS0HrFFHIgl6qlsp5Y+EfBr5L6i/ oQegIZjwa1EOAOKJh18xVvJ5pq2EHMb00gV+5cRdPK/L6hyT+PDPOVSW82Nllwu3BXKw 9YAlKG+Sc66QLNU1IwhG9tlsEEbqe+qUGCc3EjfBRzU5cnrClYk+vVfqMBuWJeHo4AJZ C6CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9nVqShRZl+adNoyCzoZbbDyILNI10XtdVl+Ba6osuSs=; b=HHUeCC8T4uyZXnFPeFpt8c8F7OpxXQ5Yzr1eahnsII0dWSd1efSTRLGl6xuqMh+jUw MEgqQegtTgUVOBAl5zXUQ3tlNFunw1FV61QjbzhHojbkLA4BE+85TP4Zyjikfp32SQlH IhW3XK3E1/Pi47+ZtluCdPOfyODfHY+1atWYsYeZ92vn4VFKuUxSl7jjrxXMHOf8Dvos qkkAQ6WopvukV+WKDYtZeaQ/pxcW8sGgbkEp/2j8n1nq9htSGeVMeXvrkEg7r1Zo8NEd AVs1yLP5jIi9CH1ZZrmDj15ySKUtP5fBvA7m9xn7WuYJoL0jLD2y44ihxEdrUVx00l1U 36lQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D5wKjSH1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd8-20020a170907628800b00730bc1282e5si391578ejc.526.2022.08.04.02.51.49; Thu, 04 Aug 2022 02:52:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D5wKjSH1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237403AbiHDJAu (ORCPT + 99 others); Thu, 4 Aug 2022 05:00:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233653AbiHDJAt (ORCPT ); Thu, 4 Aug 2022 05:00:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D9FACE24 for ; Thu, 4 Aug 2022 02:00:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 389A261503 for ; Thu, 4 Aug 2022 09:00:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68C9AC433D7; Thu, 4 Aug 2022 09:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659603647; bh=eXMvzUZu95Ah5TbkmgO+GruIO4JfBPp3ZniH6uNDpd0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D5wKjSH12jEj/mlQt3SnP7nUTkjzqys+walMZ821HX8I8zR9zvAeCVJ8RS9N26Dqx Dqxa0D2ECes/088nEbAJUCz0w3fD2Kq/Mo5YyYTfB9lRrTKWo31clb/9Viz5dP8/sg N73sEzyBJMfDD/rd5N0NRXWXVhhcLP1fJQLoPPA3W/QGsh3O6HByna1ERwOe7Gi7Gx X0aB9ShcDATEmFzZFocTGMNUbtYdWvt8n0GfVvmtcHXBlLpCtJGHekhcpZZHa9jzTE sj/PzOmXoCwvtq5rji40M8n2hpRh9E5o/iqdTMuxVFs99QY3Ln83JaSItjYLorjPCR a8Nm5WbNMmQtA== Date: Thu, 4 Aug 2022 09:00:43 +0000 From: Tzung-Bi Shih To: Patryk Duda Cc: Benson Leung , Guenter Roeck , Gwendal Grignou , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, upstream@semihalf.com Subject: Re: [PATCH v1] platform/chrome: cros_ec_proto: Update version on GET_NEXT_EVENT failure Message-ID: References: <20220714160951.9364-1-pdk@semihalf.com> <20220802154128.21175-1-pdk@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220802154128.21175-1-pdk@semihalf.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2022 at 05:41:28PM +0200, Patryk Duda wrote: > Fixes: 3300fdd630d4 ("platform/chrome: cros_ec: handle MKBP more events flag") > Cc: # 5.10+ Any concerns if removing the Cc tag? As I think a Fixes tag should be sufficient. On a related note, why did you specify for only 5.10+? > Signed-off-by: Patryk Duda You should collect the Reviewed-by tags the patch already got as dropping `ver_mask` initialization isn't a big change. I could do that for the patch this time. [...] > v0 -> v1 > - Dropped `ver_mask` initialization. Please start versioning from v1 next time.