Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ming Qian <ming.qian@nxp.com>
To:     mchehab@kernel.org, mirela.rabulea@oss.nxp.com,
        hverkuil-cisco@xs4all.nl
Cc:     shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, xiahong.bao@nxp.com, linux-imx@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: imx-jpeg: Disable useless interrupt to avoid kernel panic
Date:   Thu,  4 Aug 2022 17:38:41 +0800
Message-Id: <20220804093841.31337-1-ming.qian@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M9jgUoiJPMZNH6GM98zpYr0XMzTf1TQgf2/KbvMR1Igs59achkKCd7dIL4HE?=
 =?us-ascii?Q?o/HowXaW9ekONURRILtrccqMLMoX7mGrS4vQeY9gZeT4Sp9H7DBA0dK/7UAj?=
 =?us-ascii?Q?YjEeMUwCSd2XPeVLFeolL3Jy8Im005tTLkHKry8PHD/XaMVwYOJKxXP97+3T?=
 =?us-ascii?Q?TZrAuzOH0VhKaeKuPyt6j8SnEXEKcOrI3QzenIQux1LrPmXcl1Zv8TBCOGgT?=
 =?us-ascii?Q?3fPZGN8+cedVA1R23bEx61g6KkRKdhI2jzYCwnnXUs308aJPk+kYwflnVd4A?=
 =?us-ascii?Q?3JV61yGVbXAhYRx7eTdlAiPWikV7MFvihTKOgC7n2BCoejPKxohAqY0qKD7P?=
 =?us-ascii?Q?Y8UIM5qKgraoNEQDtstpQ6cdieaDQxblkhHPVhdB8maM5rbyJ267/tssjF0O?=
 =?us-ascii?Q?3ueECzkkyrAjSpNUoEsl9znsqZkT6SLo/gj/jlEx1O0hrn2igSyIKptBCd5t?=
 =?us-ascii?Q?5yBa8HB0T5oPzZ/25/CxFx77zWAWUjDTFnuMX2wyAPq/+8CAc0YUGRZWiTJ2?=
 =?us-ascii?Q?ekvqmxGDEpAMK7kx7SBYrLmB6F/1EppOF9KTfYCn5Nqvd44EIQhvqBZDHBSt?=
 =?us-ascii?Q?L22of7h8KVllpSQK5PlQUiASfeg/74RxzP1usq26xN5t8kcejejkPwjMbAn2?=
 =?us-ascii?Q?eZa8si8vAu/27kIJONgkaf+gp9PUcPtwqcIrQSeBtPHxpUy8NAlng6FyMa28?=
 =?us-ascii?Q?Ro/kTcyiP+uiPFBTlekUZLMwu/7x/Lk3d4Y1EwGXaG9/hU1v1Jh7nkiplibM?=
 =?us-ascii?Q?Ui0AAyl/Judx/E46IbcPeZi5NwkHZPh+us0kIX8dEbT6Ko17+cc+78tzH/wV?=
 =?us-ascii?Q?xhMoYmfAHoZSG2zPtFTJ7IfW9weyd1EO2XcI+AqrBBNQwgGQTsqv/9qF18q5?=
 =?us-ascii?Q?RdILdlYTjcVn9yBDvGMjDFvX+3VgeU+4LicMLp7EHTp9FgVSmXKBv7Xau7WV?=
 =?us-ascii?Q?xJ5hgobjJDNNBpmb8MgtJHsureol/T2HAnv8VnzQlLpKRLgXRHca+BXQTuPJ?=
 =?us-ascii?Q?aq20fmHaKReYkcvOCBB0pc0fu8TeMkJfigBwu++uyDMclxIYK7PT/AcDZq13?=
 =?us-ascii?Q?oI0GPQFsfyToXlh7NaNzZ8txDAnpppRwzBJXJcfk3DqANOODh6FKlby0IaP+?=
 =?us-ascii?Q?wftGyq87cBDtFUViArPB5NnqTg1dEaS2XlzkFBVJtlIBYAuAPvKKvub1O6Uc?=
 =?us-ascii?Q?H3zDouXSqL7NqX0h2aCtFGJQiI031XHVvB01oAFlP/yS14beH001HX7hDjOT?=
 =?us-ascii?Q?LkzvRCzZ3ek5EpH3FQW4eHZWQflFpKwex9i3ZCdMitOFR2+jPvyCvhYW9Bhs?=
 =?us-ascii?Q?P86q3CwFkGyHBaR+k+zufkzfWoL3w9dX4nudPktIc2O2BZXHBq9iI3Z/cXmU?=
 =?us-ascii?Q?7mHRaUsjLvwMZ9dSo0HRs7wBXSSBgRs6Kt5gwtIahOrrWjqgbC6MPX2aFSA/?=
 =?us-ascii?Q?q/moPMJtgWjwaoC5vRGvSrQr/6aB9838P2P6lUIQqz/YkegPv1+dd2B23k+Z?=
 =?us-ascii?Q?Y0lI8vOqQm6q/wpgUH4/+ndFCMvh8XbzcLOiCcVxYUO+4wuk+HKZ5QOu/Nlf?=
 =?us-ascii?Q?/KI265mjent8Kxg4HBu7/OtBfGG9YOveeWvNnAKj?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c160740-6f04-4be4-45a7-08da75fd29d0
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2022 09:39:01.8162
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V0Nqh3ZINk4PziJ8nphxd1pZqWiQOajaUY0xzTWqo4Thfz3FU5YmR8ucJlc7H1QNPudLSllpT2A5PE1HqeWJug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7267
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

There is a hardware bug that the interrupt STMBUF_HALF may be triggered
after or when disable interrupt.
It may led to unexpected kernel panic.
And interrupt STMBUF_HALF and STMBUF_RTND have no other effect.
So disable them and the unused interrupts.

meanwhile clear the interrupt status when disable interrupt.

Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
 drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
index 9418fcf740a8..ef28122a5ed4 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
@@ -76,12 +76,14 @@ void print_wrapper_info(struct device *dev, void __iomem *reg)
 
 void mxc_jpeg_enable_irq(void __iomem *reg, int slot)
 {
-	writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
+	writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
+	writel(0xF0C, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
 }
 
 void mxc_jpeg_disable_irq(void __iomem *reg, int slot)
 {
 	writel(0x0, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
+	writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
 }
 
 void mxc_jpeg_sw_reset(void __iomem *reg)
-- 
2.37.1