Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5507af1a-3548-8e08-be3f-42f59bcc2096@quicinc.com>
Date:   Thu, 4 Aug 2022 15:44:55 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 2/8] dt-bindings: remoteproc: qcom: adsp: Add compatible
 name for SC7280
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
CC:     <linux-remoteproc@vger.kernel.org>, <agross@kernel.org>,
        <bjorn.andersson@linaro.org>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <quic_plai@quicinc.com>,
        <bgoswami@quicinc.com>, <perex@perex.cz>, <tiwai@suse.com>,
        <srinivas.kandagatla@linaro.org>, <quic_rohkumar@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <swboyd@chromium.org>, <judyhsiao@chromium.org>,
        <devicetree@vger.kernel.org>
References: <1659536480-5176-1-git-send-email-quic_srivasam@quicinc.com>
 <1659536480-5176-3-git-send-email-quic_srivasam@quicinc.com>
 <20220803204359.GA2586715-robh@kernel.org>
From:   Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Organization: Qualcomm
In-Reply-To: <20220803204359.GA2586715-robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/4/2022 2:13 AM, Rob Herring wrote:
Thanks for your time and valuable inputs Rob!!!
> On Wed, Aug 03, 2022 at 07:51:14PM +0530, Srinivasa Rao Mandadapu wrote:
>> Add compatible name and update max reg items for SC7280 base platforms.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> ---
>>   .../devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml          | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml
>> index 9f11332..147996f 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml
>> @@ -17,11 +17,12 @@ properties:
>>     compatible:
>>       enum:
>>         - qcom,sdm845-adsp-pil
>> +      - qcom,sc7280-adsp-pil
>>   
>>     reg:
>> -    maxItems: 1
>> +    maxItems: 2
> sdm845 has 2 entries too?
No. There max items not changed.
>
>>       description:
>> -      The base address and size of the qdsp6ss register
>> +      The base address and size of the qdsp6ss register and mcc register
> Better expressed as:
>
> minItems: 1
> items:
>    - description: qdsp6ss register
>    - description: mcc register
>
> Though the descriptions could expand on what those registers are.
>
> Rob
Okay. Will change accordingly and re spin the patches.