Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vadim Pasternak <vadimp@nvidia.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        "rafael@kernel.org" <rafael@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ido Schimmel <idosch@nvidia.com>,
        Petr Machata <petrm@nvidia.com>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: RE: [PATCH 1/2] Revert "mlxsw: core: Use different get_trend()
 callbacks for different thermal zones"
Thread-Topic: [PATCH 1/2] Revert "mlxsw: core: Use different get_trend()
 callbacks for different thermal zones"
Thread-Index: AQHYpYz823UbypK34UGkFNMWE0pI2K2erAPw
Date:   Thu, 4 Aug 2022 12:20:54 +0000
Message-ID: <BN9PR12MB5381BAE6F85C68E1C9168A50AF9F9@BN9PR12MB5381.namprd12.prod.outlook.com>
References: <20220801095622.949079-1-daniel.lezcano@linaro.org>
In-Reply-To: <20220801095622.949079-1-daniel.lezcano@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ken1GPGIIYKi78SAx+I4cJKL1cvSgeR63OFoPbx/0++t/0Ssy/cPD3b9OiHG?=
 =?us-ascii?Q?yK2QTF6NXIYDqtt3EKLz94IDjQq6YPceyRvfeJ2T/10Xn2VH6Viq6Yjl1Dt3?=
 =?us-ascii?Q?LnVvI4VJ1t9jnLeHJlvzcxCFYL+K1/aioDcrklWuMxZBib9t+sQfoEKM/Zw9?=
 =?us-ascii?Q?s1MOl+c9hIdC7D7RTz55vrSxbEWbDU8Pk3sox3Imw1RJopzNZEePOOJ8Lwrg?=
 =?us-ascii?Q?M00snR2FbogvJrk9LN5q9+VE6bMMw9QZM4eD1UycE1/xTHNTJQeweAt8oDAQ?=
 =?us-ascii?Q?IFalWGzaTcWntdHNphdzHjmTFrO/D1uACsQR2g8phNHt3es9EUT1xC7sYR4k?=
 =?us-ascii?Q?OF/gZMfMcJcWcS+OPXZq33HSoMjyEMFiadP7AdRxSCEC85S1p5C8XxbFaHKd?=
 =?us-ascii?Q?K3/EsE+Ic0wMHdZqQ0C0gFK1irWqcCobnM3shmoDvuGQLY+ywxjhS/lctqPe?=
 =?us-ascii?Q?LoyDnaa8ObV6IqlRoqRFpaBXqcRkDg2r8oYrzfjC2ei3lTIEhm3tlhRW2Gbs?=
 =?us-ascii?Q?JeQjxFYvan3x/K1MgIKDdlU7F3feU166vGhWallN/AnUMl7wm3JtpEvNcjet?=
 =?us-ascii?Q?5L9sg3BQT1O8JFl+XlIiWEM3Lemka7GmDqd1Fd6XKDNVs/X6v6vfsE1eaOwr?=
 =?us-ascii?Q?PsIgFt5xV9qHx+1WuvIDJCdINlQb8n5/KwU6wmkO0HlPTAtjItIagNOcxjhF?=
 =?us-ascii?Q?j7T0YoZnxNuIp6cYMHjp53R/g0s2aFpdIpR8ONhJNe6gxJdSXMIxygaeNz03?=
 =?us-ascii?Q?Of4wIt46dvF0JSn1dy4yQE5azo9it5n5xtk+22Vc7Ttn7yHpqUDBWJEVa6M0?=
 =?us-ascii?Q?V9B6rH95s89d8cFq5jiM6B5p/CXZA03ZUpgAyNDpxOHnlSXlutG61pUAlLPg?=
 =?us-ascii?Q?jETLv4419z94zoDNvYfD8wMvHQXBZjed86Q+tGfmrV8/BYuhOXenA5XNALK/?=
 =?us-ascii?Q?T+sjIH2Q7oKN2t1/pP9lVTP+jSny79EzcqAhNaY6mMi57X8eLYpQcmjP778D?=
 =?us-ascii?Q?IHLFTT97T4QgLeNO6kygnmQReRdlDWYFR5aUcFIh8iW4B4RKdmyuYkxyPHHg?=
 =?us-ascii?Q?JlwyEc3BWIQQkqaaleUOR4ac4bYn4p+xDyYsG5m2Ykc+MjMWx5QKUePJvqCK?=
 =?us-ascii?Q?TVXrYgdESzchBfPicQ12p4TkEw7DrmnocJBlgrjVkj+/QklkL8fm+KmyI+0F?=
 =?us-ascii?Q?YMsUA+KPIT/riITqmYvveNG+8q/Kx+8PWKDIKTkMr46+Q28vGE+vQZtAjtng?=
 =?us-ascii?Q?f7zr1izOzbYGw5afS1MESd9tVo+BQgIpVklxcATyvNxbV6TWSX1eeKFr5U4V?=
 =?us-ascii?Q?RlNTRUjwr5Gl5kVhXxByrHSAG0+6SKF1HA/XeWoK5H3yiPscgEwIK8NzGpvE?=
 =?us-ascii?Q?ZtWjweJZ1Wn920FCdrVy9WTseaNZTfOKM7yqnk/uY+CMvR1Kf9RicMQMEWYn?=
 =?us-ascii?Q?tI2YgVsz2sGdct3YtCubBC6/0auJMoRT17Z3YlSBej05IFmAb3qXUVfd7ICA?=
 =?us-ascii?Q?fOMQldBluj0cKOxhamtzBqudhzUI28qURLycFSU5YJeBIU3fr+Q+KCkbmyHq?=
 =?us-ascii?Q?BE1u5xuJxL9bZnzhpiucge7X8Pyfm8BGaFl3WUxq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5381.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f399a4af-5908-4d72-b9ba-08da7613c73d
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2022 12:20:54.5357
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FkvEcXg94fu6WHCsf9q4WFpkmxzKz3a5+D2VZ/5Umib4nnntmggNXqXiBy50223O363BcO4+sbu2sCUmZ77cKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1539
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Daniel Lezcano <daniel.lezcano@linaro.org>
> Sent: Monday, August 1, 2022 12:56 PM
> To: daniel.lezcano@linaro.org; rafael@kernel.org
> Cc: Vadim Pasternak <vadimp@nvidia.com>; davem@davemloft.net;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Ido Schimmel
> <idosch@nvidia.com>; Petr Machata <petrm@nvidia.com>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>
> Subject: [PATCH 1/2] Revert "mlxsw: core: Use different get_trend()
> callbacks for different thermal zones"
>=20
> This reverts commit 2dc2f760052da4925482ecdcdc5c94d4a599153c.
>=20
> As discussed in the thread:
>=20
> https://lore.kernel.org/all/f3c62ebe-7d59-c537-a010-
> bff366c8aeba@linaro.org/
>=20
> the feature provided by commits 2dc2f760052da and 6f73862fabd93 is
> actually already handled by the thermal framework via the cooling device
> state aggregation, thus all this code is pointless.
>=20
> No conflict happened when reverting the patch.
>=20
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Tested-by: Vadim Pasternak <vadimp@nvidia.com>

> ---
>  .../ethernet/mellanox/mlxsw/core_thermal.c    | 23 ++++---------------
>  1 file changed, 4 insertions(+), 19 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
> b/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
> index 05f54bd982c0..f5751242653b 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
> @@ -345,7 +345,8 @@ static int mlxsw_thermal_set_trip_hyst(struct
> thermal_zone_device *tzdev,  static int mlxsw_thermal_trend_get(struct
> thermal_zone_device *tzdev,
>  				   int trip, enum thermal_trend *trend)  {
> -	struct mlxsw_thermal *thermal =3D tzdev->devdata;
> +	struct mlxsw_thermal_module *tz =3D tzdev->devdata;
> +	struct mlxsw_thermal *thermal =3D tz->parent;
>=20
>  	if (trip < 0 || trip >=3D MLXSW_THERMAL_NUM_TRIPS)
>  		return -EINVAL;
> @@ -537,22 +538,6 @@ mlxsw_thermal_module_trip_hyst_set(struct
> thermal_zone_device *tzdev, int trip,
>  	return 0;
>  }
>=20
> -static int mlxsw_thermal_module_trend_get(struct thermal_zone_device
> *tzdev,
> -					  int trip, enum thermal_trend
> *trend)
> -{
> -	struct mlxsw_thermal_module *tz =3D tzdev->devdata;
> -	struct mlxsw_thermal *thermal =3D tz->parent;
> -
> -	if (trip < 0 || trip >=3D MLXSW_THERMAL_NUM_TRIPS)
> -		return -EINVAL;
> -
> -	if (tzdev =3D=3D thermal->tz_highest_dev)
> -		return 1;
> -
> -	*trend =3D THERMAL_TREND_STABLE;
> -	return 0;
> -}
> -
>  static struct thermal_zone_device_ops mlxsw_thermal_module_ops =3D {
>  	.bind		=3D mlxsw_thermal_module_bind,
>  	.unbind		=3D mlxsw_thermal_module_unbind,
> @@ -562,7 +547,7 @@ static struct thermal_zone_device_ops
> mlxsw_thermal_module_ops =3D {
>  	.set_trip_temp	=3D mlxsw_thermal_module_trip_temp_set,
>  	.get_trip_hyst	=3D mlxsw_thermal_module_trip_hyst_get,
>  	.set_trip_hyst	=3D mlxsw_thermal_module_trip_hyst_set,
> -	.get_trend	=3D mlxsw_thermal_module_trend_get,
> +	.get_trend	=3D mlxsw_thermal_trend_get,
>  };
>=20
>  static int mlxsw_thermal_gearbox_temp_get(struct thermal_zone_device
> *tzdev, @@ -599,7 +584,7 @@ static struct thermal_zone_device_ops
> mlxsw_thermal_gearbox_ops =3D {
>  	.set_trip_temp	=3D mlxsw_thermal_module_trip_temp_set,
>  	.get_trip_hyst	=3D mlxsw_thermal_module_trip_hyst_get,
>  	.set_trip_hyst	=3D mlxsw_thermal_module_trip_hyst_set,
> -	.get_trend	=3D mlxsw_thermal_module_trend_get,
> +	.get_trend	=3D mlxsw_thermal_trend_get,
>  };
>=20
>  static int mlxsw_thermal_get_max_state(struct thermal_cooling_device
> *cdev,
> --
> 2.25.1