Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "John Fastabend" <john.fastabend@gmail.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>
CC:     "Weiny, Ira" <ira.weiny@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH] ixgbe: Use kmap_local_page in
 ixgbe_check_lbtest_frame()
Thread-Topic: [Intel-wired-lan] [PATCH] ixgbe: Use kmap_local_page in
 ixgbe_check_lbtest_frame()
Thread-Index: AQHYi8qqEhC7uGL1skKc8LIYqnadyK2e6oNg
Date:   Thu, 4 Aug 2022 12:53:55 +0000
Message-ID: <BYAPR11MB3367DD6AC06593E589092ED2FC9F9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20220629085836.18042-1-fmdefrancesco@gmail.com>
In-Reply-To: <20220629085836.18042-1-fmdefrancesco@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1tJ8NSnRHfEI6B0bZwq/nRzj3xqG/RdCB3ysuaPasA1iQljSv7T8uFH8jNPi?=
 =?us-ascii?Q?8B1qTvFkRUNlKU9xGPKka+i3LiqhzFpolOb8A4bHlzXd2idwUPoL8x7LXjjA?=
 =?us-ascii?Q?4UUKPdR59yc5oq2Gtfz7XFRSo3rstsnJxGBsW3322YK/0ViYp3rrhzTYwRcO?=
 =?us-ascii?Q?qBGYwnoh1xfE0BXlwuvfqsXTWNEjmMvDa02K2ZSfxiL9AW4F73/6ErfprGoo?=
 =?us-ascii?Q?H4fZz2dK4ycQz989RCXGL/qz3M3EBBRg/PCrGV/jpFQgvDnL7THV7eEtYAr1?=
 =?us-ascii?Q?9x0Jprhsr/zL+RvabJyjnAvQWLjv9uLIFrgqbu0SXaUOo/c7eMqv/K9Tj3fV?=
 =?us-ascii?Q?IYkdNQUD+cXyHjrM7FMqi1uR3PLbrsTDP9nNpWwv73RQhXgekBaxNbp+VxvA?=
 =?us-ascii?Q?JMzR8F2+phQJaF0WyOEG6Akn1qx77LSsAgyWVYmByc3X4AFa6AWblyrXIIG5?=
 =?us-ascii?Q?nrhDEA+doQoQ41T6lL4tgPv/WFEJy5lOb0O4BbiS8ffDeKfw09JSygHX8Nqt?=
 =?us-ascii?Q?YDg1Kgqkak/yiQRxPdQZMN6iAPJFevxfbjUlBKTZuCqCtrFMOcX+iOkwafAj?=
 =?us-ascii?Q?RQ6Bv79D4YE4Xq4aKiET9AF73ZXZ3gCDl+zH1Z95ZW1rinjyhPKy2hw0K+w8?=
 =?us-ascii?Q?0q2wDXq3ET3M+93SjJaRK6gVadcLebzN3WVmiSSwze8yALPQJ9TsbGcYG30y?=
 =?us-ascii?Q?SotGFDmrw21B8TbDtorOyL/zGsz88kM1jIX4LX4RozGoS/lHX1w979vPTuwk?=
 =?us-ascii?Q?xPsJBCpZGcFo3Ew6uc/k2s47FON1SGOi59SHWhFQc3NC8SCeY1+p2E/fJDCp?=
 =?us-ascii?Q?cWoBRj2f8qkh2E+dauTutjmDlSqDzEVedB5dWjO3WcUTffmGoV2VLTajXgFc?=
 =?us-ascii?Q?u5ftB1LeONPlW2HuRMMaN5PtyUNhREvM5YlsJHYdcZFPaV2HNM56o0GgJw7D?=
 =?us-ascii?Q?3j2n5Kj4Pfffh9/whlTOhtFanKzpVmyuKIJr5Ivqo5TZN0kh36COMFTcDaZB?=
 =?us-ascii?Q?hCRhBFk8u5++KaHcsAAs4an8xNw7znVu3Nn/KwVPcQdi/IIlnSJDPFpb4wNQ?=
 =?us-ascii?Q?PkIphM28deZL0/Lzq+ZKtU7rbAyP7N9WiirGNwgpgp24P19TzBUmL7R8tcVA?=
 =?us-ascii?Q?040vYNU6h6xIJhT8irm1nKujW5YN31uNCXoHnFrpZe8TCTJO5OY+p8+85TBJ?=
 =?us-ascii?Q?O/S9qmUgNlMlpOVLoO6eSsMb7Vge2SxwsIg8DT4MqfhecPV/D961zepPjtyC?=
 =?us-ascii?Q?1M6QztUgXzI+AKjbhhlIZQOJf9+C+r5afR3M2sXXD/+NTAygeyK236fISw6d?=
 =?us-ascii?Q?CT7Bbx2dLGMRnXD7gYsSewJ5KYSAM90/NPV9lCav15/GaVg3gwv35QY+xj8h?=
 =?us-ascii?Q?Wg+laEkLV8t6BcmdxQANK20M2cMAmNomRS5orsLzFf2Ah6i2m3gK5dO+PaOH?=
 =?us-ascii?Q?pfuS0naVTt1giY/yr7sx+x5gzh60P5O5l7G40crpV9WzpadrtuRrvGreu/qL?=
 =?us-ascii?Q?iywVHumGJwa7b7dA8/NOYut2jLgeie2foDRDj1xGGinPf7i4PoV0WtMYYQAp?=
 =?us-ascii?Q?i5ffnwGzZwPCqVFByrJM3pbUJf4Gq/wVplML0w4H?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 174daddc-a627-4616-304c-08da76186444
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2022 12:53:55.9517
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 71gLqE66xnscU00lFe+hYE7w3qqseyJWXi5OESpVq+SMn/atNLfHhqXCg0MsvsGCwm2bBoqW98ezFoSzgasO3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5239
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Fabio M. De Francesco
> Sent: Wednesday, June 29, 2022 2:29 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>;
> Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Alexei Starovoitov <ast@kernel.org>;
> Daniel Borkmann <daniel@iogearbox.net>; Jesper Dangaard Brouer
> <hawk@kernel.org>; John Fastabend <john.fastabend@gmail.com>; intel-
> wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; bpf@vger.kernel.org
> Cc: Weiny, Ira <ira.weiny@intel.com>; Fabio M. De Francesco
> <fmdefrancesco@gmail.com>
> Subject: [Intel-wired-lan] [PATCH] ixgbe: Use kmap_local_page in
> ixgbe_check_lbtest_frame()
>=20
> The use of kmap() is being deprecated in favor of kmap_local_page().
>=20
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible. Furthermore, the mapping can be acquired from any conte=
xt
> (including interrupts).
>=20
> Therefore, use kmap_local_page() in ixgbe_check_lbtest_frame() because
> this mapping is per thread, CPU local, and not globally visible.
>=20
> Suggested-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)