Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7d430cc7-5f6c-536b-0e10-687c2804afa8@kernel.org>
Date:   Thu, 4 Aug 2022 21:32:54 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2] f2fs: do not allow to decompress files have
 FI_COMPRESS_RELEASED
Content-Language: en-US
To:     Jaewook Kim <jw5454.kim@samsung.com>, jaegeuk@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, sj1557.seo@samsung.com,
        junbeom.yeom@samsung.com, youngjin.gil@samsung.com
References: <25e501d8a6eb$84cf4090$8e6dc1b0$@samsung.com>
 <CGME20220803085402epcas1p2a1a70630592fa73f3404ba120c6c1ac8@epcas1p2.samsung.com>
 <20220803085358.3963-1-jw5454.kim@samsung.com>
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <20220803085358.3963-1-jw5454.kim@samsung.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/8/3 16:53, Jaewook Kim wrote:
> If a file has FI_COMPRESS_RELEASED, all writes for it should not be
> allowed. However, as of now, in case of compress_mode=user, writes
> triggered by IOCTLs like F2FS_IOC_DE/COMPRESS_FILE are allowed unexpectly,
> which could crash that file.
> To fix it, let's do not allow F2FS_IOC_DE/COMPRESS_IOCTL if a file already
> has FI_COMPRESS_RELEASED flag.
> 
> This is the reproduction process:
> 1.  $ touch ./file
> 2.  $ chattr +c ./file
> 3.  $ dd if=/dev/random of=./file bs=4096 count=30 conv=notrunc
> 4.  $ dd if=/dev/zero of=./file bs=4096 count=34 seek=30 conv=notrunc
> 5.  $ sync
> 6.  $ do_compress ./file      ; call F2FS_IOC_COMPRESS_FILE
> 7.  $ get_compr_blocks ./file ; call F2FS_IOC_GET_COMPRESS_BLOCKS
> 8.  $ release ./file          ; call F2FS_IOC_RELEASE_COMPRESS_BLOCKS
> 9.  $ do_compress ./file      ; call F2FS_IOC_COMPRESS_FILE again
> 10. $ get_compr_blocks ./file ; call F2FS_IOC_GET_COMPRESS_BLOCKS again
> 
> This reproduction process is tested in 128kb cluster size.
> You can find compr_blocks has a negative value.
> 
> Fixes: 5fdb322ff2c2b ("f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE")
> 
> Signed-off-by: Junbeom Yeom <junbeom.yeom@samsung.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
> Signed-off-by: Youngjin Gil <youngjin.gil@samsung.com>
> Signed-off-by: Jaewook Kim <jw5454.kim@samsung.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,