Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a6c31e43-76eb-fefb-b197-c44537cb45af@kernel.org>
Date:   Thu, 4 Aug 2022 21:50:39 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH -next] f2fs: Replace kmalloc() with f2fs_kmalloc
Content-Language: en-US
To:     Jaegeuk Kim <jaegeuk@kernel.org>, Joe Perches <joe@perches.com>
Cc:     Christoph Hellwig <hch@infradead.org>, studentxswpy@163.com,
        linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org,
        Hacash Robot <hacashRobot@santino.com>
References: <20220801092202.3134668-1-studentxswpy@163.com>
 <YugaBtQcoR4XhXiQ@infradead.org>
 <b43b3babb8aea836add289245c640688bec87829.camel@perches.com>
 <YutC7yUo/mTfty9q@google.com>
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <YutC7yUo/mTfty9q@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/8/4 11:54, Jaegeuk Kim wrote:
> On 08/01, Joe Perches wrote:
>> On Mon, 2022-08-01 at 11:23 -0700, Christoph Hellwig wrote:
>>> On Mon, Aug 01, 2022 at 05:22:02PM +0800, studentxswpy@163.com wrote:
>>>> From: Xie Shaowen <studentxswpy@163.com>
>>>>
>>>> replace kmalloc with f2fs_kmalloc to keep f2fs code consistency.
>>>
>>> For that removing f2fs_kmalloc entirely would be way better.
>>
>> Dunno, maybe doubtful as there's a specific "fault injector" test
>> built around f2fs_<foo>alloc. (CONFIG_F2FS_FAULT_INJECTION)
> 
> Yes, it's very useful to run the test checking the ENOMEM case.

It's useful to cover more error paths for xxx_alloc functions in f2fs
with common testcases.

> 
>>
>> For a student lesson, it would significantly better to compile any
>> patch, especially to avoid broken patches, before submitting them.
>>