Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "John Fastabend" <john.fastabend@gmail.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>
CC:     "Weiny, Ira" <ira.weiny@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH] ixgbe: Don't call kmap() on page
 allocated with GFP_ATOMIC
Thread-Topic: [Intel-wired-lan] [PATCH] ixgbe: Don't call kmap() on page
 allocated with GFP_ATOMIC
Thread-Index: AQHYkG4SLXloggG0eEmmUhhkpGwfTa2e8hVA
Date:   Thu, 4 Aug 2022 13:53:13 +0000
Message-ID: <BYAPR11MB336742A69C474B31F692448CFC9F9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20220704140129.6463-1-fmdefrancesco@gmail.com>
In-Reply-To: <20220704140129.6463-1-fmdefrancesco@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hrA5VFyGsg0kS2Yf4dp5zmwBpbzEeRpiAc0QUHvjkvW7Y8V9K6VZDyiK+VRJ?=
 =?us-ascii?Q?CdJd+QLU/vxoBYspisD6k7FpeGFQB7HBZQDzePyOi+RB2opXwDbFhws4Ll4X?=
 =?us-ascii?Q?ip5YAYpE4vs86+jOM5Uv2kvMoRwYwVEgH0nEWnaK7ein9Zi00/NyHzCVnLBW?=
 =?us-ascii?Q?OswWw23pM+7XmI20r8qSXrv0G91XGQlQ1ZIDzQyN9Y+y4apjq+cwF/+RlvUD?=
 =?us-ascii?Q?7boT6uRJp3P5ek389kg7MseUYA9i9lVeY8bAR7H5znTp+wf4Y1g7nFdcQV0W?=
 =?us-ascii?Q?HhqELPhyWoUZg7q0EspahF56FWTXavhEFp82f3K466mC66p6Zve3wJdPARYu?=
 =?us-ascii?Q?nfR0qcLkSgunU/R6eb/bPRwzmlyT9NGoZ3Jnx0hN7pg5ut2gAaVfzXHDFtSs?=
 =?us-ascii?Q?szTj6Xv6iyQTaa/KtRhabotkna+X47ws61QZNXjXyae6LP05Yky+SP+TtbZM?=
 =?us-ascii?Q?+XCaF+vNqg/o/met19yfXY505l3dORYy3nOmZ8qTKh3VtjJSsQPrNxag1E+v?=
 =?us-ascii?Q?BpewD3qqKN2GWk89zxbkO2ZAyx2dBWZ11oAkXYrMLnMT2Ly5+fklPDViC+KO?=
 =?us-ascii?Q?1CXeaSN6VcHIM1YBcPE8Fp78bK3HXXCI4QA7TK1y5wGlU+PIQc2K/keh2mef?=
 =?us-ascii?Q?4OzW99rzrUxpVUzTQfODX1nRv9GeMKhFaueGd4RBHcD9WsKFFiLbF9ihTyBb?=
 =?us-ascii?Q?wqy+Mm7fOTEARX3cKA4cp2LN78Dj8Iu4uXxAZMsycqpo/HAg8ogcLZF46g+i?=
 =?us-ascii?Q?48nXANlvA0Z+m72J0YD//6qzDmXnfm1YH3Svh5mLfhGwqubGD+bxgGFgR/vP?=
 =?us-ascii?Q?Up/G6VWlP8n22riOa9eoP9LfZvpWbhigPJZw629x56z+7xhnvTR8f2SD5CAH?=
 =?us-ascii?Q?2XbG/eo38XDOhUPvElDBE/yaR2wVaZRuQFxePUJU3Lz3OOgMHL4PjW86Inm4?=
 =?us-ascii?Q?WX/QZsqKRR7mUErbXa2avEn6oEYMNDQJG/H3VNq+wsBTaYmVcUkhRLjE7THK?=
 =?us-ascii?Q?AdmPEZV0YmqhfqBEkVf9mhVgnkaTrkjn5mK9rSuAUibVax3/1F8jerXSN8O5?=
 =?us-ascii?Q?4NwPBq890BwUMtN5vGNXuLqUKI1zIfqq2Re1ZkaPME42bgXVuJF2b/vMrms+?=
 =?us-ascii?Q?iNMRH94a/RirOtmP/WIkeWQoH8/02ofY0SYVIjH4cDZxlLWBB/FLIbwGV/h+?=
 =?us-ascii?Q?+k5kt7ZiRK4Aos1wcpmMlqpwTU79nhDJPXar8GQ2UseTMCPyIDwtOIbL2J42?=
 =?us-ascii?Q?KlL4WyYHXNzj8hTvhXO4ykAUjzKNS4GKo1Ie7XR/528yOZOBEH/mdGrXk4VT?=
 =?us-ascii?Q?6F/A5pRyMq+G0N37/S1YDckIwJHirKP5NnzqT1t2fRzY7wGiVHNCExNy0mdN?=
 =?us-ascii?Q?v07ZLAj3pb599Xg/qQkrBq/cYnc6BwP2OlM5SmAe0T7Itg4227tA4IzOFu5o?=
 =?us-ascii?Q?5tfJg2HD9iTbAunSVUC79MYYpPHws/rNCzONkJdMlZKv/bJIwQBYvRh+6G87?=
 =?us-ascii?Q?rXiij/c80z3HLUDDG2dXhPbrHKD6zKtE/sL8z70YQ6F4UIIRBHwpna7BboRj?=
 =?us-ascii?Q?GZv9paOnt8z1jx41ydEPOpMHZs7yH+Ji5omf4SAt?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7461abda-6a70-4f38-5ca8-08da7620ac8c
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2022 13:53:13.1944
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OG2gj0omXZJ97e9HcTse4RF7Q1LNigYN2C+QI5S1hqFaseht39VZoegt4TTNe40r9ansRXrct3bDWIzVbb8evw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5930
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Fabio M. De Francesco
> Sent: Monday, July 4, 2022 7:31 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>;
> Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Alexei Starovoitov <ast@kernel.org>;
> Daniel Borkmann <daniel@iogearbox.net>; Jesper Dangaard Brouer
> <hawk@kernel.org>; John Fastabend <john.fastabend@gmail.com>; intel-
> wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; bpf@vger.kernel.org
> Cc: Weiny, Ira <ira.weiny@intel.com>; Fabio M. De Francesco
> <fmdefrancesco@gmail.com>
> Subject: [Intel-wired-lan] [PATCH] ixgbe: Don't call kmap() on page alloc=
ated
> with GFP_ATOMIC
>=20
> Pages allocated with GFP_ATOMIC cannot come from Highmem. This is why
> there is no need to call kmap() on them.
>=20
> Therefore, don't call kmap() on rx_buffer->page() and instead use a plain
> page_address() to get the kernel address.
>=20
> Suggested-by: Ira Weiny <ira.weiny@intel.com>
> Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)