Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0e721d07-8ca1-47f2-9ce8-769dac4f57d3@collabora.com>
Date:   Thu, 4 Aug 2022 20:18:34 +0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Cc:     usama.anjum@collabora.com, kernel@collabora.com,
        linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] docs/kselftest: Fix build commands in guidelines
Content-Language: en-US
To:     Jonathan Corbet <corbet@lwn.net>
References: <20220704083426.1867401-1-usama.anjum@collabora.com>
 <58aad5c5-339f-85b9-8f48-0ffbd133b0cb@linuxfoundation.org>
 <3e48da77-68b3-e94a-b428-2e628ca1d46b@collabora.com>
From:   Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <3e48da77-68b3-e94a-b428-2e628ca1d46b@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/26/22 9:59 AM, Muhammad Usama Anjum wrote:
> On 7/8/22 9:51 PM, Shuah Khan wrote:
>> On 7/4/22 2:34 AM, Muhammad Usama Anjum wrote:
>>> Build commands start with "make". It is missing. Add "make" to the start
>>> of the build command.
>>>
>>> Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding
>>> new tests")
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>> ---
>>>   Documentation/dev-tools/kselftest.rst | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/dev-tools/kselftest.rst
>>> b/Documentation/dev-tools/kselftest.rst
>>> index ee6467ca8293..9dd94c334f05 100644
>>> --- a/Documentation/dev-tools/kselftest.rst
>>> +++ b/Documentation/dev-tools/kselftest.rst
>>> @@ -255,9 +255,9 @@ Contributing new tests (details)
>>>      * All changes should pass::
>>>   -    kselftest-{all,install,clean,gen_tar}
>>> -    kselftest-{all,install,clean,gen_tar} O=abo_path
>>> -    kselftest-{all,install,clean,gen_tar} O=rel_path
>>> +    make kselftest-{all,install,clean,gen_tar}
>>> +    make kselftest-{all,install,clean,gen_tar} O=abs_path
>>> +    make kselftest-{all,install,clean,gen_tar} O=rel_path
>>>       make -C tools/testing/selftests {all,install,clean,gen_tar}
>>>       make -C tools/testing/selftests {all,install,clean,gen_tar}
>>> O=abs_path
>>>       make -C tools/testing/selftests {all,install,clean,gen_tar}
>>> O=rel_path
>>>
>>
>> Looks like it depends on a patch already in doc tree?
> Yes, the dependent patch is in doc tree. Corbet should pick up this patch.
Reminder!

>> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>>
>> thanks,
>> -- Shuah
> 

-- 
Muhammad Usama Anjum