Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 4 Aug 2022 15:59:26 +0100
From:   Mark Brown <broonie@kernel.org>
To:     "chunxu.li" <chunxu.li@mediatek.com>
Cc:     pierre-louis.bossart@linux.intel.com,
        peter.ujfalusi@linux.intel.com, lgirdwood@gmail.com,
        angelogioacchino.delregno@collabora.com, daniel.baluta@nxp.com,
        matthias.bgg@gmail.com, yc.hung@mediatek.com,
        tinghan.shen@mediatek.com, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org, sound-open-firmware@alsa-project.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        project_global_chrome_upstream_group@mediatek.com
Subject: Re: [PATCH 1/2] ASoC: SOF: Introduce optional callback
 of_machine_select
Message-ID: <YuvezrxOnAJTLKt9@sirena.org.uk>
References: <20220804091359.31449-1-chunxu.li@mediatek.com>
 <20220804091359.31449-2-chunxu.li@mediatek.com>
 <YuvG4drwG/rYoozp@sirena.org.uk>
 <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="h0hDaRGCHYmaxJ2S"
Content-Disposition: inline
In-Reply-To: <644d24503899e6ed8b6a7321979e11e46577a610.camel@mediatek.com>
Precedence: bulk


--h0hDaRGCHYmaxJ2S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 04, 2022 at 10:36:07PM +0800, chunxu.li wrote:

> Thanks for you advice, I'll remove the callback function, and directly
> call sof_of_machine_select() in sof_machine_check() as following.
>=20
> int sof_machine_check(struct snd_sof_dev *sdev)
> {
> 	}
>=20
> =09
> +	of_mach =3D sof_of_machine_select(sdev);
> +	if (of_mach) {
> +		sof_pdata->of_machine =3D of_mach;
> +		return 0;
> +	}

Looks good.

--h0hDaRGCHYmaxJ2S
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLr3s0ACgkQJNaLcl1U
h9CNtgf/XRsA3q6DYLqEaEXV4tXIlM8fA/R/M0YDmHq6Ue+jq26vdS+Af5jl77wB
FIpNpuihB4hPSw02XTLtF7vyGr2FovaTLOCQcYI1YFv/HdKvw2e/F7CGKbopburY
DaP2S1j4l5n/cEGFht//jtFMR1wlmgLPcjcSCx62mZpAqvUulCjnjL5EMhyygC2W
n+80WJg3AH1EzsDtYEsvjs7xI7zswHcamarrPa3Wgl/FIiAS99nk1PH17AKIlncB
Gl/wOsK9p5nDKqiKGrLmVuC80G6DOC2NcvMmu+zgElXU6SmUsytHQQWuWxfJ9jpr
PQ16skJvJ9CihoHwi7dYaA8P6h3J5Q==
=uDFa
-----END PGP SIGNATURE-----

--h0hDaRGCHYmaxJ2S--