Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp749455rwb; Thu, 4 Aug 2022 10:11:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR6Ke68ITvH5yTFDvo6A3z/nfDt759Po0jL/sOlJr/kV/v3kM8nThVNMuC4b2oNELa8sgEAp X-Received: by 2002:a05:6a00:1688:b0:52b:cf1f:807a with SMTP id k8-20020a056a00168800b0052bcf1f807amr2765857pfc.21.1659633118799; Thu, 04 Aug 2022 10:11:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659633118; cv=none; d=google.com; s=arc-20160816; b=dD85zWqdizMgLN+QEYAybOiD/eRfB8Ds5Ed7gvdA7+3m0AB1ZTVZ6rh0L6h7dBZipr i9q3zdSLfmt+VPe13eVQMoI/vXAK3bI8gylHK4BanAEH98lJSSffCjrOykNKy60O4IHr QFLz4yJnYSAz/AVL83HBapibK0vHsWAOaarx96gG6OtLDWPpSko+9xGb2O2M28T+s8la 6TKFRWo0RiEYBfQwQXLS7zfr0Zl4SSRj74Lz7yDRm95exPTD2nO8WHBQ3hG3tzAbtsKD lnhv8s9kN7W22fFPaaN8JgrEu5BmazuTZnPi27GX0WX09Z2UcdT/5JzvmAEzj3SACS/O ATfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xcHD0rmCevHtOXoxMV/kPS+CYB/uJh1PVeFT9PFxhEQ=; b=iW+nd9EnDySIRYSp0odLXE4Pd6iW+L9msNcNLaginMEXGoAXnoBQ9Q1Sw1xS+l+hnC 9fuJFEPLgInVrVQEe56Bxyg1hcA60Xks/NH9ydDBOXwSHrPNTMutR8qo3BCIOSBf978B soE+m0xXeClKPfAw3TCiNPagD2IyBc3bCN/x0kD0v63gUktD6waCn20ZjDbb03Nf3LhB y43dV3+igBgcCpG4Stl+PomgcWwWzGlzbP+C1D/Lz8ArxQh+U2k3yWkdFxr/efVVXhjW v9rzkikKMy6dL9UjVcGoIV8odMDSFo7DQydiZGsBnfIXXP9hwV977rRuFzS0Jd6mOijR Davw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=I0rs2vQn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u6-20020a637906000000b0041a2b18788dsi338667pgc.364.2022.08.04.10.11.44; Thu, 04 Aug 2022 10:11:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=I0rs2vQn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234481AbiHDRIJ (ORCPT + 99 others); Thu, 4 Aug 2022 13:08:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236460AbiHDRIH (ORCPT ); Thu, 4 Aug 2022 13:08:07 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3736F67148 for ; Thu, 4 Aug 2022 10:08:06 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id 13so417877pgc.8 for ; Thu, 04 Aug 2022 10:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xcHD0rmCevHtOXoxMV/kPS+CYB/uJh1PVeFT9PFxhEQ=; b=I0rs2vQnXM/6+tMl051HmEPfv/hMCAtded5s8SZFMZkKXgfn9gKAyPs2A1FrvXVC3X znNPMh5PBIL4zU0Pr88K0hsgC1xJnMsJtvnVW8fL9+DvY3kngVFbnsnCHUtZtYGfCrAW oMIVFyBqQ+BtlBUSvgj7en6Ytcc+qH3abY9tE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xcHD0rmCevHtOXoxMV/kPS+CYB/uJh1PVeFT9PFxhEQ=; b=kCnDIdNfq3TgwUR5Gvxep1Z4ZAu8OxSno+KT95xT+VhqJ7kX/8lu7/EJcpYM814NVB kqeZcj+5+OEWLXD8hjhHQ53PaHQbchNXvqJV1QKp5ZkFxQwlBuCQ4G3IBGFGYvC6XC9L ZVLYUp9018k2Zh1WYJfmkhytdIL+hE9FWQCmVLvat9fX7xwERWz793+5+AQ0bBPXmio+ vV2QTTJCA+DZeq8wFdgudKT1QtQN88LAiInziawoKY49fJst29W9RbK4BphdT+nu/XJX Dbrc3aFg3s8N5KXBPuXpJ2boXuEO07fAa7fYwL80svgZKGXKQlnGjrWyh3yZ0tqr6g+p D1MQ== X-Gm-Message-State: ACgBeo04b5sbUjpotL9Bw9A0KQhh+OUOGghXOsqO2TOiLmNBjXvzys9A wKAgKZqq43s+ETWVN09eRXLRaQ== X-Received: by 2002:a62:5441:0:b0:52b:ab93:1f05 with SMTP id i62-20020a625441000000b0052bab931f05mr2659803pfb.30.1659632885576; Thu, 04 Aug 2022 10:08:05 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:87c4:32ca:84b6:e942]) by smtp.gmail.com with UTF8SMTPSA id t6-20020a170902b20600b0016d7b2352desm1143873plr.244.2022.08.04.10.08.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Aug 2022 10:08:05 -0700 (PDT) Date: Thu, 4 Aug 2022 10:08:03 -0700 From: Matthias Kaehlcke To: Johan Hovold Cc: Greg Kroah-Hartman , Felipe Balbi , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Manivannan Sadhasivam , Konrad Dybcio , Krishna Kurapati , Stephen Boyd , Doug Anderson , Pavankumar Kondeti , quic_ppratap@quicinc.com, quic_vpulyala@quicinc.com, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 9/9] usb: dwc3: qcom: clean up suspend callbacks Message-ID: References: <20220804151001.23612-1-johan+linaro@kernel.org> <20220804151001.23612-10-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220804151001.23612-10-johan+linaro@kernel.org> X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 04, 2022 at 05:10:01PM +0200, Johan Hovold wrote: > Clean up the suspend callbacks by separating the error and success paths > to improve readability. > > Also drop a related redundant initialisation. > > Signed-off-by: Johan Hovold Reviewed-by: Matthias Kaehlcke