Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6c516a7c-ac97-e0b1-b056-06a17d1b7420@intel.com>
Date:   Thu, 4 Aug 2022 12:03:56 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] x86/acrn: Improve ACRN hypercalls
Content-Language: en-US
To:     Uros Bizjak <ubizjak@gmail.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>
References: <20220804180358.32944-1-ubizjak@gmail.com>
 <91ccae0b-6135-6163-f59b-4e99624090a5@intel.com>
 <CAFULd4YRzEXL1+cvBPT1hmfq=ZLwtrexHt+vDABnA2QMiVMBpg@mail.gmail.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <CAFULd4YRzEXL1+cvBPT1hmfq=ZLwtrexHt+vDABnA2QMiVMBpg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/4/22 11:56, Uros Bizjak wrote:
> The %r8 is not preserved across function calls, so your statement
> above is correct. But as long as there is no function call *between*
> the variable definition and the assembly, the approach with the local
> register variable works without any problems. It is even something GCC
> itself has used in its library for years.

I'm glad it's workout out for GCC.  But, the kernel is not GCC.  I
specifically asked for the ACRN code to be the way that it is today and
your argument is not making me reconsider it in the slightest.

So, thanks for the patch, but I don't think we should apply it.