Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753388AbXFGKe5 (ORCPT ); Thu, 7 Jun 2007 06:34:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753838AbXFGKep (ORCPT ); Thu, 7 Jun 2007 06:34:45 -0400 Received: from wip-cdc-wd.wipro.com ([203.91.201.26]:42614 "EHLO wip-cdc-wd.wipro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754174AbXFGKen (ORCPT ); Thu, 7 Jun 2007 06:34:43 -0400 Subject: [KJ][PATCH]is_power_of_2-ia64/mm/hugetlbpage.c From: vignesh babu Reply-To: vignesh.babu@wipro.com To: tony.luck@intel.com, rohit.seth@intel.com, kenneth.w.chen@intel.com Cc: linux-ia64@vger.kernel.org, linux-mm@kvack.org, linux-kernel , Kernel Janitors List Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: WIPRO Technologies Date: Thu, 07 Jun 2007 15:27:46 +0530 Message-Id: <1181210266.11218.3.camel@merlin.linuxcoe.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 (2.10.1-4.fc7) X-OriginalArrivalTime: 07 Jun 2007 09:58:11.0199 (UTC) FILETIME=[5B5D18F0:01C7A8EA] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1271 Lines: 38 Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 Signed-off-by: vignesh babu --- diff --git a/arch/ia64/mm/hugetlbpage.c b/arch/ia64/mm/hugetlbpage.c index 1346b7f..d22861c 100644 --- a/arch/ia64/mm/hugetlbpage.c +++ b/arch/ia64/mm/hugetlbpage.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -182,7 +183,7 @@ static int __init hugetlb_setup_sz(char *str) tr_pages = 0x15557000UL; size = memparse(str, &str); - if (*str || (size & (size-1)) || !(tr_pages & size) || + if (*str || !is_power_of_2(size) || !(tr_pages & size) || size <= PAGE_SIZE || size >= (1UL << PAGE_SHIFT << MAX_ORDER)) { printk(KERN_WARNING "Invalid huge page size specified\n"); -- Vignesh Babu BM _____________________________________________________________ "Why is it that every time I'm with you, makes me believe in magic?" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/