Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 04 Aug 2022 21:53:39 +0000
To:     Hans de Goede <hdegoede@redhat.com>
From:   =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>
Cc:     "Luke D. Jones" <luke@ljones.dev>, markgross@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Reply-To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>
Subject: Re: [PATCH v2 1/1] asus-wmi: Add support for TUF laptop keyboard states
Message-ID: <ybhjXWmB07-FDJ_Shcl8d3jd7Y6SJdoQ1XPQrxe1q6MVogS6BaYdjkf-g9DAdXWvfmmemMVGWk9t34LDhiJTFidhVXkkfOwXHMNx-f1Vgq0=@protonmail.com>
In-Reply-To: <db7f33c8-404d-6e41-73af-370e148a4eed@redhat.com>
References: <20220803231331.48788-1-luke@ljones.dev> <20220803231331.48788-2-luke@ljones.dev> <db7f33c8-404d-6e41-73af-370e148a4eed@redhat.com>
Feedback-ID: 20568564:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Hans


2022. augusztus 4., cs=C3=BCt=C3=B6rt=C3=B6k 15:22 keltez=C3=A9ssel, Hans d=
e Goede <hdegoede@redhat.com> =C3=ADrta:

> [...]
> Please make this an extra attribute for the led_class_device,
> you can do this by adding this attribute to a separate
> attribute_group, lets say e.g. "tuf_rgb_attributes" and then
> in the "[PATCH] asus-wmi: Add support for TUF laptop keyboard RGB"
> code add:
>
> =09mc_cdev->led_cdev.groups =3D tuf_rgb_attributes;
>
> and then the "tuf_krgb_state" file should show up as:
> /sys/class/leds/asus::multicolour/tuf_krgb_state

I am not sure this will work because `led_classdev_multicolor_register_ext(=
)`
overrides the embedded LED device's `led_classdev::groups` with
`led_multicolor_groups` to provide the multi-color functionality
before calling `led_classdev_register_ext()`.


> [...]


Regards,
Barnab=C3=A1s P=C5=91cze