Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d55ed858-ccb2-1983-e93a-3090e1960eb0@ti.com>
Date:   Fri, 5 Aug 2022 06:49:28 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v5 24/33] thermal/drivers/ti-soc: Switch to new of API
Content-Language: en-US
To:     Daniel Lezcano <daniel.lezcano@linexp.org>,
        <daniel.lezcano@linaro.org>, <rafael@kernel.org>
CC:     <rui.zhang@intel.com>, <linux-pm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <khilman@baylibre.com>,
        <abailon@baylibre.com>, <lukasz.luba@arm.com>,
        <broonie@kernel.org>, <damien.lemoal@opensource.wdc.com>,
        <heiko@sntech.de>, <hayashi.kunihiko@socionext.com>,
        <mhiramat@kernel.org>, <talel@amazon.com>,
        <thierry.reding@gmail.com>, <digetx@gmail.com>,
        <jonathanh@nvidia.com>, <anarsoul@gmail.com>,
        <tiny.windzz@gmail.com>, <baolin.wang7@gmail.com>,
        <f.fainelli@gmail.com>, <bjorn.andersson@linaro.org>,
        <mcoquelin.stm32@gmail.com>, <glaroque@baylibre.com>,
        <miquel.raynal@bootlin.com>, <shawnguo@kernel.org>,
        <niklas.soderlund@ragnatech.se>, <matthias.bgg@gmail.com>,
        Eduardo Valentin <edubezval@gmail.com>,
        Amit Kucheria <amitk@kernel.org>,
        "open list:TI BANDGAP AND THERMAL DRIVER" 
        <linux-omap@vger.kernel.org>
References: <20220804224349.1926752-1-daniel.lezcano@linexp.org>
 <20220804224349.1926752-25-daniel.lezcano@linexp.org>
From:   "J, KEERTHY" <j-keerthy@ti.com>
In-Reply-To: <20220804224349.1926752-25-daniel.lezcano@linexp.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/5/2022 4:13 AM, Daniel Lezcano wrote:
> The thermal OF code has a new API allowing to migrate the OF
> initialization to a simpler approach. The ops are no longer device
> tree specific and are the generic ones provided by the core code.
> 
> Convert the ops to the thermal_zone_device_ops format and use the new
> API to register the thermal zone with these generic ops.

Acked-by: Keerthy <j-keerthy@ti.com>

> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org>
> ---
>   .../thermal/ti-soc-thermal/ti-thermal-common.c   | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> index 703039d8b937..8a9055bd376e 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> @@ -65,10 +65,10 @@ static inline int ti_thermal_hotspot_temperature(int t, int s, int c)
>   
>   /* thermal zone ops */
>   /* Get temperature callback function for thermal zone */
> -static inline int __ti_thermal_get_temp(void *devdata, int *temp)
> +static inline int __ti_thermal_get_temp(struct thermal_zone_device *tz, int *temp)
>   {
>   	struct thermal_zone_device *pcb_tz = NULL;
> -	struct ti_thermal_data *data = devdata;
> +	struct ti_thermal_data *data = tz->devdata;
>   	struct ti_bandgap *bgp;
>   	const struct ti_temp_sensor *s;
>   	int ret, tmp, slope, constant;
> @@ -85,8 +85,8 @@ static inline int __ti_thermal_get_temp(void *devdata, int *temp)
>   		return ret;
>   
>   	/* Default constants */
> -	slope = thermal_zone_get_slope(data->ti_thermal);
> -	constant = thermal_zone_get_offset(data->ti_thermal);
> +	slope = thermal_zone_get_slope(tz);
> +	constant = thermal_zone_get_offset(tz);
>   
>   	pcb_tz = data->pcb_tz;
>   	/* In case pcb zone is available, use the extrapolation rule with it */
> @@ -107,9 +107,9 @@ static inline int __ti_thermal_get_temp(void *devdata, int *temp)
>   	return ret;
>   }
>   
> -static int __ti_thermal_get_trend(void *p, int trip, enum thermal_trend *trend)
> +static int __ti_thermal_get_trend(struct thermal_zone_device *tz, int trip, enum thermal_trend *trend)
>   {
> -	struct ti_thermal_data *data = p;
> +	struct ti_thermal_data *data = tz->devdata;
>   	struct ti_bandgap *bgp;
>   	int id, tr, ret = 0;
>   
> @@ -130,7 +130,7 @@ static int __ti_thermal_get_trend(void *p, int trip, enum thermal_trend *trend)
>   	return 0;
>   }
>   
> -static const struct thermal_zone_of_device_ops ti_of_thermal_ops = {
> +static const struct thermal_zone_device_ops ti_of_thermal_ops = {
>   	.get_temp = __ti_thermal_get_temp,
>   	.get_trend = __ti_thermal_get_trend,
>   };
> @@ -170,7 +170,7 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id,
>   		return -EINVAL;
>   
>   	/* in case this is specified by DT */
> -	data->ti_thermal = devm_thermal_zone_of_sensor_register(bgp->dev, id,
> +	data->ti_thermal = devm_thermal_of_zone_register(bgp->dev, id,
>   					data, &ti_of_thermal_ops);
>   	if (IS_ERR(data->ti_thermal)) {
>   		dev_err(bgp->dev, "thermal zone device is NULL\n");