Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754165AbXFGLdh (ORCPT ); Thu, 7 Jun 2007 07:33:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755310AbXFGLdW (ORCPT ); Thu, 7 Jun 2007 07:33:22 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:38402 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754371AbXFGLdV (ORCPT ); Thu, 7 Jun 2007 07:33:21 -0400 Date: Thu, 07 Jun 2007 20:33:10 +0900 Message-ID: <87sl949eyx.wl%takeuchi_satoru@jp.fujitsu.com> From: Satoru Takeuchi To: Linus Torvalds Cc: Roland McGrath , Andrew Morton , Linux Kernel , Satoru Takeuchi , Oleg Nesterov , Benjamin Herrenschmidt Subject: Re: [BUG] ptraced process waiting on syscall may return kernel internal errnos In-Reply-To: References: <20070606105900.DE5E94D0592@magilla.localdomain> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/21.4 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 36 Hi Linus, At Wed, 6 Jun 2007 08:35:27 -0700 (PDT), Linus Torvalds wrote: > On Wed, 6 Jun 2007, Roland McGrath wrote: > > > > [PATCH] Restrict clearing TIF_SIGPENDING > > > > This patch should get a few birds. It prevents sigaction calls from > > clearing TIF_SIGPENDING in other threads, which could leak -ERESTART*. > > It fixes ptrace_stop not to clear it, which done at the syscall exit > > stop could leak -ERESTART*. It probably removes the harm from > > signalfd, at least assuming it never calls dequeue_signal on kernel > > threads that might have used block_all_signals. > > Ok, this one is more complex than my suggested one-liner, but seems to fix > another bug. And it's logic in dequeue_signal() is a bit prettier than > Ben's (otherwise somewhat similar) patch. I tested your patch and my problem didn't occur again, so it seems to my this case at least. However sometimes another bug appears instead which Roland regards it as strace bug. http://lkml.org/lkml/2007/6/7/91 BTW, There seems to be many problem on signal code... I take a long at it and detect more bugs (and of cource make patch if possible). Thanks, Satoru - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/