Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6876720c-8d3e-3112-30da-357046d4fcab@intel.com>
Date:   Fri, 5 Aug 2022 11:00:38 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] mm: memory-failure: cleanup try_to_split_thp_page()
Content-Language: en-US
To:     Kefeng Wang <wangkefeng.wang@huawei.com>,
        =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= 
        <naoya.horiguchi@nec.com>
CC:     Miaohe Lin <linmiaohe@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <e699cd23-3eeb-7920-accd-b30622efa551@huawei.com>
 <20220802021256.162269-1-wangkefeng.wang@huawei.com>
 <20220804004552.GA3631345@hori.linux.bs1.fc.nec.co.jp>
 <dd492213-3e6e-a1dd-75cf-eb8500bcbf20@huawei.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <dd492213-3e6e-a1dd-75cf-eb8500bcbf20@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnpVSUI3emdpemhFQlBteWRxOUx2S2R0Wk1GdVhlejVuUXNGZDZBSWJ0aE9H?=
 =?utf-8?B?TUN3bWdwenUyM25yOTZycHVLYzQ4TGx1S1BpeWxIWk9uUEdzOFlHR0drY2pz?=
 =?utf-8?B?dW1aQ21weXNwZ3hFMUNRZW94K0tMSnlMVHVROHBNWm5jOVdqK1FaaUZoS1NG?=
 =?utf-8?B?RmtoS1JabXh5UGZXUnk4UUlpNTVIdDkwcWtERVlxVGRKNnBlRWtNMWc3WUd3?=
 =?utf-8?B?dmh2bHREOXNkODdqUG9Ea25QSnZYSmZTc004SCs1bmhTaVUyNWpZc0U5djI4?=
 =?utf-8?B?RzkzUmdPZEVjTmdhdzBEbVpjVEp1OVFZY3Fvcnd5NWF5Z05rWlhiTDNWR2FR?=
 =?utf-8?B?SEI5OFkzdVBYQUtvRFVlMWlRQVVXVG9DUU1tSW5EMUU2UTlkekRubFd0T0gx?=
 =?utf-8?B?TmlhdDArUnNlQW5ZbUFScG14YTVXM0lTNkw1eU9tMlVCWmxpelRFSGxGeEJB?=
 =?utf-8?B?TWFtVjREc25SNnJhQWQ2T0oyMkdkRVlrQllJVXVBZ29Oc0U4cFRHalBCeFFM?=
 =?utf-8?B?Y1NCWDR5TDA4QW9XZGhIbVJaaW5IQmNib2lsSWdrOHhxdlk2aCs1clpPNFZv?=
 =?utf-8?B?Vng4L0J2TURBVStZNE5rdEhkR0hqNE16bUVYMWZ4OFYxZ1JNMERyaStiVW9H?=
 =?utf-8?B?RHY3WmpTRkVQZlFHL010cCtoMUEyNWhsdFdLdnRKOG16WWs1dUgrMEdtcG5C?=
 =?utf-8?B?UWJTWENTYk5ZNXpEM0FpaWlQNU5IZmJGaXZHVnN2UGdTbDdUaVpWamd1aEJW?=
 =?utf-8?B?a3NUWDZjWXJ3M2lTc3M5Y0NoMncvQllveHA1OWRaSjBtS1UwVFBWSkJoYVBK?=
 =?utf-8?B?NDh4bmU2czYrNHdnWGpFQ2tTZm5QQmRmZzhoZkdvMFdPaU9YS3loRkg3djNW?=
 =?utf-8?B?OWZYejNTMzVnN2RXcXJ2MG0vWXIrUjZzN1JWdzJHbnJObTRrczZhR0RzVkt1?=
 =?utf-8?B?RzljZDNRRXZrT3psQjl4djN2RmsxSlNIZ1ZjMHVGRFo0MmdZWHlROTlJUEZw?=
 =?utf-8?B?UmRKUHNsemxya21hQjg4SjFqVXVVMGJwUGdhKzhCTW94bUdwMlo0Ny9JNTMx?=
 =?utf-8?B?dWVXeVJWYWQyRHB5b2hBTm5PdTRUbjg5VGM1TkExdVJKMjdTSDZaOFY5V0U2?=
 =?utf-8?B?L1lWR1BCUUs4VUE0dG5XMG12Q21Ka0ZEcjl5enRVV1JoVHhPQ05COUhnYkoy?=
 =?utf-8?B?cFpZUGJ2TDdzZ3pwMDNRbnJudGlSR2hZajlHTCtLRk5jaXJBUkJNWnlhRlh0?=
 =?utf-8?B?RmdENkxjVnhmclB0RU80dTV0cnpHWnZiWTFrcGQxYncwV2N5eGNFbVBwY0Jn?=
 =?utf-8?B?bTgvU1Uxa2Z5RU1QWFY3Z2NDNWpRWUN1K3c4a0Jsa3p5M09RMUp4RjU1TFBh?=
 =?utf-8?B?NXJPaU1CWEpYUGpQcGlKSExCVUlHS0dxdlM4S2RsUlluTThYOUZLdEFRYVhC?=
 =?utf-8?B?WWVzajFaMEprN2tOY1pnTW1HRXc0UWhub2RQd08xWEF3VUU5YVcza053MVlv?=
 =?utf-8?B?QTVubkF6STVUTHV0REVFcVJMMDR6ZzZIZjRZd1NPUHVmV0w4NjZOWUk0KytV?=
 =?utf-8?B?QWkyNm5SSmJKREVUWWdyMG1PK28xa21zWE1HcW9qRmhRSlliMnN6NlNHWkRV?=
 =?utf-8?B?NGNIUU5sSnRzQStqalhnOTI1ZldNV1FGOGxuRjU2dkttSlhZQUtzSHZCQjlz?=
 =?utf-8?B?NXRBZUtlMmlnYWo2di9Qa1RXZXhNZGJLMTdoK0RqdXY5bG1vSWNWRXVpQUZB?=
 =?utf-8?B?a2J2dE1qaHkxNC9YekwvUnRuM3lRVWtwWnR5WElzMEVPQko2RmxraFd5WTU1?=
 =?utf-8?B?N1kzSTMyUFJjeDhKOHBobjJpZFVDQXNQZFVIbnVmSXZPZ3ZMNXovZEtPTkkw?=
 =?utf-8?B?NGlCZFdUd253UW1YRFcvSm1ERitUR2hGcW56a09HTG95aVdxSk42cmFKR2FX?=
 =?utf-8?B?VUcxZjhmNHQxZUlSTjRDcGFXdWlhMmM4NHdvcTRnTXVPU3hBejF5Y2NlMUt4?=
 =?utf-8?B?cmRkaHJsaEt1UFVjeWxlQytzamNWNTRuZkQ0ZC9sMHY1eFF2dmh0Mk9FYTV1?=
 =?utf-8?B?Q0ZqdHduWjVRS3BGUjBBNGdvYVcxdmdrbGxObVRxU0dqbmJrUDQ0VTdzOHUv?=
 =?utf-8?Q?FdS2WRTetoz5r+5dNEAnd5Lji?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 12c4ce71-61b1-4bfa-0ec9-08da768eb39e
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 03:00:49.8353
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RCjFWY+ejLmJ/3Fc5yhEcWAwX9Pmcxlcoh+m4ZjScNiED9+bY1QjIfbPNhhZuxlmYrLM13Khqdsdu/4hajRsWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2625
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022/8/4 09:03, Kefeng Wang wrote:
> 
> On 2022/8/4 8:45, HORIGUCHI NAOYA(堀口 直也) wrote:
>> On Tue, Aug 02, 2022 at 10:12:56AM +0800, Kefeng Wang wrote:
>>> Since commit 5d1fd5dc877b ("mm,hwpoison: introduce MF_MSG_UNSPLIT_THP"),
>>> the action_result() called to show memory error event in
>>> memory_failure(),
>>> so the pr_info() in try_to_split_thp_page() is only needed in
>>> soft_offline_in_use_page().
>>>
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> Thanks, looks good to me.  Probably this patch may come before
>> "mm: memory-failure: convert to pr_fmt()" to be a cleanup.
>>
>> And recently another patch [1] is trying to change the same function,
>> so we
>> might need to resolve the conflict with it.  I expect it's not so
>> hard, but
>> I think your series had better come after [1] because [1] is a bug fix
>> and
>> might be backported to stable-5.19.
> OK， I could repost after[1] merged into mm tree,  thanks.
Thanks a lot for the considering merge conflict. I suppose the private
data releasing will be moved to split_huge_page. There will no code
conflict and not block this patch merging.


Regards
Yin, Fengwei

>>
>> [1]
>> https://lore.kernel.org/linux-mm/20220803025243.155798-1-fengwei.yin@intel.com/T/#u
>>
>>
>> Thanks,
>> Naoya Horiguchi
>