Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cbd36b1b-1ddf-2d6b-40aa-88c40a41b526@linaro.org>
Date:   Fri, 5 Aug 2022 09:10:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: correct number
 of pins
Content-Language: en-US
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        "H. Nikolaus Schaller" <hns@goldelico.com>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220727140148.223508-1-krzysztof.kozlowski@linaro.org>
 <20220731133034.034dced1@jic23-huawei>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220731133034.034dced1@jic23-huawei>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 31/07/2022 14:30, Jonathan Cameron wrote:
> On Wed, 27 Jul 2022 16:01:48 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
>> BMG160 has two interrupt pins to which interrupts can be freely mapped.
>> Correct the schema to express such case and fix warnings like:
>>
>>   qcom/msm8916-alcatel-idol347.dtb: gyroscope@68: interrupts: [[97, 1], [98, 1]] is too long
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> We may need more than this.  What if only INT2 is wired?  

Right, thanks for pointing it out.

> I'd expect such
> a device's binding to include interrupt-names to cover that case.
> We'd also need a bunch of driver code to route the resulting interrupts.

Yes, which is a bit out of scope of fixing schema/DTS. The driver
supports only one interrupt and bindings are unspecific, so I think the
author just did not care about making it correct.

> 
> I think the snag is that adding such support will break existing bindings using the
> below.

I can prepare more relaxed version of the patch.

Best regards,
Krzysztof