Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 Aug 2022 00:16:17 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Siddh Raman Pant <code@siddh.me>
Cc:     Jonathan Corbet <corbet@lwn.net>,
        David Howells <dhowells@redhat.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Eric Dumazet <edumazet@google.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-kernel-mentees 
        <linux-kernel-mentees@lists.linuxfoundation.org>
Subject: Re: [PATCH 0/3] kernel/watch_queue: Clean up some code
Message-ID: <YuzDwa4otHkImo10@sol.localdomain>
References: <cover.1659618705.git.code@siddh.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1659618705.git.code@siddh.me>
Precedence: bulk

On Thu, Aug 04, 2022 at 07:00:21PM +0530, Siddh Raman Pant wrote:
> There is a dangling reference to pipe in a watch_queue after clearing it.
> Thus, NULL that pointer while clearing. This can be thought of as a v4 of
> the patches I had sent earlier.
> 
> This change renders wqueue->defunct superfluous, as the latter is only used
> to check if watch_queue is cleared. With this change, the pipe is NULL'd
> while clearing, so we can just check if the pipe is NULL.
> 
> Extending comment for watch_queue->pipe in the definition of watch_queue
> made the comment conventionally too long (it was already past 80 chars),
> so I have changed the struct annotations to be doxygen-styled, so that
> I can extend the comment mentioning that the pipe is NULL when watch_queue
> is cleared.
> 
> Siddh Raman Pant (3):
>   kernel/watch_queue: Remove dangling pipe reference while clearing
>     watch_queue
>   kernel/watch_queue: Improve struct annotation formatting
>   kernel/watch_queue: Remove wqueue->defunct and use pipe for clear
>     check
> 
>  include/linux/watch_queue.h | 95 +++++++++++++++++++++++++++----------
>  kernel/watch_queue.c        | 11 ++---
>  2 files changed, 75 insertions(+), 31 deletions(-)

I think patches 1 and 3 should be merged together.

Also, please use a consistent version number for all patches in the series.  You
have a version 1, version 2, and version 4 patch all in the same series, which
is very confusing.

- Eric