Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp1385155rwb; Fri, 5 Aug 2022 00:30:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR4g9dDlruxn7DjCA2x25HIZnKJLehSiHIIRi6EMbg5HlSZZPigHK6GttWkwcyQY6qHYXDbw X-Received: by 2002:a17:903:2407:b0:16d:ab14:a971 with SMTP id e7-20020a170903240700b0016dab14a971mr5359372plo.48.1659684630592; Fri, 05 Aug 2022 00:30:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659684630; cv=none; d=google.com; s=arc-20160816; b=jKMpbzkcotfLj3XxQEsWX2u197C6/h0bWZsfhZOMCt9/8tz5K8wT2Xhs8cPKBXzFta S/n0wkmgE/Tb2PZjfB9YQdPdug6HBE0LI0ymXqrXcqEOTwd2PVkTykJqNkUCjs8jgC1c Bhc4XP+mNGgU336klE25f90DAGpF8GUomsVFdAcFgIUcc1WO3853kDpJ168dOfsIqmaI zx+tPAv6pN4nted0f3qd1+L63Ly3oRvbLH5PCNfMgAjmRaGf2gZCfBybpHfx+VvnOPJC VOI641HuyGs7ImP+uHkmcCORzhYDZuhTxgPl/WrCHAX3CTgt3ofxOEjhsBEY0bw8RSqx ApnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=xMkGLwqA1mZq7hExgTupMO8I0C9+XtTTkXpKuqm9Ujw=; b=kj8IZ7RtgUi9ODwnBBfq3pXpyiEkzyJhIEJINiE8/CjWhZ7acCq3TlDCCLiWlUd2lz OcFdgn+kVJ4ROG9ViG/HyoWBoGTAYJjSDCJJ+zBSkm6XltS1Zvcjqagsh1LEZKRlwZ79 upfhfhgULScEMKWNU9pcRYDT1WwfBwT+5INgMCzuUMEDRL0efcMtGJQBqX0GISZUdz1i BCebupmJuMXb7WAVldQMqXYZEyUi556TXAH6/0HD8Be8eo+ORzp8fI1uBt6p6jYq6Le0 ZwHS98Uysd781N4Z3wGtiXw41bKWJJ69qu7rKqUsVZMKKO74b8rUDLlDm1oJ5B8JagHg Pt/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DSeNS3jR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v7-20020a654607000000b0041beb5156fcsi2645630pgq.9.2022.08.05.00.30.16; Fri, 05 Aug 2022 00:30:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DSeNS3jR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239984AbiHEG5c (ORCPT + 99 others); Fri, 5 Aug 2022 02:57:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237624AbiHEG5b (ORCPT ); Fri, 5 Aug 2022 02:57:31 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 405465FAD6 for ; Thu, 4 Aug 2022 23:57:30 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id f20so2143937lfc.10 for ; Thu, 04 Aug 2022 23:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=xMkGLwqA1mZq7hExgTupMO8I0C9+XtTTkXpKuqm9Ujw=; b=DSeNS3jRZHgPZZ+INM8dpcAeWV8cIjv76LYbNH6dH08Z+9GSG6imrfAZmDRsgl9q2o l6MgySiyZik2m1y3WiLYUofInLCO+nLS9faaJVnw1PSYlEMQLo4ImCbxz0SnNJSCwRWd 2uXF4myknLMbg59GhGMB337epFkNcvCDpSTfdlQxOEJ/5t8NQfdmHttAcWw/ZquIvnL6 4A1Dbw0S/JakSggt5Dmr+QZRpCqAvgl6KFCnTEiSFI3IJxYg3sj3Hhu/7OP1DKIHun/+ yhaIumIxYbLc9VHuU1n7yWI9eT70d/TzL8YUa62cejMfv/yHnFhkEt505mXlzY3Vf1J2 GvTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=xMkGLwqA1mZq7hExgTupMO8I0C9+XtTTkXpKuqm9Ujw=; b=eocKHj6CYKGgJLv2pAZFpqIMbJZ/bIja1mlyj+1MXnaBvkqjcaIyoe8Ptul0fQzZVR /Gn/lx6D+woXQBYDoTDO18oxPY4auw/63tTPKajKgHIr+zQ+hgEq1q7/I9K4yj0jg/5y 7a0m1b8M0UATbDtzI3Afo1xyrmM66uNv7zZkI/cJLi3SCMVUFM1g5F8XbmikwCRleJT3 tOJ/vI4i+Me+aAb7guM8qh4Clais2DCxWUe1Fo4NWe9OiBG8EHoEJxTaUibvGWnSVhhx NFupUttRI4DcB/3YVncnABspWNl61O023AowH0qDJNR4HSYSlaU/KlqdZhEOVOzi/lqq mgdQ== X-Gm-Message-State: ACgBeo3wKKVwE7R0LWmAbnzrYmHRrU7V4rTN5UzUZsf6cCS4lJzG4ez1 XZE6UH/UBM3BWh3dq9Cqft2iFA== X-Received: by 2002:a05:6512:2344:b0:48a:e5a8:3a6e with SMTP id p4-20020a056512234400b0048ae5a83a6emr1784338lfu.505.1659682648650; Thu, 04 Aug 2022 23:57:28 -0700 (PDT) Received: from [192.168.1.6] ([77.222.167.48]) by smtp.gmail.com with ESMTPSA id t8-20020a2e8e68000000b0025e77564a55sm269178ljk.42.2022.08.04.23.57.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Aug 2022 23:57:27 -0700 (PDT) Message-ID: Date: Fri, 5 Aug 2022 08:57:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver Content-Language: en-US To: Shenwei Wang , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, brgl@bgdev.pl, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220804184908.470216-1-shenwei.wang@nxp.com> <20220804184908.470216-4-shenwei.wang@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220804184908.470216-4-shenwei.wang@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2022 20:49, Shenwei Wang wrote: > The SCU firmware on i.MX8 platforms provides a set of APIs to > control the GPIO PINs on the SCU domain. This patch implements the > standard GPIO driver interface to access those PINs on the > SCU domain over the SCU APIs. > > Signed-off-by: Shenwei Wang > --- > drivers/firmware/imx/Kconfig | 6 ++ > drivers/firmware/imx/Makefile | 1 + > drivers/firmware/imx/imx-scu-gpio.c | 139 ++++++++++++++++++++++++++++ > 3 files changed, 146 insertions(+) > create mode 100644 drivers/firmware/imx/imx-scu-gpio.c > > diff --git a/drivers/firmware/imx/Kconfig b/drivers/firmware/imx/Kconfig > index c027d99f2a59..484c13f3149a 100644 > --- a/drivers/firmware/imx/Kconfig > +++ b/drivers/firmware/imx/Kconfig > @@ -28,3 +28,9 @@ config IMX_SCU_PD > depends on IMX_SCU > help > The System Controller Firmware (SCFW) based power domain driver. > + > +config IMX_SCU_GPIO > + def_bool y > + depends on IMX_SCU > + help > + Say Y here to enable the imx8 gpio over SCFW MISC API gpio driver go to drivers/gpio/ Best regards, Krzysztof