Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp1429507rwb; Fri, 5 Aug 2022 01:32:24 -0700 (PDT) X-Google-Smtp-Source: AA6agR6j+YZIKXuglaVYUdjgqFYkE8r/IbamTQpKv/9z8pe0ImhNC6JkCKoauBhIvbtFcbe0ygS1 X-Received: by 2002:a17:902:6b0a:b0:16c:38eb:b516 with SMTP id o10-20020a1709026b0a00b0016c38ebb516mr5666565plk.15.1659688343781; Fri, 05 Aug 2022 01:32:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659688343; cv=none; d=google.com; s=arc-20160816; b=V5ywF2n+rtCs8yevCKdTXIJCRqVDwmevNCWj3EQZOM/DmptAksL2JJKwr1WOipHyDW M5mTd6zsv6fcuvK67yMamIor76xY8zx21o6cHEqZuIDGQparQeC9zdC/X4KCjqCeg3Nl n7kdviWZD/IkRa0pwIR4yE3dRFMAjcmphOV03fA72nOCkLDHzMvDuuZ+RRRNdqOa3igq GZihqzjdud4+I+V9MJVONqN1UVwYZSfUz0fzmzXTJw62EMeP1uM2w/Te7z8+4A9SVAr7 pCpjC5rKiwy842C/t760WGoSsT7n+Mb3wszJSLo17frctXGmUW8warcUQGAaVQNT8Qhl eUew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tvpNkzVObhIrvFK0rRsZAIVBMDWvMG9EjqQfvpfVC8A=; b=AiiAfZvDUtXUoMPehlZ9Pt2pkzM+czSI+SvKVGsgJXb8xnlGD+mOasuBO9m096FgrG fCo801PJrZKMRUJewbyzBLpzs/XZ+Jq5qGnQdB7f3gqWRDoP3PGSbt88w/lh0IN1DO2W nka2ACLckvX+gyel6zBGNnbxA75ubOY14O9L0tyOJ0rlwlK3VAKHK6eyi30lu6T609H6 yCZv3ZeOfgwZYhF/RvdUxI+35dx0vE2coxxe8RemE1UgjXTF1pJ2H1O9CToUexRpT59+ LjCqCOycs0AVtPAGkwJVAefJAY22ecSOdKmEoovY1L1oItH8WfsVZ1xe/K/bsvFPSHSK MBVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k9ctC4Aw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o24-20020a635d58000000b0041a94732ec6si2182892pgm.801.2022.08.05.01.32.01; Fri, 05 Aug 2022 01:32:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k9ctC4Aw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237960AbiHEHpI (ORCPT + 99 others); Fri, 5 Aug 2022 03:45:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230441AbiHEHpE (ORCPT ); Fri, 5 Aug 2022 03:45:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CFE9FE5; Fri, 5 Aug 2022 00:45:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CDEAD616C5; Fri, 5 Aug 2022 07:45:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33AC1C433B5; Fri, 5 Aug 2022 07:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659685502; bh=3uWbqT42BniSI/9bdvMcYnJrSiBwh8YbURul3ZSw2bQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k9ctC4AwDDvOGGvvqHHTcCKdJ18IT2l89Z2bKpC3S1FCkMH6XZZ/S0vmLKWdtrstG 83JSZmS/Q7SFRD77DvRaLq8a59WG4+HD6mwjrOEQvhUEy6cRVF5tZ4Rz8XVdFtPLex 9CNpePfAGtkgbw9w9+ygWjKIo4oTxiMc2p+f4mij7OkMmLAGm9I3GKRDVtPGbKJDYu e8QZLkXwYzyYo4xbuMuXKxUfnFQ1JC+0gqUFi8mKnGHKkrWHkGeHsmxq1jhMsiXFoY DdADwwK22saoLW3+P+ubCvuPdCmyneEgRKhGxFCIYmTQvK9D5QyAGZH1ZZy9G1kX96 sVXxMGuSyLxUw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oJs1O-0005ah-15; Fri, 05 Aug 2022 09:45:26 +0200 From: Johan Hovold To: Greg Kroah-Hartman , Felipe Balbi Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 1/2] usb: dwc3: qcom: only parse 'maximum-speed' once Date: Fri, 5 Aug 2022 09:44:59 +0200 Message-Id: <20220805074500.21469-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220805074500.21469-1-johan+linaro@kernel.org> References: <20220805074500.21469-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a temporary variable to the interconnect-initialisation helper to avoid parsing and decoding the 'maximum-speed' devicetree property twice. Signed-off-by: Johan Hovold --- drivers/usb/dwc3/dwc3-qcom.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 6814861bed6c..196efa9f2545 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -243,6 +243,7 @@ static int dwc3_qcom_interconnect_disable(struct dwc3_qcom *qcom) */ static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom) { + enum usb_device_speed max_speed; struct device *dev = qcom->dev; int ret; @@ -263,8 +264,8 @@ static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom) return PTR_ERR(qcom->icc_path_apps); } - if (usb_get_maximum_speed(&qcom->dwc3->dev) >= USB_SPEED_SUPER || - usb_get_maximum_speed(&qcom->dwc3->dev) == USB_SPEED_UNKNOWN) + max_speed = usb_get_maximum_speed(&qcom->dwc3->dev); + if (max_speed >= USB_SPEED_SUPER || max_speed == USB_SPEED_UNKNOWN) ret = icc_set_bw(qcom->icc_path_ddr, USB_MEMORY_AVG_SS_BW, USB_MEMORY_PEAK_SS_BW); else -- 2.35.1